From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52643C6379F for ; Wed, 8 Feb 2023 16:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D562A6B0071; Wed, 8 Feb 2023 11:40:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDED66B007B; Wed, 8 Feb 2023 11:40:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31A36B007D; Wed, 8 Feb 2023 11:40:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9D32A6B0071 for ; Wed, 8 Feb 2023 11:40:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 34CFE40F39 for ; Wed, 8 Feb 2023 16:40:42 +0000 (UTC) X-FDA: 80444688324.13.CBB9CFF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id D266710001D for ; Wed, 8 Feb 2023 16:40:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vfT1tSdJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A3dlU/Oc"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675874439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1KlVZ9F3aIxHpgD6Jwxy+qwJV6X/hM6MXtY37o4YVE=; b=bDQXjAR+wh9+yTcTi9U76mWZGnpuWupTe+OtVbs9uZaAdnqdsQClpunXAVf7Axabg3lATU zUok3Y1siMHZXsBmgNkjkLq4ovq7YXPxlLUy7E71QGPocD8zMYqW0XGqg48j0mBW8sy6vs SoaFtIcVY6XxG5M0UI8qdysOO5x70i4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vfT1tSdJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="A3dlU/Oc"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675874439; a=rsa-sha256; cv=none; b=DN7tq5foFlpWkZG0EAqI3UyMJzsfcUkBmWJrykI1iB2hy0b2NtyDdRfA519ctrRM+7YUSa UeWH2WJgQgMHvn+a6AEWf4MpoO1RBSzw/qdH769CfHJdYbr3+cq2lF0MmifNYVF8EnQgpF Bw5dj3MiZieiI0d0Cbm67jtYd8Qqeyk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 42E3334280; Wed, 8 Feb 2023 16:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675874437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1KlVZ9F3aIxHpgD6Jwxy+qwJV6X/hM6MXtY37o4YVE=; b=vfT1tSdJK5Flqf27K9dNGf0xizCq/dyw/IQn8NX1aw2/Ju4kj/DKZj+lQHxtJ6BwoKrtsG uJrVlUMjvtKBRfkvfEn/yS5wiAoYWjYNBwFe/Qc52rFQEw7m/zPmxuv0JYTv13+KqElcy4 0IsdGtkCKGmsMOdftLY8sOOqpRt8grg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675874437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F1KlVZ9F3aIxHpgD6Jwxy+qwJV6X/hM6MXtY37o4YVE=; b=A3dlU/OcbcrnL4yzs0EZyrQIV18Shu7xP90WVUNWkJtBOyxhmkeghRv6TVMInq6fp8waNw ivF+kpXS3Iqpk3CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D6211358A; Wed, 8 Feb 2023 16:40:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Jc2CBoXQ42OvXwAAMHmgww (envelope-from ); Wed, 08 Feb 2023 16:40:37 +0000 Message-ID: Date: Wed, 8 Feb 2023 17:40:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 04/18] lib/stackdepot, mm: rename stack_depot_want_early_init Content-Language: en-US To: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko Cc: Andrey Konovalov , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D266710001D X-Stat-Signature: opdc5m8hc9t7xhqwx3e8xsrfogxtneb6 X-Rspam-User: X-HE-Tag: 1675874438-914189 X-HE-Meta: U2FsdGVkX1/aoQtnT2RZZAcmfxQRTh1wr/vcSdJ9zPiI5ejbav20JMo9DZjPZlS9Oa1uitdbx3r4uk0eqn78XEE8vnX87TA6igogdeprc9+j11atBVflo9mupdn30i16X+ybiUUJw690NuvKCwq3htY5JSeJfL2L3cxdYwTS5M9tacHoUptxAb5zydPOnOiS5wJ/GW8aBEkKwCqD8fIDsP4jMEVuT7/UAUvTyCJyzS9IuuA8w8ScdfFTsWoe2h6AzGOsrYfR1kCUjfN1kQJ9SY8Ld8Z2We4FRW5YdvtuKlLzMvfss0CIfJHSv4VnXseJPdPJv8XqpG5H0zZhRRQo3yFCznURy9GfBKWwY2NB4hRQtdyH1/lUUyZ5/sX87//ZQZ5G2wNCYAtEshuglmxI87Z0wjCUoX1Dk6cPfqvufaU3xOi6ocSLcE+WnCJQTyrfypMLUQMuxHioINvE5ndLqS7dpZ1rXpODL1bnWAQ/3qrd7Asr1gHWMQkDlkhj+ZnBoB4jus3WXsddLDYY7qVdXyVE2ILREgtYojE4TCsHeb1/LYs5wYQDPkWwk7QJUgi4cvounpHxU2Q+jnjyXxexymXpwDZqXoPI7naOuTT4n2iP0xLuOPijblDhGyFLjV2erV7J9/eQcvYnIdg0uzjBNb0BdLAy33xsyZLAKFhkzwSETfoRctYxBnPH7fm09xDY37PYKDInX8roW6+rZcBwMkcH2n0g9u2MoSK6ka3QqijYuLhdO7hmO2+bkjFA8ZX3LXmcvfsX29jAKX8VbfShRt+EcdY/wWXk89NeIKTFmaCvz2a4nCEclD1esOqHbjEumL0vFITX0ZBR7rPXERP9+/f7BQw49/dfSxDbSmVYyvqvpvOKsns0wzfDvinaSinr5qG6sSEzVRe30EHaQlUYq6Q9d0E+seYUDIaU8AoC902XII/F13jBVT0i6oUHaRlKFT1bh3GNXoNdo/AIFko d5XNUkJz Fl6v+ayNUYFj12ZJ9MbDXNf4N6x7F8E/iUdP2RdGUfPSGNVc3IV87QgC7wqkSRPiEHex8rX6dsXM67z7fNNRTakuXH01OdvQWTahdKzOO4Gjm5s3TdczM5kG4tagcFWr0qyzAsUxE8+o4V+rxqg12gtDDFr+tdvIEf0suo8Z3Yw+NpT7TvNK7kMT5SgaESO/lHksT/jlE01z4AV4eSgrwW1rMHePyQvee0OBUyXzAsxIeBXoVxIZw/5z+2oGbUUu4OxEWdsNNhb07DT4bYxDxLnlUxx4TUWDM2l5B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/23 21:49, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Rename stack_depot_want_early_init to stack_depot_request_early_init. > > The old name is confusing, as it hints at returning some kind of intention > of stack depot. The new name reflects that this function requests an action > from stack depot instead. > > No functional changes. > > Signed-off-by: Andrey Konovalov Acked-by: Vlastimil Babka > --- > include/linux/stackdepot.h | 14 +++++++------- > lib/stackdepot.c | 10 +++++----- > mm/page_owner.c | 2 +- > mm/slub.c | 4 ++-- > 4 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h > index 1296a6eeaec0..c4e3abc16b16 100644 > --- a/include/linux/stackdepot.h > +++ b/include/linux/stackdepot.h > @@ -31,26 +31,26 @@ typedef u32 depot_stack_handle_t; > * enabled as part of mm_init(), for subsystems where it's known at compile time > * that stack depot will be used. > * > - * Another alternative is to call stack_depot_want_early_init(), when the > + * Another alternative is to call stack_depot_request_early_init(), when the > * decision to use stack depot is taken e.g. when evaluating kernel boot > * parameters, which precedes the enablement point in mm_init(). > * > - * stack_depot_init() and stack_depot_want_early_init() can be called regardless > - * of CONFIG_STACKDEPOT and are no-op when disabled. The actual save/fetch/print > - * functions should only be called from code that makes sure CONFIG_STACKDEPOT > - * is enabled. > + * stack_depot_init() and stack_depot_request_early_init() can be called > + * regardless of CONFIG_STACKDEPOT and are no-op when disabled. The actual > + * save/fetch/print functions should only be called from code that makes sure > + * CONFIG_STACKDEPOT is enabled. > */ > #ifdef CONFIG_STACKDEPOT > int stack_depot_init(void); > > -void __init stack_depot_want_early_init(void); > +void __init stack_depot_request_early_init(void); > > /* This is supposed to be called only from mm_init() */ > int __init stack_depot_early_init(void); > #else > static inline int stack_depot_init(void) { return 0; } > > -static inline void stack_depot_want_early_init(void) { } > +static inline void stack_depot_request_early_init(void) { } > > static inline int stack_depot_early_init(void) { return 0; } > #endif > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 90c4dd48d75e..8743fad1485f 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -71,7 +71,7 @@ struct stack_record { > unsigned long entries[]; /* Variable-sized array of entries. */ > }; > > -static bool __stack_depot_want_early_init __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); > +static bool __stack_depot_early_init_requested __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); > static bool __stack_depot_early_init_passed __initdata; > > static void *stack_slabs[STACK_ALLOC_MAX_SLABS]; > @@ -107,12 +107,12 @@ static int __init is_stack_depot_disabled(char *str) > } > early_param("stack_depot_disable", is_stack_depot_disabled); > > -void __init stack_depot_want_early_init(void) > +void __init stack_depot_request_early_init(void) > { > - /* Too late to request early init now */ > + /* Too late to request early init now. */ > WARN_ON(__stack_depot_early_init_passed); > > - __stack_depot_want_early_init = true; > + __stack_depot_early_init_requested = true; > } > > int __init stack_depot_early_init(void) > @@ -128,7 +128,7 @@ int __init stack_depot_early_init(void) > if (kasan_enabled() && !stack_hash_order) > stack_hash_order = STACK_HASH_ORDER_MAX; > > - if (!__stack_depot_want_early_init || stack_depot_disable) > + if (!__stack_depot_early_init_requested || stack_depot_disable) > return 0; > > if (stack_hash_order) > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 2d27f532df4c..90a4a087e6c7 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -48,7 +48,7 @@ static int __init early_page_owner_param(char *buf) > int ret = kstrtobool(buf, &page_owner_enabled); > > if (page_owner_enabled) > - stack_depot_want_early_init(); > + stack_depot_request_early_init(); > > return ret; > } > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..f2c6c356bc36 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1592,7 +1592,7 @@ static int __init setup_slub_debug(char *str) > } else { > slab_list_specified = true; > if (flags & SLAB_STORE_USER) > - stack_depot_want_early_init(); > + stack_depot_request_early_init(); > } > } > > @@ -1611,7 +1611,7 @@ static int __init setup_slub_debug(char *str) > out: > slub_debug = global_flags; > if (slub_debug & SLAB_STORE_USER) > - stack_depot_want_early_init(); > + stack_depot_request_early_init(); > if (slub_debug != 0 || slub_debug_string) > static_branch_enable(&slub_debug_enabled); > else