From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADFBC63697 for ; Wed, 18 Nov 2020 10:57:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 402FB221F1 for ; Wed, 18 Nov 2020 10:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ec2dXjyK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 402FB221F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6ED6D6B0036; Wed, 18 Nov 2020 05:57:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69C316B005C; Wed, 18 Nov 2020 05:57:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B36F6B0068; Wed, 18 Nov 2020 05:57:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 2F1596B0036 for ; Wed, 18 Nov 2020 05:57:49 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C18FC181AEF30 for ; Wed, 18 Nov 2020 10:57:48 +0000 (UTC) X-FDA: 77497238616.19.game43_4707e4927339 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 9423F1ACEA2 for ; Wed, 18 Nov 2020 10:57:48 +0000 (UTC) X-HE-Tag: game43_4707e4927339 X-Filterd-Recvd-Size: 4312 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 10:57:48 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id o9so2156739ejg.1 for ; Wed, 18 Nov 2020 02:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Ujs+84h/AV5va5lsnNUE6Cha4z0WdYf4Awwp5uvYq2s=; b=ec2dXjyKAgBuZgQiPsDp5dlX2Axa3/ZR+q3LPAUbNQK51MefRbkfyUzwGdwcFCNNsl DmAkYKWSssBL8pDXSTuIMb03r27h8P3C7U+//k3tiWfmUbqOc6vYiFgAr7mFQguCiSkc OrEEYzGMqPmV/YS7MOh6wuDzbz4ZtukA4ppcicdJqLSkgi9vmxq6hUetlEIql9xC1e+D gJYjQu75/yP0gqDhZ9DoHavl6V6VBNPHDiB4x1nDLZ49YGYM471bij22ozZh9FBiPYHY mft78EPbgAOqjcnAMJTpESq0Q+59GL2BcUtH6vopcqxr4H2uFtMKhBjytC9I6vggoFOh CQlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=Ujs+84h/AV5va5lsnNUE6Cha4z0WdYf4Awwp5uvYq2s=; b=LUDYbtVQi24AJ6NNkv2Yp/O9aeKaA17kyv3HkRNyL2oaQa462yHaCEkOUsu6BH0sMN WvnZwOSuQ4q07r+5VNd53AVt2T5cu/wIqsiZUjxgAFC4uzeA++eIX7vATK5sp3X6v/0p 3bxYToyJ/VWHdmo+edN0JoWHipgYWLjq4PblS0FOrsphxrSCkCZ5XaB22Z0XQ1L3zJNk tO+DHTPySpTGq5gSbEL7V/rw9w/WiBLq1SHUtZTGK/qEbM5Ow1XVQDKW4NydpslXLW8O dKejx7DAIjyYzSKbfbOku+WT09bi84r1DuBJ7cr1hZci6JebQazzk4Q1GOVEvyhvg+5y yWOw== X-Gm-Message-State: AOAM533DMltULEUls+rGHRlxkY1Qph4B8U/NEJEGlGXARZ8PYvjrUYyh SZzd5VByh/SsftaLir0u8wc= X-Google-Smtp-Source: ABdhPJzwcar3mNBUaai8RXeIr42FsqX4abG+v5tYsTGBLf/nO0azD5aQGORqzDbjWMSqF0AU+Vgykw== X-Received: by 2002:a17:906:2e0f:: with SMTP id n15mr6409546eji.486.1605697066669; Wed, 18 Nov 2020 02:57:46 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id n12sm12761784ejs.19.2020.11.18.02.57.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Nov 2020 02:57:46 -0800 (PST) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH 1/2] mm: mmap: fix fput in error path v2 To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org References: <20201106114806.46015-1-christian.koenig@amd.com> <20201106114806.46015-2-christian.koenig@amd.com> <20201106144811.cf228ca9278ec78887d42960@linux-foundation.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 18 Nov 2020 11:57:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201106144811.cf228ca9278ec78887d42960@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 06.11.20 um 23:48 schrieb Andrew Morton: > On Fri, 6 Nov 2020 12:48:05 +0100 "Christian K=C3=B6nig" wrote: > >> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." >> adds a workaround for a bug in mmap_region. >> >> As the comment states ->mmap() callback can change >> vma->vm_file and so we might call fput() on the wrong file. >> >> Revert the workaround and proper fix this in mmap_region. >> > Seems correct, best I can tell. Presumably all ->mmap() instances will > correctly fput() to original file* if they're rewriting vma->vm_file. Yes, exactly. Patch #2 provides a helper to make sure that everybody gets the=20 get_file()/fput() correctly while updating vma->vm_file. Can I add your acked-by to the patches and push them upstream through=20 drm-misc-next? Thanks, Christian.