From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E33BC67861 for ; Mon, 8 Apr 2024 18:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1606B0083; Mon, 8 Apr 2024 14:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 692106B0087; Mon, 8 Apr 2024 14:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531FD6B0088; Mon, 8 Apr 2024 14:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 370146B0083 for ; Mon, 8 Apr 2024 14:56:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BF2D61C004C for ; Mon, 8 Apr 2024 18:56:42 +0000 (UTC) X-FDA: 81987271044.16.300B21B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 7542316000D for ; Mon, 8 Apr 2024 18:56:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PtYK70Sk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712602600; a=rsa-sha256; cv=none; b=IBDpwh2C3P8mPJ+lWeIHhhScPO4XquqYr41VfJm+AE8YfU4uLREoO+usk8nZHKY/V8oSL6 XrO9zUm5vveIwDrWmBOdtLey2DVm7WnMA118Cy9ggHdgTqn/Xnm0fpJT0Tezzy+C+x6f5j m8nEY/XpzYqV2jV1DiXYlIeaP8jgLow= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PtYK70Sk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712602600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xnWH4wk34YOPWZxVPibW9ohz3Q4MqphqfBTi5y0aS9I=; b=kqKn0L+JCPo6P/H4s2ePx+kk1nBlrIOgNVZBOxP/taFEOizZ2u5eEzIMa9HiOPgsG7OE3Q 9Y/3siFcW5x41ByoH9VlFdtOlQWvAvI5hFGKmxnQ9ofdpFmWoekJd/xJ8h0C+65PiL/LRC jrkSXhnhoMHqLbpFZZa6/FCeiVRSI1w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712602599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xnWH4wk34YOPWZxVPibW9ohz3Q4MqphqfBTi5y0aS9I=; b=PtYK70SktuigMBl2PNDjhD1vIDl3LS4m0KsO5bNePGm7bilL/kETioL0jrhc8sIliCFjhc kUBXJgk6Re0x4ZnPkFVQT9sLJIXtMwGmBm4Rqbe0n/Eq5mTnREj7IzfFyjhLjnMBJ4OOaF OM/6AwQ3CZjpL5EwZyzUL4jyS8k9OOs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-hXCteZcaNj68t-UU2tc-wQ-1; Mon, 08 Apr 2024 14:56:38 -0400 X-MC-Unique: hXCteZcaNj68t-UU2tc-wQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4162b9b1702so21378885e9.2 for ; Mon, 08 Apr 2024 11:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712602597; x=1713207397; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xnWH4wk34YOPWZxVPibW9ohz3Q4MqphqfBTi5y0aS9I=; b=TRGE7GMKCBZa8YXqewMXGV7J2nRj/kUZKQgZKQn+20IoL+TAz0++xGhWZBjaLt7erS zGBjZmzvIC8Tej9Sh7+pxo9G/HqQqmFFHz3ybnVcdtbL+U/AYnS8HfW7L2VWFhwmS+LY 6J/CkwKmTfys1Rs2fnnJzerk7PpYwtLdPvwHWyw8qOkD4IOgoEl20stRqksu3uBsPLlR pik45C9YgQySw62rXmsDi0IGnFcgk03wa49Itvg32W2wS0WfXWHOJFR2I95qBVKRX0RW i7GWCMCRXxTrK5GlGl+FF97FCXXhHFhMHex1RkBzDW+0E13CbPhokIs+QRcszob5gatQ VS9w== X-Forwarded-Encrypted: i=1; AJvYcCVyJLPOmxJXT7PfhRldx8nwAxmBR1t57PedMTGUIHeXemYINUsIGKAfHl19Y/MqltmxPtn52j9bhKtQcTCAAxdzVWQ= X-Gm-Message-State: AOJu0YzLnqap4nKFScsQxLmVsOPZsTxd1Cfn++k2PezULClKUS581oKP 6WT5s0AuW9Vw+WOCdmpawu4jMkUHpVyyZnL2x3WCR694Q9EBLKZ3T6/RyV/u19kcw2bpZytnZy8 aHprKkUz+a41vdMnePWunYQzz41Le2BvhnHJEEZcbDOfNh39o X-Received: by 2002:a05:600c:5493:b0:416:70e5:d0dd with SMTP id iv19-20020a05600c549300b0041670e5d0ddmr2755857wmb.41.1712602596826; Mon, 08 Apr 2024 11:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEM4JH7cstceNmzXy/Op0NscY1rfDSNjbbFfhzEpJ2L2Uv+rebsORg9I8TLcHwdof94cBT6Vg== X-Received: by 2002:a05:600c:5493:b0:416:70e5:d0dd with SMTP id iv19-20020a05600c549300b0041670e5d0ddmr2755845wmb.41.1712602596409; Mon, 08 Apr 2024 11:56:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:1300:9860:66a2:fe4d:c379? (p200300cbc7181300986066a2fe4dc379.dip0.t-ipconnect.de. [2003:cb:c718:1300:9860:66a2:fe4d:c379]) by smtp.gmail.com with ESMTPSA id jg1-20020a05600ca00100b00414688af147sm17475960wmb.20.2024.04.08.11.56.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 11:56:36 -0700 (PDT) Message-ID: Date: Mon, 8 Apr 2024 20:56:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: set pageblock_order to HPAGE_PMD_ORDER in case with !CONFIG_HUGETLB_PAGE but THP enabled To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <3d57d253070035bdc0f6d6e5681ce1ed0e1934f7.1712286863.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3d57d253070035bdc0f6d6e5681ce1ed0e1934f7.1712286863.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7542316000D X-Stat-Signature: hu9eij6iz3ydugu7mr9rdqacsgnspztz X-HE-Tag: 1712602600-310878 X-HE-Meta: U2FsdGVkX1/l4pf4+nzc2wuEAoe5FRDHsc5eOdWeaOPwr8GMJT0FOGOxSXZpoHKURNq6uRyvh3O3Vc1ihvynUG3TlyIrY0SWjC5u5lTNnMIpNdwTRQsh5K2/Lwp49tNRXO5aPAtVFmhEP13bcaS6Z9ljoF5jGTqB85t/5Sn9td45Y4RvhkHVMuiD06BNcg6O4x6LsPptUhjMMo5za0JuC51v5CwkXMJ/c5EQighQtKx8d6kxtTQtnI6HN3wwku7bBpxJPUgqFifDR741xwQfvPrMVJsC88PyxKPK6aXkbzhvcDI+i89stiIOz8o+S79ZK34ELY7J+cScZus5pZrHVYVwD4U39X2Q8L083yX+GG9HrqaLCm4V6DXKGqEn0B8UiTzQFNNwet0poGQ858mvEw8U4iq20a9uGkVqlENy8Z/LZ1dN3IF5b9KQJ50ajD1myLj0oCBmqnQ4L2i01kRMbDPwhEkJ0qdI7Vsa2yVZsJuaREQELEKPPztYlRG9L7zhIP42rx/d6wADmUhKAS/sZds2/Su14jrXSO7sAk/STNMtByFEUuPxkDoyIqNj/1QElAOl6Fv3Xwx+6wHuq03WUZiQkMAz1QHOxi5Xbnwk2zRy/mycApNEs1tY/cy6XZU3R8p2I7s2fOo2mWlMMuQHeUXmthUGpRrd9eey/peT07vV/ZSy9mJWJ0P7SmGb+xJqb4v/va8/QOSRCao9BtWBTcjUun1Bx65aOdctHs3XX3SL8NPMZlhhJu5MUfKod5CzQ8pJxJmxx4N0xLmTnQWS5CpzESzvnWq8hAlt0yse3QFV0/j/2XtdKnxyIUdzV+hDJgKXTvBOKbWV1wps/ofJQ4z3AwRZKv8kJwDukHkV9d3HamQnpCLbx3C60kJhl5i1E3gW7eWZO4o/7DRGve2fpTgeZxiwvRtCgH+gWZCddwxdUvivOfnEJ97XjUgUUz5QT0vm4Ue7Chd/3gbTeLI 4DXCYEKH snYjJyrct0x/RPYZVBMc3iIDWrlaCv//1DaFRi92mKGuRSmYdJ2XSGudogyniTKhIAB27siLtGxhaAbdB8tqgGSShAcPNeZW+SScwC+e+XawhVRzDrTiRwFJrS37E20nB8m7wPHJVxnRyGVYdomZiAvH+QFjodJ7kGTikIvKUtis91ouc+Q9abiLKvGO5rkga6VfuA67enSSaTaYW1Cbf/dmeUMG2c+pj1pEQblTmJE2IEo3HJcjH6pijbA4GL2CvB2lhpYEkaEGcoW5FMC5kyh5wVgt5uq0oMQKsVgtQSJaDjvDD9cScIipQ8RVRGkQo1omO16lo0WjOpd+f1j74AIE/ff+Lrtqads9yWox7aVs2E0scYNQveK1m0iFUl3Eg5Dl/hSSoUU1mLVLYlYFQqVkhvENkc45gY5Df0Fv17XhumZS2q5oRvzhvqSaDzAPzK7O9DF3OQzoI0xxYf+Gud+XE/DV3mNCwHZRto7jewOGSSnx59aObnRCQr8+tM8wOv5X9LfSam0wBdI2nW1o/bUdsZd+lrrGYyH0Zj6hwmvMi56V79fdg+c8z7hX1bgbHMfvd1GEIRqkSGXH5CqtoC/hNunLO58nMFMoLjAKq/UzmYaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.04.24 14:24, Baolin Wang wrote: > As Vlastimil suggested in previous discussion[1], it doesn't make sense to set > pageblock_order as MAX_PAGE_ORDER when hugetlbfs is not enabled and THP is enabled. > Instead, it should be set to HPAGE_PMD_ORDER. > > [1] https://lore.kernel.org/all/76457ec5-d789-449b-b8ca-dcb6ceb12445@suse.cz/ > Suggested-by: Vlastimil Babka > Signed-off-by: Baolin Wang > --- > include/linux/pageblock-flags.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h > index 3f2409b968ec..547e82cdc89a 100644 > --- a/include/linux/pageblock-flags.h > +++ b/include/linux/pageblock-flags.h > @@ -28,7 +28,7 @@ enum pageblock_bits { > NR_PAGEBLOCK_BITS > }; > > -#ifdef CONFIG_HUGETLB_PAGE > +#if defined(CONFIG_HUGETLB_PAGE) > > #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE > > @@ -45,7 +45,11 @@ extern unsigned int pageblock_order; > > #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ > > -#else /* CONFIG_HUGETLB_PAGE */ > +#elif defined(CONFIG_TRANSPARENT_HUGEPAGE) > + > +#define pageblock_order min_t(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) > + > +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ > > /* If huge pages are not used, group by MAX_ORDER_NR_PAGES */ > #define pageblock_order MAX_PAGE_ORDER Acked-by: David Hildenbrand -- Cheers, David / dhildenb