From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3379C46CD2 for ; Tue, 30 Jan 2024 13:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D5276B0085; Tue, 30 Jan 2024 08:16:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4858B6B0087; Tue, 30 Jan 2024 08:16:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 326FD6B0088; Tue, 30 Jan 2024 08:16:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 23FA36B0085 for ; Tue, 30 Jan 2024 08:16:14 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E1DB2C0B49 for ; Tue, 30 Jan 2024 13:16:13 +0000 (UTC) X-FDA: 81736025826.06.F2C8626 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 7CD4D100028 for ; Tue, 30 Jan 2024 13:16:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kuipvvRH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="TVaiJwa/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQQqIBom; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yMtdf8av; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706620570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCNq95+0rNCD2kp/hKAX5Oke9fUmnEml0yRbLl6Ruxw=; b=I0CKcWjFuz/IIyXhDBTCxz0zysF4U7vk+/HBUyV+G8dOqOJbQAJ5B3CctiZOs9+sc28Wg5 fUSpEge5RbA0w5kyucx6txoOkgtx1BxKrhlOxEnOTpTsHpHPDs7ncWPHoD2gEWImV17/LO PvjUSGfy7yYEorurBqlEP5h4++1XruA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706620570; a=rsa-sha256; cv=none; b=2Upcv3VMtG/wUTA+Dr9G/EsS5JrsZDAwGfQJIe0Pf/sc7kf/dbpUc4umpy1uBdizldyon9 c9AnvwllFxFbmZuEDrfUf0lk5+ehuohKw+aE+J0wYUpfcq8us42nOS8M//vo57ingYr/wV GF2VGwXJoJLkcXyHedsAmjfLbkQDv7A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kuipvvRH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="TVaiJwa/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQQqIBom; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yMtdf8av; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 855201F84A; Tue, 30 Jan 2024 13:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706620568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCNq95+0rNCD2kp/hKAX5Oke9fUmnEml0yRbLl6Ruxw=; b=kuipvvRHAvzTQ+A7AvAZFcMzriCKYKUNWAgTzhiX0PZRFcWd2bTgx7ZtBzvU+9dbz5F+Kk mhnzHuG9R4iWzBLwsdXgqbqRO+MpGUVlh2kr7sQmHLMFy3iFuEKtAOAwVqzhD2QFpgTWlV WEWRYER3uq+kInX+h3u4TA1nG4uvfEU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706620568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCNq95+0rNCD2kp/hKAX5Oke9fUmnEml0yRbLl6Ruxw=; b=TVaiJwa/GeGS1+L9+5/rTFN1xODWweM9oYSvxK8EHMANFo7NUjVqK+66RXbX86q7GAfxn4 N/+x3sDWfg8K3nCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706620567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCNq95+0rNCD2kp/hKAX5Oke9fUmnEml0yRbLl6Ruxw=; b=LQQqIBomU7yb+znQm6ltiLwJDTZoN+kYWf42c8yxRV4tqANHD6Mc7Qq2g2WgM/1FSeVW// mzfTywwSLaiFpVJAChjXvkqf7386B2OUxbJQ/bxC2WLrcal6mut/69JxCf1KZk0N9oN092 k+HHB/rGM5lm1kPdPoecmcKbBbIhILQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706620567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wCNq95+0rNCD2kp/hKAX5Oke9fUmnEml0yRbLl6Ruxw=; b=yMtdf8avSWT2b/snjWyDhLsFTO2qRHbMubYXCu+rcJNR9UtTc5FBThLtGpkJnqP5Rj7ige 2kijJP3Wfvby7SDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6CCC712FF7; Tue, 30 Jan 2024 13:16:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g9UkGpf2uGURWgAAD6G6ig (envelope-from ); Tue, 30 Jan 2024 13:16:07 +0000 Message-ID: Date: Tue, 30 Jan 2024 14:16:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slub: remove parameter 'flags' in create_kmalloc_caches() Content-Language: en-US To: Zheng Yejian , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240130014107.1262373-1-zhengyejian1@huawei.com> From: Vlastimil Babka In-Reply-To: <20240130014107.1262373-1-zhengyejian1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7CD4D100028 X-Rspam-User: X-Stat-Signature: etupybzx1patshjuwfey8mdecy77qxre X-Rspamd-Server: rspam03 X-HE-Tag: 1706620570-893788 X-HE-Meta: U2FsdGVkX18UPg4b+zZCoIV/FfFd/BUMHxpB6hI3dETvhq8ocb56+UjGRP6FHiwTMbm0oKVsp7Jm3/YUPKhh6Ay1uFj9gm57mIblu1Jf1Bmnl7AlkjE21Ad6e+aDi9+phyQq6xwKOa0AbK6zPjaOoTJjjgXr0NcmZxx/gc0KqHa2X/jwyDUy0GQVr8cxKJfk1eoV0HIFRpxcVV0Tl9cNNwL2ea4YfBiEdS3GO5O4GD7tnByohx4erKyzN62/uFK4ogqp5eYeJ5m6jxx5cWQRIaWQxRgs52Wg2/8S0plVFtsxyHEnvU4NEzPww+txASwCNSpFqlu36+PEaNxh7guMArOko3ls2m8I0w7Ss0ktR/PtZtdw0Y/ptjfmVyRAKkTdxzrayIwyzE2w3mTxose15FUAWkF/DjHDdnEvrknpAg4y8uhaC0hWDjNjSFbdye82vb8k6iomBZeKhe3NCwbJhD4pssiGUAvbR40NVArVejc8rtau9zHpEgfhkdq3046I0NK7PVBX99uWtNm6cvucMlb9BLph0b4A13YiZLrN2azC8Ju2KMNbgFUHRLT2We2mwxSuyMnXrIUlMP0dzEp3N60APmgZpuWhaWlDmwQpLPz1F2ovut3sVu5QCyrh1lL9v0fpYWX9uumqXlzNWoJU4tZ/k7M+rpzAs8nwYcVXnkrMuV9HBJLmjBzkQ11rKiHxDtQQh18AYpR4iGwMAELl8bcDSKKjbE+eeFPfBaMvTrtlvqtIyGBq4artVDxEgAbXCaYZzc1ICRSbhUDlGKvzasBlQZ/i2rooMhFD0qUsjIkyDOD3h0arczx55huKsMOzhOixJ4UfPoCE/4BjPSdKk8KNQvDk/TcLC2ydR71An5jO5Wv1l8/56yQSu4A3nmX4Bpbj7Y+yq/dcUyM6rDJ7ixMUj4ykPezHeKNfXB+pPlPtO87exHJoxKVzA1KjoouhanAD2LTRLCMfiO4t6Uy VuU6qYrX tTL2iw61peS+GBscK+qxmazFSlyqE6ITz+0kr7LpW1mArJIytHbOAHQU9uYWQHCdtao/7bEynvMbPZWPglRQr9GLzsKt5aPYExGq4d4qe6uAYYmj8viN3UHuQTa73BEg4Jt2EC/FfkC3Fdgdoj1jry2vcvBFQU34aw/KXlY9HGBHSORKB8le3p9eF339CgGDEvWRSWnvXYrrORKzOEEKHOeXgnnfAw2S9MdRxd85IOEyMGBB7Bwo5lkX0nX2RFRpxHgByMIOUIu5VkuZVi4a1pyvy96dds+xGHALaweAV8YIZ59s+LI6uKATqDFF0wq8DwZOFMP5IA/wXQRV5Yw5xsp4ttL0IZh2vTnY42HZoDEGZynpyWZTU8TVHTCtt1zaGQLGbvmL711bjRlE9rh7RVbxe1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/30/24 02:41, Zheng Yejian wrote: > After commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"), > parameter 'flags' is only passed as 0 in create_kmalloc_caches(), and > then it is only passed to new_kmalloc_cache(). > > So we can change parameter 'flags' to be a local variable with > initial value 0 in new_kmalloc_cache() and remove parameter 'flags' > in create_kmalloc_caches(). Also make new_kmalloc_cache() static > due to it is only used in mm/slab_common.c. > > Signed-off-by: Zheng Yejian Thanks, merged for 6.9