From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Alexander Aring <aahringo@redhat.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
David Teigland <teigland@redhat.com>
Subject: [linux-next:master 3779/3984] fs/dlm/main.c:57 init_dlm() warn: missing error code 'error'
Date: Sun, 11 Aug 2024 16:34:58 +0300 [thread overview]
Message-ID: <e57a6935-bb99-4136-b181-1c98ba32e172@stanley.mountain> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 61c01d2e181adfba02fe09764f9fca1de2be0dbe
commit: 94e180d6255f5a765bb723e6e8b67f1438ce574b [3779/3984] dlm: async freeing of lockspace resources
config: x86_64-randconfig-161-20240810 (https://download.01.org/0day-ci/archive/20240811/202408110800.OsoP8TB9-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202408110800.OsoP8TB9-lkp@intel.com/
smatch warnings:
fs/dlm/main.c:57 init_dlm() warn: missing error code 'error'
vim +/error +57 fs/dlm/main.c
e7fd41792fc0ee David Teigland 2006-01-18 27 static int __init init_dlm(void)
e7fd41792fc0ee David Teigland 2006-01-18 28 {
e7fd41792fc0ee David Teigland 2006-01-18 29 int error;
e7fd41792fc0ee David Teigland 2006-01-18 30
e7fd41792fc0ee David Teigland 2006-01-18 31 error = dlm_memory_init();
e7fd41792fc0ee David Teigland 2006-01-18 32 if (error)
e7fd41792fc0ee David Teigland 2006-01-18 33 goto out;
e7fd41792fc0ee David Teigland 2006-01-18 34
8b0188b0d60b6f Alexander Aring 2022-11-17 35 dlm_midcomms_init();
8b0188b0d60b6f Alexander Aring 2022-11-17 36
e7fd41792fc0ee David Teigland 2006-01-18 37 error = dlm_lockspace_init();
e7fd41792fc0ee David Teigland 2006-01-18 38 if (error)
e7fd41792fc0ee David Teigland 2006-01-18 39 goto out_mem;
e7fd41792fc0ee David Teigland 2006-01-18 40
e7fd41792fc0ee David Teigland 2006-01-18 41 error = dlm_config_init();
e7fd41792fc0ee David Teigland 2006-01-18 42 if (error)
e7fd41792fc0ee David Teigland 2006-01-18 43 goto out_lockspace;
e7fd41792fc0ee David Teigland 2006-01-18 44
a48f9721e6db74 Greg Kroah-Hartman 2019-06-12 45 dlm_register_debugfs();
e7fd41792fc0ee David Teigland 2006-01-18 46
597d0cae0f99f6 David Teigland 2006-07-12 47 error = dlm_user_init();
597d0cae0f99f6 David Teigland 2006-07-12 48 if (error)
ac33d071059557 Patrick Caulfield 2006-12-06 49 goto out_debug;
597d0cae0f99f6 David Teigland 2006-07-12 50
2402211a838928 David Teigland 2008-03-14 51 error = dlm_plock_init();
2402211a838928 David Teigland 2008-03-14 52 if (error)
01c7a597899320 Alexander Aring 2023-03-06 53 goto out_user;
2402211a838928 David Teigland 2008-03-14 54
94e180d6255f5a Alexander Aring 2024-08-02 55 dlm_wq = alloc_workqueue("dlm_wq", 0, 0);
94e180d6255f5a Alexander Aring 2024-08-02 56 if (!dlm_wq)
94e180d6255f5a Alexander Aring 2024-08-02 @57 goto out_plock;
error = -ENOMEM;
94e180d6255f5a Alexander Aring 2024-08-02 58
75ce481e15911b Michal Marek 2011-04-01 59 printk("DLM installed\n");
e7fd41792fc0ee David Teigland 2006-01-18 60
e7fd41792fc0ee David Teigland 2006-01-18 61 return 0;
e7fd41792fc0ee David Teigland 2006-01-18 62
94e180d6255f5a Alexander Aring 2024-08-02 63 out_plock:
94e180d6255f5a Alexander Aring 2024-08-02 64 dlm_plock_exit();
3ae1acf93a2151 David Teigland 2007-05-18 65 out_user:
3ae1acf93a2151 David Teigland 2007-05-18 66 dlm_user_exit();
e7fd41792fc0ee David Teigland 2006-01-18 67 out_debug:
e7fd41792fc0ee David Teigland 2006-01-18 68 dlm_unregister_debugfs();
e7fd41792fc0ee David Teigland 2006-01-18 69 dlm_config_exit();
e7fd41792fc0ee David Teigland 2006-01-18 70 out_lockspace:
e7fd41792fc0ee David Teigland 2006-01-18 71 dlm_lockspace_exit();
e7fd41792fc0ee David Teigland 2006-01-18 72 out_mem:
8b0188b0d60b6f Alexander Aring 2022-11-17 73 dlm_midcomms_exit();
e7fd41792fc0ee David Teigland 2006-01-18 74 dlm_memory_exit();
e7fd41792fc0ee David Teigland 2006-01-18 75 out:
e7fd41792fc0ee David Teigland 2006-01-18 76 return error;
e7fd41792fc0ee David Teigland 2006-01-18 77 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-08-11 13:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57a6935-bb99-4136-b181-1c98ba32e172@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aahringo@redhat.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox