From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF776C12002 for ; Wed, 21 Jul 2021 14:15:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6ABB460FE7 for ; Wed, 21 Jul 2021 14:15:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ABB460FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E102E6B0081; Wed, 21 Jul 2021 10:15:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D99D36B0082; Wed, 21 Jul 2021 10:15:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3A086B0083; Wed, 21 Jul 2021 10:15:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A6A236B0081 for ; Wed, 21 Jul 2021 10:15:32 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve03.hostedemail.com (Postfix) with ESMTP id 34D561808999F for ; Wed, 21 Jul 2021 10:38:23 +0000 (UTC) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C78FA18269D56 for ; Wed, 21 Jul 2021 10:38:22 +0000 (UTC) X-FDA: 78386245644.10.D06FC15 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 4B96050180D5 for ; Wed, 21 Jul 2021 10:38:22 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7CEA431B; Wed, 21 Jul 2021 03:38:21 -0700 (PDT) Received: from [10.163.64.235] (unknown [10.163.64.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B82163F694; Wed, 21 Jul 2021 03:38:17 -0700 (PDT) Subject: Re: [PATCH v3 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com, Christophe Leroy , Gerald Schaefer , Qian Cai , "Aneesh Kumar K.V" References: <20210719130613.334901-1-gshan@redhat.com> <20210719130613.334901-2-gshan@redhat.com> <280a5740-b5dc-4b78-3a38-67e5adbb0afd@redhat.com> From: Anshuman Khandual Message-ID: Date: Wed, 21 Jul 2021 16:09:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <280a5740-b5dc-4b78-3a38-67e5adbb0afd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4B96050180D5 X-Stat-Signature: 3g4rwdr8pcupmyk61soiqjnrpmssx4yt Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-HE-Tag: 1626863902-757258 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/21 3:50 PM, Gavin Shan wrote: > Hi Anshuman, >=20 > On 7/21/21 3:44 PM, Anshuman Khandual wrote: >> On 7/19/21 6:36 PM, Gavin Shan wrote: >>> In debug_vm_pgtable(), there are many local variables introduced to >>> track the needed information and they are passed to the functions for >>> various test cases. It'd better to introduce a struct as place holder >>> for these information. With it, what the functions for various test >>> cases need is the struct, to simplify the code. It also makes code >>> easier to be maintained. >>> >>> Besides, set_xxx_at() could access the data on the corresponding page= s >>> in the page table modifying tests. So the accessed pages in the tests >>> should have been allocated from buddy. Otherwise, we're accessing pag= es >>> that aren't owned by us. This causes issues like page flag corruption= . >>> >>> This introduces "struct pgtable_debug_args". The struct is initialize= d >>> and destroyed, but the information in the struct isn't used yet. They >>> will be used in subsequent patches. >>> >>> Signed-off-by: Gavin Shan >>> --- >>> =C2=A0 mm/debug_vm_pgtable.c | 197 ++++++++++++++++++++++++++++++++++= +++++++- >>> =C2=A0 1 file changed, 196 insertions(+), 1 deletion(-) >>> >=20 > I saw you've finished the review on PATCH[v3 01/12] and PATCH[v3 02/12]= . > I will wait to integrate your comments to v4 until you finish the revie= w > on all patches in v3 series Yes, please do wait for the complete review and test before going for V4. Also please add the following emails on copy next time, so that we might have some more reviews here. Thank you. + Christophe Leroy + Gerald Schaefer + Qian Cai + Aneesh Kumar K.V