From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA33C2D0A8 for ; Mon, 28 Sep 2020 22:20:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 335C923976 for ; Mon, 28 Sep 2020 22:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="aUo++/WB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 335C923976 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C897A8E0001; Mon, 28 Sep 2020 18:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C121A6B005D; Mon, 28 Sep 2020 18:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9908E0001; Mon, 28 Sep 2020 18:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 94F186B005C for ; Mon, 28 Sep 2020 18:20:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 50826181AE868 for ; Mon, 28 Sep 2020 22:20:55 +0000 (UTC) X-FDA: 77313891270.12.quiet94_600b30827185 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 286C018006CEB for ; Mon, 28 Sep 2020 22:20:55 +0000 (UTC) X-HE-Tag: quiet94_600b30827185 X-Filterd-Recvd-Size: 3791 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Sep 2020 22:20:54 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 28 Sep 2020 15:20:03 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 28 Sep 2020 22:20:48 +0000 Subject: Re: [PATCH 1/2] ext4/xfs: add page refcount helper To: Christoph Hellwig CC: , , , , Dan Williams , Ira Weiny , Matthew Wilcox , Jerome Glisse , John Hubbard , Alistair Popple , Jason Gunthorpe , Bharata B Rao , Zi Yan , "Kirill A . Shutemov" , Yang Shi , Paul Mackerras , Ben Skeggs , Andrew Morton References: <20200925204442.31348-1-rcampbell@nvidia.com> <20200925204442.31348-2-rcampbell@nvidia.com> <20200926063539.GA3540@lst.de> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: Date: Mon, 28 Sep 2020 15:20:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200926063539.GA3540@lst.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601331603; bh=kXgGmngSFGVJLCne8DZRhWZR5kT4/vprhys6/EFUF2M=; h=Subject:To:CC:References:X-Nvconfidentiality:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=aUo++/WBuUmLpUNBybZqcSQddWcOAIgf4CiMoG8F4r7DyK/3GkcxcNtxtJXcGJ8PN JvprWJRK7sbeM2NyReaAn7I987qhfn6ckD/XANP2zADXzuiDLD7eThOUjsYwuwDpiz hu+TdV/9fyzLHRNHLAwtjvkg9n/0Jjl45ksOv1QRU8V/kTmdTC+mkEPHuWxe+ZOXOP oR+WkNXbdUlIq5pJYjS8ZZWazDqy3KwPhj/PeS/z9SwtdEHg89HObrdt49PKUMNTYG hhw6ehtOqBCJhT/J/reqmp+th5ms5Og27Zpku+FrIqrVNTP/Ay/M9FYJfcwGpEl6Qw HTya2AGEgwLcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/25/20 11:35 PM, Christoph Hellwig wrote: > On Fri, Sep 25, 2020 at 01:44:41PM -0700, Ralph Campbell wrote: >> error = ___wait_var_event(&page->_refcount, >> - atomic_read(&page->_refcount) == 1, >> + dax_layout_is_idle_page(page), >> TASK_INTERRUPTIBLE, 0, 0, >> ext4_wait_dax_page(ei)); > >> +++ b/fs/xfs/xfs_file.c >> @@ -750,7 +750,7 @@ xfs_break_dax_layouts( >> >> *retry = true; >> return ___wait_var_event(&page->_refcount, >> - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, >> + dax_layout_is_idle_page(page), TASK_INTERRUPTIBLE, >> 0, 0, xfs_wait_dax_page(inode)); >> } > > I still think a litte helper macro would be nice here: > > #define dax_wait_page(_inode, _page, _wait_cb) \ > ___wait_var_event(&(_page)->_refcount, \ > atomic_read(&(_page)->_refcount) == 1, \ > TASK_INTERRUPTIBLE, dax_layout_is_idle_page(_page), \ > TASK_INTERRUPTIBLE, 0, 0, _wait_cb(_inode)); OK, I'll add it in v3.