From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64ADBC433DB for ; Tue, 23 Mar 2021 13:57:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D15D461994 for ; Tue, 23 Mar 2021 13:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D15D461994 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 564116B015B; Tue, 23 Mar 2021 09:57:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513BB6B015F; Tue, 23 Mar 2021 09:57:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33EE06B0161; Tue, 23 Mar 2021 09:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 1A3196B015B for ; Tue, 23 Mar 2021 09:57:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C4BEA6C3C for ; Tue, 23 Mar 2021 13:57:02 +0000 (UTC) X-FDA: 77951290284.21.424BA63 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) by imf29.hostedemail.com (Postfix) with ESMTP id 29ED33D7 for ; Tue, 23 Mar 2021 13:57:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAViImzuXaSiOhce6STjGNn5BmVwL4FkCgssnsD5QUWWfI8R9CDefoMB9btiklt+EKwP3wdX+uYf2RXprzErGiE/kz4h9Adi3JBaoY398pDKcxkS/tYYPKfnVr6mwwqfc/Rs3sveIDuk89UpN5sEysDgT7u5Rkj28NpjmzUiWr3uZW+YGyuQFP6RFyrIhdOXVKY+y/1p+wW5GQPvCPQ7nYfOmLbsst4BkeuhbOEUByGxgIGPXEJvFjINgqiwHQlr8woqtGbGrA163QaZGMA79xfcIjW/sc5MxOsraCnzz2WGCr+MhoUkkhdFu/6/cImIhny1ANhMNUZIcEUVYXY1TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMSnv1uqeNE2y5y7uO4Xcc3Wnm3KNDhGRRZLKsl2fXE=; b=ItmGVJZ9vu7opXMO5B9ljINq/HggpX/pZCr8/cNzhXcXvPWGO1E/AYxFCmPDaOX3M4PamGLGt6dhMwQT54lIVEPPGxYA1/0ik5WgORb1YMxjSxsQoP3XXxe1sImJDgnNRfj3WXndold8z/tfUn1NjECHLAMWMO0aJnfZlh4O+KUPJfEz8hCzIS7U1tTS8msvmmWI+jTGzpN8NIHjeRwcIRC31i4DYDIsTBHw5LSsc+0j6iWyqWZ1SvhiEvYBsoTfK2CGNW4ZIPEuqTnYZBOJ49VCghdMov3QBNVbsbB8KAtkj+dp9oBOESxIRS8YWA6SSq22ULmf+Q1DkVh7NImCRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMSnv1uqeNE2y5y7uO4Xcc3Wnm3KNDhGRRZLKsl2fXE=; b=hfu3rs5UV3FdQHIz6qntYvWLu8pdKbXR+4SBIN0YR7vfIWFrbl2pnVGfNARgC0V623lUTOIEBqpk9xZAialsLIw1UT2Ycua+Yu0kSCx14BajQJWtDA1tjOCdPQ8V6JP9Ued7Nwom/RraInZefeIyhi4Wrhl4NwUxg0Hdf4ZRx2k= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB3887.namprd12.prod.outlook.com (2603:10b6:208:168::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 13:57:00 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2%2]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 13:57:00 +0000 Subject: Re: [PATCH] drm/ttm: stop warning on TT shrinker failure To: Michal Hocko Cc: Matthew Wilcox , dri-devel , Linux MM , amd-gfx list , Dave Chinner , Leo Liu References: <75ff80c5-a054-d13d-85c1-0040addb45d2@gmail.com> <20808d08-b66c-13c3-f672-ebce216b2fa2@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 23 Mar 2021 14:56:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec] X-ClientProxiedBy: AM0PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:208:14::25) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec] (2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec) by AM0PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:208:14::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 13:56:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c2cbaa76-1f7b-4221-7c04-08d8ee038755 X-MS-TrafficTypeDiagnostic: MN2PR12MB3887: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Db9D3KGhADkDj4n+0C6v/aub+zCZlhyLW0BqjJm3hNbQaoyhXy4UFeSYGsMrW20nEJtv7Ln6kWfVnl7ZXwHCJKqovdUgAKp5C7kZInO1k/weFI04mwFqdXwnzYn+li4dW9/b/X/IXSOyzDghKkOXWTipAaauw7AkPqAqJyh/CZlHPmhaSGYhcnSP825uewnP6Db34hwX0PK/lgvC+bh3oh3l8a6qxMrzLl3hAfa+AKUuGqGGunGZ0npJq9mYvNht1J38xdXW5HPCIijFr3qXoDYUHS+OE6r9ayitiL+U4svLc6aLeeD8OsxWZ1HFvIRv9RsIikFK/jyD0ywpPaELF81mDWOQhvkh+2eoT0Z0KC8hbK2ZfZyaq1Fo3s3esLd1SD0DsjGAlyQMYRdRBthJmJR34XWEHfn239mbszG6pqyVgo08J1yXLwThk1EJHkqy+vQiKSK0v47FHt1cmzUJ8Fb9QCruIIP71Xl73Dxs4hQiEdJMswmIvbBYDdhRwPlKNiT1uYZ5OXz4qyvwu63bQwc4X5bMMWmhcxLp4XOrqCWXFWieeS5+E8Ck35JNZm7pQR936pKNWCuNbp2ba7I7N6rc5uSWMVBEN9XoNaOmn9PYwIQytwzkqQORkFT3sJWVoMDj+lG5AxaNm++MCwM2vcTk5PPGG8qs0oS20qavuyUO+GsZUncydcVWqV7x6PE1845CvTB3qnH+wWU2V2DGnJvR8eXOZfIUce4lcLtR3p4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(52116002)(316002)(54906003)(6486002)(36756003)(83380400001)(38100700001)(66574015)(8676002)(4326008)(31686004)(478600001)(2616005)(186003)(66946007)(5660300002)(6666004)(16526019)(66476007)(86362001)(31696002)(66556008)(2906002)(6916009)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Mm05RExidEdjSFlxUkFFSzJmd21acGhQYmtxNFRmbHQyTmFjUTlyRTZSRWZQ?= =?utf-8?B?QlJlNTdEUkhlSVpSaDVrOEFHeUNZY1kyaWd0Nkl0Wjg5b2dOckVmQlF4cGR4?= =?utf-8?B?Z1VhaHdTeVBZbTQwT09XekQrVFlwMlhVUmZIRTh3MEpwR3FnU2o4WGpkSFk1?= =?utf-8?B?UlhSZ25JQzhMYjRkK3RQc1JRUTMyUjNqNFJYSjJIUkd4VlZ5ZUovelJuMTFq?= =?utf-8?B?Y0w3UHdqZjExemhWUXVSTkdlMEVXdHpIQk5YOENqdkVCSi9zTG5vWVdRNGkv?= =?utf-8?B?Yi9iOXgwZVlhQVZnRW0zelB3MDlaWlpzUlRLLy9pYXVjdjRRelV6MHVrdUNp?= =?utf-8?B?TlBwSFJRQTlCWnI5MDRRS1hySE03MVpPektsTHExa1YzQ2JJRTFOblFTWnIr?= =?utf-8?B?ZEJqb2ZPL2M5VDlmRGZTcDdFOGZ3NFN0eGdEYlExcWRUcTZ3WHA0Tm1mbjkv?= =?utf-8?B?U1ExUGtsRXRKY3hYbTI2NWptcnFzaGVzR3kwZDRlMk5CMy82VEFLWTZ6Z01n?= =?utf-8?B?NXdRaVk3TzcvSkNYYmt6TmtEOVplSHlvZFVRL05YaE15b2I2bkVuMlhoRTJq?= =?utf-8?B?RW53YVhVRkVpa1hTYXVoRThWUXI3dlBCNTRBUlpsNGk4SzcrRlFuUS8rVXlQ?= =?utf-8?B?Q0xjYjFVek9iNzRUeC9kTXgyWVR0V2pUalc2dWRmKytsdzUwczdjVGFCTFV0?= =?utf-8?B?cTY3N21PZTVMazZNM2VCTlM4aktuMFVpdnZWb3BLTGFIai9KL0p6eU0wV3N0?= =?utf-8?B?K2pJN0NsWFpCMWkxQ2svMmpzVGplRFBVbkNqeWpVSjZIWWF2UE5wM1hDY2N5?= =?utf-8?B?U2JJUjhGMWEvUTd5QzJRV0xFYU51QklVZHh0cCtKRFRUR0xGdlZYT2lhZHAr?= =?utf-8?B?dE1WbmNmQjE1QVJGdFlKSFEyM2w5MVNrdzJpM0Y4REdTbU5zaVQwT0hSNXQ0?= =?utf-8?B?U1M4dUJoTGJPUUVISXNwMG9mRkx4VFZVOWY4a2RuNWZBVk5qblVLYkJyNUZK?= =?utf-8?B?QnJyS1Q3dzBZcUFyL0RhalVqTVNjTnJhUlBudGtRQjBzeGhCQXRyNkJXdmFT?= =?utf-8?B?RzQ5S1ZIQ2lCUll3cWI1TC84RWNzVlM4bFRoMzFLUDM1cFJJdzNqMGxTS05p?= =?utf-8?B?YUdLWlRucEZNTC9PbGxLZzZyc2t2UERwSUdpdlpKNWpHK3hET2ZqTktBdmFU?= =?utf-8?B?Z2FJMnU5V0RFZEVYaG94NXZ6cXpvWVdvdjlWSmtqZEFKR1g1U09TSUhobGFx?= =?utf-8?B?bkw1TkdKcDFLbzFYQmh3VDlVZEFnSVREbjFiUUtpTEtBNlZzU2lubVE5RTEw?= =?utf-8?B?SnYxNzhWQU1HQ1czTDQ0akJyN2FUOGlNWWJqMmV2dnlsd2EyUi9kVnlQTERU?= =?utf-8?B?bkpiTjhRa2VYVzkyRHU1bUJSSmdtT29EM1dxZkNka0JRU0tFOStDZVhEa0VG?= =?utf-8?B?ekdpdnNPcy8yQllzU3Z5ZHlaTy9HY2t4TUxkcnpKTDIwaE5xUm1KZTJBUUxZ?= =?utf-8?B?N1lnRERrOGVBNUo2ZmpnSXdUSk9KWXBhTWdpWnVCNDNvWUl4akFJN0hraGhM?= =?utf-8?B?QXZFUXFqbVkzQUhBZHlVeDZ3V2xacWJ4aVRQN2NreTVLd0VQNEswNkVtM1A2?= =?utf-8?B?L0YxZ21aamk3aU4zTzNKYUg0UjJoZCtDUG1pQW5qRHM2a2RZTHhieVRnSUFQ?= =?utf-8?B?bW8wcXErTjREajN3eVBCdS8rem1VR0ZqTkgwTmlZY2hMa0ZPUHZpSnpvREVI?= =?utf-8?B?VTBoUFI0VW01QVpGdCtGZ1UvUitLN1BXaVdoTG1Mb1BBcVQrUmdTd3FVRnZ0?= =?utf-8?B?a2lVVjZSaVFsVHB4TkxGZmR5Q1lQRTkwZ2UvdGhxOFdJN1NleXFFQjBqRkUv?= =?utf-8?Q?/WQ+rwju0LbOP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2cbaa76-1f7b-4221-7c04-08d8ee038755 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 13:56:59.9292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uBayBLY6EZNI4LUIVPIO5veTVcMxwHnndrtQcXxV11ni/LDzD2ZoT646Ho63hJUW X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3887 X-Stat-Signature: fq4c57upkr336h1e5ossso7xt47zp41m X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 29ED33D7 Received-SPF: none (amd.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=NAM10-DM6-obe.outbound.protection.outlook.com; client-ip=40.107.93.84 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616507821-451971 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 23.03.21 um 14:41 schrieb Michal Hocko: > On Tue 23-03-21 14:06:25, Christian K=C3=B6nig wrote: >> Am 23.03.21 um 13:37 schrieb Michal Hocko: >>> On Tue 23-03-21 13:21:32, Christian K=C3=B6nig wrote: > [...] >>>> Ideally I would like to be able to trigger swapping out the shmem pa= ge I >>>> allocated immediately after doing the copy. >>> So let me try to rephrase to make sure I understand. You would like t= o >>> swap out the existing content from the shrinker and you use shmem as = a >>> way to achieve that. The swapout should happen at the time of copying >>> (shrinker context) or shortly afterwards? >>> >>> So effectively to call pageout() on the shmem page after the copy? >> Yes, exactly that. > OK, good. I see what you are trying to achieve now. I do not think we > would want to allow pageout from the shrinker's context but what you ca= n > do is to instantiate the shmem page into the tail of the inactive list > so the next reclaim attempt will swap it out (assuming swap is availabl= e > of course). Yes, that's at least my understanding of how we currently do it. Problem with that approach is that I first copy over the whole object=20 into shmem and then free it. So instead of temporary using a single page, I need whatever the buffer=20 object is in size as temporary storage for the shmem object and that can=20 be a couple of hundred MiB. > This is not really something that our existing infrastructure gives you > though, I am afraid. There is no way to tell a newly allocated shmem > page should be in fact cold and the first one to swap out. But there ar= e > people more familiar with shmem and its pecularities so I might be wron= g > here. > > Anyway, I am wondering whether the overall approach is sound. Why don't > you simply use shmem as your backing storage from the beginning and pin > those pages if they are used by the device? Yeah, that is exactly what the Intel guys are doing for their integrated=20 GPUs :) Problem is for TTM I need to be able to handle dGPUs and those have all=20 kinds of funny allocation restrictions. In other words I need to=20 guarantee that the allocated memory is coherent accessible to the GPU=20 without using SWIOTLB. The simple case is that the device can only do DMA32, but you also got=20 device which can only do 40bits or 48bits. On top of that you also got AGP, CMA and stuff like CPU cache behavior=20 changes (write back vs. write through, vs. uncached). Regards, Christian.