From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B42C43638 for ; Tue, 13 Jun 2023 13:29:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 545DA8E0005; Tue, 13 Jun 2023 09:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F5ED8E0003; Tue, 13 Jun 2023 09:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 397128E0005; Tue, 13 Jun 2023 09:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27F5E8E0003 for ; Tue, 13 Jun 2023 09:29:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E5E75160498 for ; Tue, 13 Jun 2023 13:29:00 +0000 (UTC) X-FDA: 80897805240.02.FD4A98F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id F0AEC40007 for ; Tue, 13 Jun 2023 13:28:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=NoYVt3nu; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686662938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=589OZQmCqlvd8gK+w2CMPjC/IbWE2hbu+aJJKMo5yZw=; b=OYQ+mii8+Df0fRcxvdlpErKYpnYR2xwIFDleDvAHXxuAybUDDnijJA7/WowXwBNwHDNw6j KOYMPabtS8PH7n455RD8iskWlkXKntuqt1HaJav5Kc8ZNxh7mYGcr+pEJTtXMgndpPbOVi ReKIUR4KwqV5pil93Ct7rO8v/4VMB6k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=NoYVt3nu; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686662938; a=rsa-sha256; cv=none; b=uGJnyTR4wHN5U6tiTHxrLewJqEHFGVUOX2A0183vKrc3UfuSCpMGyoyN/B3CDHy/areUIr HF7f98RZ1GRmnFwilknWC5LTAN2V0AimaMWJiu5gFfSGN+WIOvhraUMiJY2z4ekx1wEELd VsSFPM0fOH9HBav/XW4M/Uf+QqvgE7s= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35DDH2T5005121; Tue, 13 Jun 2023 13:28:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=589OZQmCqlvd8gK+w2CMPjC/IbWE2hbu+aJJKMo5yZw=; b=NoYVt3nuwpuUlCz/jdBaB7QOeD/NeUnPKmk+ui4aYlzkJJI7zYcrf7yx5gKAoRC5lBat dEGpxP+E0IeKPVgtXGAgkje0+W39ytDhBx0KJR58UBMPYQRkPsnZqVbGlk0TmBfP8/Gb GWcVQCYYMDHQ88pnUGctNM6mk2mKMtijyqMSMLuWqcsHi9xOUvg7p5Wtsqyw830OO8jY lDE3q1wn3oleD/OOo8bqiQPnK+MEBiCfMWmZ23YTZa9ACTRFt7gYlm8s3xwTIROVc5aT iGKdfcQyhPFh5C8N0L3GD7vZ5hy9yv3YHQDhNRYvXjPgFEXfIBObuJtXwnvzFGp8mIBT Tg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r6s6uraab-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 13:28:50 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35DDHTDA006702; Tue, 13 Jun 2023 13:28:49 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r6s6ura9k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 13:28:49 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35D9HtG7009704; Tue, 13 Jun 2023 13:28:47 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3r4gee25uc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 13:28:47 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35DDSj3521693006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jun 2023 13:28:45 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 139D320049; Tue, 13 Jun 2023 13:28:45 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 277A920040; Tue, 13 Jun 2023 13:28:43 +0000 (GMT) Received: from [9.43.61.208] (unknown [9.43.61.208]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 13 Jun 2023 13:28:42 +0000 (GMT) Message-ID: Date: Tue, 13 Jun 2023 18:58:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/3] mm/lru_gen: Don't build multi-gen LRU page table walk code on architecture not supported Content-Language: en-US To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Yu Zhao , "T . J . Alumbaugh" References: <20230613120047.149573-1-aneesh.kumar@linux.ibm.com> <20230613120047.149573-3-aneesh.kumar@linux.ibm.com> From: Aneesh Kumar K V In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jKERCO21mmKnngWzHZErP0qJvsDFfh8e X-Proofpoint-ORIG-GUID: sr_DOwvnYLrrIb-dGzB-SQPWZUALIubW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-13_04,2023-06-12_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=810 clxscore=1011 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306130115 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F0AEC40007 X-Stat-Signature: 5nidow1shgy6jeumk41ppke1a9xcwnhu X-Rspam-User: X-HE-Tag: 1686662937-608959 X-HE-Meta: U2FsdGVkX1/mR7RlYoBO+ZUmxNSmyM8EOmQL6HD4ID51MM8N16dZdXtfSrEOrJM0X0VdSOkRWlwhje8ulAdEsAWRthW0f19tblVif3TrRYClAnHKUU9wtOpt5BR3JQpQtt0VeFyU+8NKPBYYqo99X3L4fUY38eop2H23Z7Ex8/VaezZUvT24ita2CMOeoaacHFoO2Fhwn7gN+aN9mUr3qCoyehnUVGnAKk3YVWUQhuLk4o0U0r3hKNi3kgIUz/6iPjxFtto797hW9zOzBKat4FlI3Q2y4V9hvA6QDxdyEjDYdZl5eOHCpj9xCGjE0quKG7gfhE2qf6faklKQSnW0RERabJSPof25u8UL3wBkIwahZ4othY+nfnl/wnamJ1heUlu7cq9Rpo+VX5oxOGu8Q0qtKD60ekgInCTlxYAUccnbp9qrG0WFkCwGpWV6jdbtHNGTVOIP6JliO62tXUOGWbGx85B3YQ3eixEvlFS22xVKAkno+3zCS13a+fS9/UVWPf0iDxVa8G7mEy8Kxbg8QADab84q1dmjsrTGnqiFQyjD/sikM/IjQd/wsZzJ0sXh+TbN27Y4s5WCLEiynTbE9gEi51Zw2q6uH4egaODm3mSCgNMhCwJtKOxJ7cKVHgwfkQD2wQT3kfrhmgr0mIQTCps2X2jH2Njd2F0U02iHyPwdzmgvQczP907V1Zltkp15fAW/xWtPCmmZ92a8UD9Fl9CiDyMWvt6bO2ttgNBt5l2d+mEca8RuvFf17/2DBWOae8HvJ9TTalf1lHY6qsU21+/0S5/4qfUvY6foUf+4IzKcOUekMJKXuyQkhfFdChRYZOGsjCzI/5Fh4NA3iKqCe4tqlh3uhogBuPFUTKc6mBNCm4io8Dt3PgGJF6PFMt4zPWwXLzw765CP6GS2/3TAeZSh/3pM8gLgOlGfEQHds5dHuxyJcZVg3Fu2POMEWNLPmT9bTBkwvNwhxl9Nbe6 ZOT3KI2U tTw6HG1P8QimgjzXBlAopLWGiNEqaMOITY1/rBrbDQeoo7WFPPrmQhY3yvq21j/i8qKN+ZEpZnXsGQEGoCvZPZR2e7Y5KmEyIc54CfhjffdZAJGSwzBhivd5L7innEQy85L1zSSDv4mbnYocxiNKhUhFTQtnbvFR8yciFU9p9fPc/utOXVyKQkZ1klSegrvNRnC3T4X5Fm/Gxu+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/13/23 5:53 PM, Matthew Wilcox wrote: > On Tue, Jun 13, 2023 at 05:30:47PM +0530, Aneesh Kumar K.V wrote: >> @@ -4498,7 +4533,7 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq, >> goto done; >> } >> >> - walk = set_mm_walk(NULL, true); >> + walk = (struct lru_gen_mm_walk *)set_mm_walk(NULL, true); > > This isn't C++. > We have similar pattern for things like kmalloc()? I understand the desire to have functions return the correct type. But the amount of code that we are able to avoid with this patch for certain architecture is really large. -aneesh