From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFB7CD1284 for ; Tue, 2 Apr 2024 09:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 595BE6B0098; Tue, 2 Apr 2024 05:42:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 545CA6B0099; Tue, 2 Apr 2024 05:42:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E6156B009A; Tue, 2 Apr 2024 05:42:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EDCD6B0098 for ; Tue, 2 Apr 2024 05:42:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E2B45A0A1D for ; Tue, 2 Apr 2024 09:42:41 +0000 (UTC) X-FDA: 81964102122.30.912BA22 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id C5EDC40003 for ; Tue, 2 Apr 2024 09:42:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MElHyioq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+kollIJY; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712050960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oFxpD5FHaiIgLrXwnhr3zhIGLdQxW5tDOYkdBcIvPpY=; b=gMIVPSf1MqmDBNvFNSlRFmJHSeuY1BIwTYvu2n799ResJTPhmHhikKzwqi54KGGPBhBQEd NCDpQMXZEwQsrHGijwaA41uRp5zxbKh/DTsRaR0vZj/t91o8eJ7EWe95w6XIFeQ6IdUdK0 PY4fSVMiZPSPhEKIo832Sa2LPpp2a6g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MElHyioq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+kollIJY; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712050960; a=rsa-sha256; cv=none; b=er/FuQiL08I+qOLDqTyx4WpyFofij8JBqFIcI08vRONWuBEpy+xCBkY9TvZ2/gDuMHQTfy Wd35zqF4qAiRnIl2/gcxZM7RxJi9X1MIx0Y6RgKLFgDZdilGzUuYTziueDlg3unIUagem2 7TWKVRU5zOfmE7qAgXccWqmRTeyuAWw= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8847C20EF0; Tue, 2 Apr 2024 09:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712050958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFxpD5FHaiIgLrXwnhr3zhIGLdQxW5tDOYkdBcIvPpY=; b=MElHyioqS7r5U8jENFC5kYS3tXmkxKWSEUfwxn/ri7p5EWE7U9KBFmP37s6vw5K63vjvSO uLcrRMU4AFNPaZXLM+euTMAVUNy5tkTxAIYDc1YFGJ2DvywQDunVpWXwJPUKLGB9Ukby4E FfioU3GiA4ONn0R2Fp9Y/svlD7OSd/c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712050958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFxpD5FHaiIgLrXwnhr3zhIGLdQxW5tDOYkdBcIvPpY=; b=+kollIJYnZCXE41EIkGGoqZJNuYpWJN1l1YvHmJvsrgiqxRGeyTG0De4TLkg9tnT20Vxdg awBUGSKb2Gi/RAAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7122E13A90; Tue, 2 Apr 2024 09:42:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id X8ZDGw7TC2ZHAgAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 09:42:38 +0000 Message-ID: Date: Tue, 2 Apr 2024 11:42:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm/slub: don't read slab->cpu_partial_slabs directly Content-Language: en-US To: xiongwei.song@windriver.com, rientjes@google.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev References: <20240331021926.2732572-1-xiongwei.song@windriver.com> <20240331021926.2732572-5-xiongwei.song@windriver.com> From: Vlastimil Babka In-Reply-To: <20240331021926.2732572-5-xiongwei.song@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C5EDC40003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9hqkym4s3bi6xjy77ig37jfdqxxabded X-HE-Tag: 1712050959-607901 X-HE-Meta: U2FsdGVkX1/X9jSNFo7NrMK2W1lfXdUOx9cLQfU+MfD5m+lv3QH1ZFdudC+Z1/Aq4BGyse+pJIRkU76MY+ubMUPYUekmEabR7iEdvX4oh4qZ5BdndglbBP7RJ8IVr4xDOaRIEMzPCCRUb2sKAFfFw0tTzggwMUzVaajWrlOLxj6U6Lrnz6B4bWXuEKGgICtZfOxTymgM06QN6cSP7gn7v6VvJPwRfYAzx+AhQmXKHTikiMOtEsloB/NRQm+VN8LLGu7HsjIbYSB1qU65HBJgEb1/Trm2m5FE6zwHCbpvtjrn0bWlXBVua/EAGkZadOci9ip4TEwW45p32nH6NFYIR04j7IxoZpj+OSYAy7cyVEERjbzsxJwvbbVQQxIsFuB/EERA/HXZD36xlpoWk4vgb6PrGjZfBeNBKCNioOi3dV76FA9K2y/XZDtGc4OcQ50djR3OvkauMor47+0UTB/ZdtAYF0tWQdfAUsKxkHX1kZp6Y658ffz30sj4suf0NXbaUoZd8nusPB2QIiNEbeHqGmLahSs3fZ1lBejA5i8q6lO2/f8r5wkveDCsE9ax6T1W6SyR6upRRSNSR7D5FBhfn8OaVh1PTw23ONbssK/fh7SvAVVdZ+twxSi3BfCQ9ej3mjvijabIsWB5P/25dkPPoCApxI/9mT8yzn7jMGUfiMklk2PdXdqlFT3LYBUNRuS1RsaxwIcQHwDRhRPAQX716vsH+4eC7lGE0Cbj74RmRK+VP1DO8WHDLDZQ3o3z5/wF6G2R8m5kZE49FQz46+uTU1WIQMwlqeRUTRPNQXvtxuUVc0UP6A4oeGdY8LciYwXrTqvMAm0ysgwEArXQOHjbQjlX/J3WEPJm8z5CAOobClu2TYegWIZ+Iek40BWe7moesC6XLaYjaokMDdAt7BBkjLlwDvagxnqMMU4BSjxLmiWnUNCiwDtM2Rz0EIohdu6pgxbXaWJKYTmjFW+yKvJ YHH73iuV gj+nE3XDDc2loJ8/fJB/3WCyvKFipdMFVMnIuAaVn/29uW9BGE8riPWpBpXJdtFJ8Ya0+aLH/r75zzdChZ9s8gqRe2BXl2tWhK0qf9en04jNlfKbMXzczWg3L7iL3P8uQxnAMB7blgbUUJ+qKQjkE437aPckKZcHInhLUmyStzHHlc60cAjvHDnCmu6C9ha4qNwg36rn8UHFojfpUboTAF1RbKtYkNXsG6VEr7wno3/mT0ISyU0Z+Aou1Nf5q31OGJlH2Y2bj7JD9iOjN/oqC6Ay7SIe/gcZD9Be+4D0ih/xDBrSv6ewGuLj+FOJ+cI5zq2SfxPuej4NAaNw1qpL6JOW/vkRWwMsIWBKi173FBFZKa36j1giaIYuhGwLngLamPHgT91VRirdJBjSnC5kfpmbFy3SvylmAj2lmEcMvdi0tKgfgCmon/29Yvz+q+tbNzMjm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/31/24 4:19 AM, xiongwei.song@windriver.com wrote: > From: Xiongwei Song > > We can use slub_get_cpu_partial() to read cpu_partial_slabs. This code is under the #ifdef so it's not necessary to use the wrapper, only makes it harder to read imho. > Signed-off-by: Xiongwei Song > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index ec91c7435d4e..47ea06d6feae 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2966,7 +2966,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct slab *slab, int drain) > oldslab = this_cpu_read(s->cpu_slab->partial); > > if (oldslab) { > - if (drain && oldslab->slabs >= s->cpu_partial_slabs) { > + if (drain && oldslab->slabs >= slub_get_cpu_partial(s)) { > /* > * Partial array is full. Move the existing set to the > * per node partial list. Postpone the actual unfreezing