From: Vlastimil Babka <vbabka@suse.cz>
To: xiongwei.song@windriver.com, rientjes@google.com, cl@linux.com,
penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
chengming.zhou@linux.dev
Subject: Re: [PATCH 4/4] mm/slub: don't read slab->cpu_partial_slabs directly
Date: Tue, 2 Apr 2024 11:42:38 +0200 [thread overview]
Message-ID: <e531f01b-b459-4f98-81a6-86649322346f@suse.cz> (raw)
In-Reply-To: <20240331021926.2732572-5-xiongwei.song@windriver.com>
On 3/31/24 4:19 AM, xiongwei.song@windriver.com wrote:
> From: Xiongwei Song <xiongwei.song@windriver.com>
>
> We can use slub_get_cpu_partial() to read cpu_partial_slabs.
This code is under the #ifdef so it's not necessary to use the wrapper, only
makes it harder to read imho.
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index ec91c7435d4e..47ea06d6feae 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2966,7 +2966,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct slab *slab, int drain)
> oldslab = this_cpu_read(s->cpu_slab->partial);
>
> if (oldslab) {
> - if (drain && oldslab->slabs >= s->cpu_partial_slabs) {
> + if (drain && oldslab->slabs >= slub_get_cpu_partial(s)) {
> /*
> * Partial array is full. Move the existing set to the
> * per node partial list. Postpone the actual unfreezing
next prev parent reply other threads:[~2024-04-02 9:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 2:19 [PATCH 0/4] SLUB: improve filling cpu partial a bit in get_partial_node() xiongwei.song
2024-03-31 2:19 ` [PATCH 1/4] mm/slub: remove the check of !kmem_cache_has_cpu_partial() xiongwei.song
2024-04-02 9:45 ` Vlastimil Babka
2024-04-03 0:10 ` Song, Xiongwei
2024-03-31 2:19 ` [PATCH 2/4] mm/slub: add slub_get_cpu_partial() helper xiongwei.song
2024-03-31 2:19 ` [PATCH 3/4] mm/slub: simplify get_partial_node() xiongwei.song
2024-04-02 9:41 ` Vlastimil Babka
2024-04-03 0:37 ` Song, Xiongwei
2024-04-03 7:25 ` Vlastimil Babka
2024-04-03 11:15 ` Song, Xiongwei
2024-03-31 2:19 ` [PATCH 4/4] mm/slub: don't read slab->cpu_partial_slabs directly xiongwei.song
2024-04-02 9:42 ` Vlastimil Babka [this message]
2024-04-03 0:11 ` Song, Xiongwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e531f01b-b459-4f98-81a6-86649322346f@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=xiongwei.song@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox