From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B918BC0218A for ; Thu, 30 Jan 2025 14:18:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBC9C28029E; Thu, 30 Jan 2025 09:18:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D489428029C; Thu, 30 Jan 2025 09:18:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4BD028029E; Thu, 30 Jan 2025 09:18:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BCE528029C for ; Thu, 30 Jan 2025 09:18:40 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 30113C09EA for ; Thu, 30 Jan 2025 14:18:40 +0000 (UTC) X-FDA: 83064324000.24.05F3F5B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id A36B3C0016 for ; Thu, 30 Jan 2025 14:18:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pEGIV3Y9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H18lzWpD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Wqzm+5Bz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="kBTK/mRj"; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738246718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0PPUruzYayK3jG7bj1zhlnCX4nLUmZ0/0F2nZpKeOUQ=; b=tWuMg3f03fMBdNws6BfqfU3OF2BFAPqeZdIiYfypBpjPX5ORytNU0PEv1/2JgZkM9K9L7V XQqSgoSPq6Rjcdkp+rvE9utvgvuNEmksg9JZAexUBLBrccF8Cjlh9dm/kpQBak9ncANdCW HeC03FlLDY59JOz81yPRQSbbkP0xJjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738246718; a=rsa-sha256; cv=none; b=6NX+iY4cVSlQyh6nIWyIQX6Fb1jDcGvbSFeGiTnR0qQ6BoTraRSMGMWtlm5aO2OQ/qE4N0 Q7LRrwme9bIz98e/6SnmBJlURfTAdNMgFuHnIINBMLltp5MvTKcj8aNJObMy9h1LOXr9SA +b/zm5Z+sE8NVJantlMWdotzG6VZrZA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pEGIV3Y9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=H18lzWpD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Wqzm+5Bz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="kBTK/mRj"; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB6D11F383; Thu, 30 Jan 2025 14:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738246716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0PPUruzYayK3jG7bj1zhlnCX4nLUmZ0/0F2nZpKeOUQ=; b=pEGIV3Y9AM4gDWTgUvu2Vhd7VqqoL/udL5ThETBBrCdmnwVf+xxsL/xTmA89/Yfh4MTori kt1zqS77LcxBtOuBpxlavyo2DPD736RyCr7+T28LbeuTwscbB/aWcys+XZs6s/BDxl9EK3 9sIVUJU+DTvX9gSYr9bPsRr32rBqvs0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738246716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0PPUruzYayK3jG7bj1zhlnCX4nLUmZ0/0F2nZpKeOUQ=; b=H18lzWpDOQftGEU56MbA7QEgoqIXt9Z7WmOk/RaI0BYeDiWwxES5tE0+lwREmoqUx9qAYH 4Z7rrzsDBbcrc6Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738246715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0PPUruzYayK3jG7bj1zhlnCX4nLUmZ0/0F2nZpKeOUQ=; b=Wqzm+5BzllEXqkID4/C1D1res4hIENdZcOItTsKdMA0CLqCcPFONLkL5taL9tLa1F1Prbd 1JjLDREYznCUrQTgvKaOHqY1H7Qz7rb9K897zbgRdD5v7/Tne8uCK9gb+xmtRV1Sy4/qsL NXFu0zQg1OrDECHs2lxEO21qsextLOY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738246715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0PPUruzYayK3jG7bj1zhlnCX4nLUmZ0/0F2nZpKeOUQ=; b=kBTK/mRjSfr1PtudYKNQmh1VzloYdihoBbbA5YuiCJ2Wt7OnxvT0nJshuI8tXSxJ4DQQq1 rjaZ2Q1ld+jl10Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BC56D1366F; Thu, 30 Jan 2025 14:18:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XiWbLTuKm2f9cAAAD6G6ig (envelope-from ); Thu, 30 Jan 2025 14:18:35 +0000 Message-ID: Date: Thu, 30 Jan 2025 15:18:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm/compaction: make proactive compaction high watermark configurable via sysctl To: Andrew Morton , Michal Clapinski Cc: Pasha Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250127215020.4023545-1-mclapinski@google.com> <20250127215020.4023545-3-mclapinski@google.com> <20250127171857.34c71d3a6f0cde1953b02a58@linux-foundation.org> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250127171857.34c71d3a6f0cde1953b02a58@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A36B3C0016 X-Stat-Signature: a1fxif64747f3tmee4ezb65xoqoxci1i X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738246717-878961 X-HE-Meta: U2FsdGVkX1+ZlABpAJnYud4fAo26Yt68c3GefcyvwZ22AzuLKBhV09IkKhTWG0CxAgT51LeHdGMySKMAllxcRSXhrFxybLVkeiljllqs2mtLEub+T9+RnwKMmbY85/NkW/xcdekysGXQnbOa6ZBPzEQdENCY0DFSPLXqXLv6nTDWwQLPnGWIbR16Qz3H51hyIyQVpdPtllfcpLfN42m4PU30BWnD0AAsYKmhhDlnGGsrOSwkwuJrmCLLF5gLTVHRpH0lHWRkaTfsWf9/zW2G8WnSwz4f4X+VGF4aJ1L+KFsIyZsAMeDjbLgLF1wo4kaBui/xLZbuOEyuyV4OmUQusCxuI/Yurlpq/SentHw6KAPh39LHDY70oL3iOSSmj2yYhILf0Gsi+f7lkeA2YfEneflBsCiGRWLFpwYn5tX2XVEg7blDhDtMOrC9RaKtfvHwJUqJHydupeLTu1KoUDWc+azNVlb2I6VlfTIFxHo7VVGTd8509xnaf8voRvQ+ZdFBKLLx/6/jUkAg0qjqBeBE6KVCdekAZqGVfNGwFcCr/2Z6hxmr5NFaWECovkxBsisdSJkmkuwNC8cgK/EeP3YdyMqDUKJpMbJZLUp7aiUrSInlVLtoDr8ffTKXiGl4QE1BqF0fKBqZaYc0Ym1FDHfPe5I8tERbXoT8u51xPA4o7S571yCrVY7kQThQOg86QwuciGJ3h+BRDt5fPq7pJvZpfw/rguJSuTmTsUg2tGEjgI+L3T50LtgUqcIO43pAkIZIupzudz5af6ONHLSN8LhwLgyERceAi6c42ztPzDiHTlkxlUAO4VY6cpWM1VBF9wbUkZsFAb3Q+0b/EEYTg/kyuTzPv1XPtMGUtch5RcBhWaJpIQl1THfLr7+bGKAZ10otF8SyG+HO37+aKRZ/fWfoTZoSLjnPT5U2x7IDVQzkVJ9C+xJG6TZoUo9/w5e9ab7Xd5q5j3o7o9Xx4MUsz7A K2P40800 ZPIbNCA07VljZ6z2XvnnAJ5GDZO1y6QkJqG7NgUXjeQ3HXjL7ORJppr/qx9Tucsh7LiGsSu1xeMfC0riWhFd7DYr9/D/07ZZB8EVCoCIeXcyQ3ckRJ5Pu6WaaOM8SICLht1Otw6ugKidsnDL95kdc3FqadQYk06V0ZX72kqWv9pmmK+t/NLxQYvvhKI4vIhnWYcTrzbSL304Ps29Fir2z6Z6MCZ2ZE7aLZhSho+KDYray+GjG/TwDaW2/msRxA0xk5F7I+3x5zv7B/bs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000336, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/28/25 02:18, Andrew Morton wrote: > On Mon, 27 Jan 2025 22:50:20 +0100 Michal Clapinski wrote: > >> Currently, the difference between the high and low watermarks for >> proactive compaction is hardcoded to 10. This hardcoded difference is >> too large for free page reporting to work well. >> >> Add a new sysctl, `compaction_proactiveness_leeway`, to control the >> difference between the high and low watermarks. >> > > Oh dear, yet another tunable. Is there any way in which we can > acceptably improve the kernel without adding this? compaction_proactiveness between 0 and 90 works as usual, thus up to low watermark of 10 and high watermark of 20 compaction_proactiveness between 90 and 100 additionally reduces leeway, with value of 100 resulting of low = high = 0 or some similar scheme, as long as a value of 100 does low = high = 0 It's rather arbitrary but AFAIU does what Michal needs and higher proactiveness means more aggressive compaction. Question is, would anyone else find it useful to have low_watermark of 0 and high watermark of 10?