linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
	Michal Clapinski <mclapinski@google.com>
Cc: Pasha Tatashin <tatashin@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mm/compaction: make proactive compaction high watermark configurable via sysctl
Date: Thu, 30 Jan 2025 15:18:35 +0100	[thread overview]
Message-ID: <e524abae-918b-4b23-8648-bf56f78464de@suse.cz> (raw)
In-Reply-To: <20250127171857.34c71d3a6f0cde1953b02a58@linux-foundation.org>

On 1/28/25 02:18, Andrew Morton wrote:
> On Mon, 27 Jan 2025 22:50:20 +0100 Michal Clapinski <mclapinski@google.com> wrote:
> 
>> Currently, the difference between the high and low watermarks for
>> proactive compaction is hardcoded to 10. This hardcoded difference is
>> too large for free page reporting to work well.
>> 
>> Add a new sysctl, `compaction_proactiveness_leeway`, to control the
>> difference between the high and low watermarks.
>> 
> 
> Oh dear, yet another tunable.  Is there any way in which we can
> acceptably improve the kernel without adding this?

compaction_proactiveness between 0 and 90 works as usual,
thus up to low watermark of 10 and high watermark of 20

compaction_proactiveness between 90 and 100 additionally reduces leeway,
with value of 100 resulting of low = high = 0

or some similar scheme, as long as a value of 100 does low = high = 0

It's rather arbitrary but AFAIU does what Michal needs and higher
proactiveness means more aggressive compaction.

Question is, would anyone else find it useful to have low_watermark of 0 and
high watermark of 10?




  reply	other threads:[~2025-01-30 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 21:50 [PATCH v3 0/2] mm/compaction: allow more aggressive proactive compaction Michal Clapinski
2025-01-27 21:50 ` [PATCH v3 1/2] mm/compaction: remove low watermark cap for " Michal Clapinski
2025-01-28  1:17   ` Andrew Morton
2025-01-27 21:50 ` [PATCH v3 2/2] mm/compaction: make proactive compaction high watermark configurable via sysctl Michal Clapinski
2025-01-28  1:18   ` Andrew Morton
2025-01-30 14:18     ` Vlastimil Babka [this message]
2025-01-30 18:15       ` Michał Cłapiński
2025-01-28  1:07 ` [PATCH v3 0/2] mm/compaction: allow more aggressive proactive compaction Andrew Morton
2025-03-17  1:02 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e524abae-918b-4b23-8648-bf56f78464de@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mclapinski@google.com \
    --cc=tatashin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox