From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5929EC54E58 for ; Mon, 25 Mar 2024 08:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C15436B009A; Mon, 25 Mar 2024 04:51:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC59B6B009B; Mon, 25 Mar 2024 04:51:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8EB56B009C; Mon, 25 Mar 2024 04:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 992CD6B009A for ; Mon, 25 Mar 2024 04:51:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4576640AA3 for ; Mon, 25 Mar 2024 08:51:09 +0000 (UTC) X-FDA: 81934941858.24.D767FAC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id EE9E2C0002 for ; Mon, 25 Mar 2024 08:51:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XfwZd6ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AyQURhGX; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XfwZd6ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AyQURhGX; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711356667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=65tAr47dWAJ3vDg3RDQQXn3Wlhxz3JMVH3FznVwyuS0=; b=c13r8I6cdG5qis6HUBu7Ymf+x78IsGxbD6RWIs0hUELpQHHvyKuKtFMS5T2lQJHzf46OGX axcPcfA3/IXPbFDFKNKXxVA8xscVp37lUMvCDyXqmWEFcSYmn2f2iG+TFk35hbqI6xxW3A eS/yAoVay8tbGsY5qEBEnc8Yo1nepB8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XfwZd6ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AyQURhGX; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XfwZd6ES; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AyQURhGX; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711356667; a=rsa-sha256; cv=none; b=cvPcmVWToCFY/XA4fwBwH/Qg92QcgNEExGPp74tc3FYkEbc0E09u8rxygcgivy8hiYUhTQ nxT3p6Sw+8UNAk5C0+WXJ0FetgdgYujqiqndlDK8nrd7Vhv2duwc0IYCLGNP5NDthWJ/M6 PN7nq7ZQgjSp8cr0IRqvHtbAJubeeHs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1EDF05C448; Mon, 25 Mar 2024 08:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711356665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65tAr47dWAJ3vDg3RDQQXn3Wlhxz3JMVH3FznVwyuS0=; b=XfwZd6ESRlzz8rn2k7LpZFxVOZYoymS2+Sw0/ywCCj2CLpcpj9Ja8dBAE5pwVnsaf6FNkO /QZskaDbxzGbZyUlGenuK/XlXb06Vmki5v8dSd7A4RI7T6qZIG6pVxI+igVyCpgoMWomcG TkQpLlFLYT+rIbCflsSMukhpJEJ+EaU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711356665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65tAr47dWAJ3vDg3RDQQXn3Wlhxz3JMVH3FznVwyuS0=; b=AyQURhGXMQnXHcFKu3ysJ9uI11JaQ2d3DnqWF2PG7GDn0GaSGmAtCjFMeJOqTkIryW3S+m rrdyp7Ni/BWq3yAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711356665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65tAr47dWAJ3vDg3RDQQXn3Wlhxz3JMVH3FznVwyuS0=; b=XfwZd6ESRlzz8rn2k7LpZFxVOZYoymS2+Sw0/ywCCj2CLpcpj9Ja8dBAE5pwVnsaf6FNkO /QZskaDbxzGbZyUlGenuK/XlXb06Vmki5v8dSd7A4RI7T6qZIG6pVxI+igVyCpgoMWomcG TkQpLlFLYT+rIbCflsSMukhpJEJ+EaU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711356665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65tAr47dWAJ3vDg3RDQQXn3Wlhxz3JMVH3FznVwyuS0=; b=AyQURhGXMQnXHcFKu3ysJ9uI11JaQ2d3DnqWF2PG7GDn0GaSGmAtCjFMeJOqTkIryW3S+m rrdyp7Ni/BWq3yAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 052E513503; Mon, 25 Mar 2024 08:51:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g//rAPk6AWb3JQAAD6G6ig (envelope-from ); Mon, 25 Mar 2024 08:51:05 +0000 Message-ID: Date: Mon, 25 Mar 2024 09:51:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/slub: mark racy accesses on slab->slabs Content-Language: en-US To: Chengming Zhou , linke li Cc: xujianhao01@gmail.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8b146695-4ff5-4f9a-ab64-6cbed4168f98@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EE9E2C0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1t8kajxszkx3dnm1u519zqyj3ffgf697 X-HE-Tag: 1711356666-989127 X-HE-Meta: U2FsdGVkX1+SmLxZ74qF8yAhiudf1pJnHZkVjfiEFcf8AwD/tsiyzGVFELmNEAkni/o5ZzYM4X0R2/AD44PWqVsQmTzHY0aPhod8t0NSyrZaEVLVKh9RUN+4X1Ba+2C/SMrAlzRO7X9ELbjgNR8uU43mXCGGXYWgkLJktXGTjnHCLCdfTjmahflxFFC8EUbN8D2HSqf6Xrr7wyjpibsYf3kd0rAxu5IjJ7SP9euD2VztUftcDU7QP/NJctb4mlTbFZZ4Dw1/hjHJ8lXZ2OC3nvLgYHtFI7kN8W8Aq8NkyfzVB1AxEEs20LUCQXz6IOqGbTIAEm5KOD/IVw3zBH3HQqoGSuO0PQxHQ5tbK+ll7H98dt0Sd2l5dvg1wx7660GZe7VeV03inHnNVPnUXx+OeNSTeU85i5kQ/WvjyiTkILDUBwI+3qzjCSkhn/tMRB8S5h/wr/VhhfHIELyF1Q/KUatHyANzsQ7lINTN02RlpDtVP0jt4tEWU/zZ5XYANzfimRen2wZO6q0s4hIxvr05h+C3Bjft1EqTQCND717YRnuGNJh3Xcr/gSJkd7w751FS5n/dqSIkMayEXQ04rCc+PpxguqX9LdbxwMEANQxBCGhioNlZ1Z/83r6wPij+p7c2rl3xP8U0VuhbunYwsqKQtUN8mDqlG98Pn4OMd53LBx/UBU7PQ8+sy6iYzliBWwcuVWU+z0P8Ys12QPqI8Daaln+FfWplKOSA9VcdImsHbtoGXiiwt8EJwIInkYQ2jtIro3RijSzRsZQ64mgPO6NmFLVGoeqVFMtcyCrFOYt337JWjrMmuCDdLAm2eIh9Fbf5aWTQJE04VGH5di+/4XK7iUcaAX3evr4I/WrMBIJcq1lIOzo+asnivx2gzwdHBWtQv20dCgnnrwC2bJUA2u3ZORcrkdQjN9R979gbDZrC9+9O4VoVhOo8svW49LTwHs5LmJBfhIIY/3Fe5GWBBi/ dDyXGN51 3e8p2zQypm2ju5KqiNX80pYxFwEvMLBlXSexokD31fY94lbvMMXVvJRSZJeLQ1Lg7FhT6zcBi4QJgxAkxm/Wg6v53st1lJ4o650LtKy87p8AQH5jFC1WBwP3+mHt2nsaq8UrDIcNt+JHn0Sef07aw5Zv/f/wmbB1yhq//S8AR3MVScssVsy8ig0WvU0Re6+WboB/Gu1JAB07CrqJS4mSslvtqyISLwifm+Eu38gKH87eVifCh0xDizVZZ6VS+yNzxrHHjtlCPtVeetjOyzbGlAUnyOha+SUuX8TJj7IuRWVuGpFO4FKZkUf7mXm7QCqMtxXMJEEQo35y9Z9OmXDhAE9mMTaUUxDfxS24NaWFxBapK5Sc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/25/24 9:49 AM, Chengming Zhou wrote: > On 2024/3/25 16:48, Vlastimil Babka wrote: >> On 3/21/24 4:48 AM, linke li wrote: >>> The reads of slab->slabs are racy because it may be changed by >>> put_cpu_partial concurrently. In slabs_cpu_partial_show() and >>> show_slab_objects(), slab->slabs is only used for showing information. >>> >>> Data-racy reads from shared variables that are used only for diagnostic >>> purposes should typically use data_race(), since it is normally not a >>> problem if the values are off by a little. >>> >>> This patch is aimed at reducing the number of benign races reported by >>> KCSAN in order to focus future debugging effort on harmful races. >>> >>> Signed-off-by: linke li >>> Reviewed-by: Chengming Zhou >> >> Chengming provided feedback to v1 but not offered a Reviewed-by: AFAICS? Or >> maybe will offer it now? :) > > Ah, right. > > Reviewed-by: Chengming Zhou Thanks, added to slab/for-6.10/cleanup