From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17272C77B7C for ; Wed, 31 May 2023 07:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6FD5900003; Wed, 31 May 2023 03:55:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8D8900002; Wed, 31 May 2023 03:55:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89AF8900003; Wed, 31 May 2023 03:55:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7446F900002 for ; Wed, 31 May 2023 03:55:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4C29640272 for ; Wed, 31 May 2023 07:55:15 +0000 (UTC) X-FDA: 80849789790.18.8C6B2EB Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by imf30.hostedemail.com (Postfix) with ESMTP id A047A8001E for ; Wed, 31 May 2023 07:55:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of pmenzel@molgen.mpg.de designates 141.14.17.11 as permitted sender) smtp.mailfrom=pmenzel@molgen.mpg.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685519713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4NnYIhlQEC/cwyGfZzaMshsuDRFDikIYXaTR1U/YDw=; b=hGrwsxADGsifm1ukr7M311deWsrrriYzDLFp7ZYleTPlXv7A350plaoU2bAW7jc76EaRt5 oFuh2abM/XmnFwYPGarPvmqNrYaSyN4LMG/1ZsfFG9L7TtUWFItuBBA4Lsd6V1txj2bWzI NGZvbdJ1QAjCm19/5c1Lit8Ar0ADwWM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of pmenzel@molgen.mpg.de designates 141.14.17.11 as permitted sender) smtp.mailfrom=pmenzel@molgen.mpg.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685519713; a=rsa-sha256; cv=none; b=5skBGEhxUMuFurQf1WUvqwxGWpbuIVk7LWySVMrI/7JpLHNPfO9PYK1EZGXMy0zsRht33i kIo9FXE6uh0UdQH8vYF0ShHnY49Ot2qLjcb+DHe4QcM0dmECIks7L6KQuJK9sT1umOUn++ I+OjZtNBMqC/hMx8tESVkS4Lv1s2cFc= Received: from [192.168.0.2] (ip5f5ae86a.dynamic.kabel-deutschland.de [95.90.232.106]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id B64BB61E4052B; Wed, 31 May 2023 09:54:23 +0200 (CEST) Message-ID: Date: Wed, 31 May 2023 09:54:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails To: Johannes Thumshirn , Song Liu , Christoph Hellwig Cc: Jens Axboe , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal References: <20230531042502.GM32705@lst.de> Content-Language: en-US From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A047A8001E X-Rspam-User: X-Stat-Signature: z3mfpqtmjjhekuaqomhotxfprp7oc9ep X-Rspamd-Server: rspam01 X-HE-Tag: 1685519712-61010 X-HE-Meta: U2FsdGVkX1+pvZRd/TEiuyJrUJY2+Rk2g/hXH3RPozRwlJccTwd9RepsoxbvJQwbg1/xd2eDdxjkn/50bg0bJIoDw+OQeLIRwHBv1rZ6ZG2APkj3cmbz1kdJgoklag31ccXkZmdHohDf8eHDkGyJ6wMCfJBaTUpuSV+z3iLapc7uzl9kjz2uXWXJIU91AAa7MvAAD8w1vY4JBVml09iJ3kg9/xyi0aMYEw0JZZ1aZ8pHHSwva57gBdgkfV++Whi3W97Sis71K4LzVHWREeHCcx2JnJY/LnN8vKgNUXRewfX07HVtA18mxgIhbwi7SgNgMz89Hut29FBH6Y68VF8KlYbNKzYhSfEXDf+pxzdYEyFfjX8G6zYSZJpkWPikQ4ul/KDfdx+rmLmVhDOeliBZ5M8nk/RP62NYbZRSvPVT+CJZKZNxwMQ3HbUzrG7OyJLXSy3bvtq20QWKx31x32fu5e31m41yFMCxM53xHE1CQczsdCDmZohwtyPxX+cPuygZ1SlomatZkbTzVZJRf9VIT3PGmU3vi8ha/OLaToTkkqZM3farSZKwIO4sj8umysyQDxWDJFhQAlX5d2nsQnITL25g3eJbCWqkyuNVaERqQ4HVjSWPW8qmrz12R+EiFjdurlb+3Ode8WCQFKMMkRuNQ5znjPUzksKl3V5VWaZMCQNzTra6U0MrapRmTLqa7vK1F/qSBE8wnVfYCb95YW6BPqkxhofGvgo1OZMCS1SaQw++tcR+XRXipoRE+07JtxGPvqWS/msvf5WCzto5iRJjCi5N3MJeeuEnznBBsmQik7KMVRM4NzC7hNBZiZnbIKp3Oa2V00KDpfv4kOU5POcVyUVAdoHYMo24QZRooVycPJqfw01JcDCnILtmox1IR/jvTGlIhhzonpP9htL4iDh2dbtvF8Cur5ZVaz35tT1cFOtnKbfAKTF5dXgJhoYkk4Tujb9xmKZw6KMpVFDtiCg ITaN8Fan voJTORHQ6XougqA/vyb+ZPp8uKrj1sb9H1FivXVxcGv8XFoejdKNB8XIJEen2iXpAQpLRwSWAVvPMxnezTfRQwKuvQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Dear Johannes, Thank you for your patches. Am 31.05.23 um 06:58 schrieb Song Liu: > On Tue, May 30, 2023 at 9:25 PM Christoph Hellwig wrote: >> >> To me these look like __bio_add_page candidates, but I guess Song >> preferred it this way? It'll add a bit pointless boilerplate code, >> but I'm ok with that. > > We had some discussion on this in v2, and decided to keep these > assert-like WARN_ON(). it’d be great if you added a summary/note of the discussion to the commit message. Kind regards, Paul