From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F21C433ED for ; Thu, 6 May 2021 15:35:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A4AF610C8 for ; Thu, 6 May 2021 15:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A4AF610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B19C96B006C; Thu, 6 May 2021 11:35:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC95C6B0071; Thu, 6 May 2021 11:35:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 909586B0072; Thu, 6 May 2021 11:35:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 73DE96B006C for ; Thu, 6 May 2021 11:35:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2E5DFA759 for ; Thu, 6 May 2021 15:35:14 +0000 (UTC) X-FDA: 78111204948.27.5BBD262 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf06.hostedemail.com (Postfix) with ESMTP id 60CA6C000C7A for ; Thu, 6 May 2021 15:35:14 +0000 (UTC) IronPort-SDR: oAQT4yzpcYqThilc3GYIDt0QlQKUmlNDN1bRFBjgC/Pl4x7FslNDqPRqCrqDoz+1x3HJdyTkJY TrmIv0LSHvag== X-IronPort-AV: E=McAfee;i="6200,9189,9976"; a="185630637" X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="185630637" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2021 08:34:50 -0700 IronPort-SDR: NX6RzwNeSAMDp6StW305M+Sd+j+jLrk4wgWenh2fgUMxfDOGbwPNO5RINx2WwaPChKh//xB+t1 zl9eBy51KnYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="407051744" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 06 May 2021 08:34:49 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 08:34:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 08:34:49 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2106.013; Thu, 6 May 2021 08:34:49 -0700 From: "Luck, Tony" To: Aili Yao , Naoya Horiguchi CC: "linux-mm@kvack.org" , Andrew Morton , Oscar Salvador , "David Hildenbrand" , Borislav Petkov , "Andy Lutomirski" , Naoya Horiguchi , Jue Wang , "linux-kernel@vger.kernel.org" , "yaoaili126@gmail.com" Subject: RE: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races Thread-Topic: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races Thread-Index: AQHXOy7Hy/b3oTVTZEO3lND/F7hluKrWtfmA///ss2A= Date: Thu, 6 May 2021 15:34:48 +0000 Message-ID: References: <20210427062953.2080293-1-nao.horiguchi@gmail.com> <20210427062953.2080293-2-nao.horiguchi@gmail.com> <20210506173757.586580bd@alex-virtual-machine> In-Reply-To: <20210506173757.586580bd@alex-virtual-machine> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Authentication-Results: imf06.hostedemail.com; dkim=none; spf=none (imf06.hostedemail.com: domain of tony.luck@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=tony.luck@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-Rspamd-Server: rspam03 X-Stat-Signature: ua6ncc3wm7e7oke1kem5nqeazy75t4rt X-Rspamd-Queue-Id: 60CA6C000C7A Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mga02.intel.com; client-ip=134.134.136.20 X-HE-DKIM-Result: none/none X-HE-Tag: 1620315314-50695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Sorry to interrupt, I just thought one thing: > > This mutex seems not been bind to the error page, will there be some core= case > like test code or multi-poison case whick will break this mutex? The mutex is a bigger hammer than strictly needed . If there are simultaneo= us errors on different pages they could, int theory, proceed in parallel. But = this mutex will serialize the processing. Is this a problem? Hopefully systems aren't seeing so many uncorrectable/re= coverable errors that this would be a significant bottleneck. -Tony =20