From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F90C38142 for ; Wed, 25 Jan 2023 02:13:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC0F26B0072; Tue, 24 Jan 2023 21:13:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A71436B0073; Tue, 24 Jan 2023 21:13:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 911786B0075; Tue, 24 Jan 2023 21:13:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D8E66B0072 for ; Tue, 24 Jan 2023 21:13:55 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4D7191A0969 for ; Wed, 25 Jan 2023 02:13:55 +0000 (UTC) X-FDA: 80391700830.06.EC07CBE Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2064.outbound.protection.outlook.com [40.107.95.64]) by imf12.hostedemail.com (Postfix) with ESMTP id 23F334000B for ; Wed, 25 Jan 2023 02:13:51 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=O9FavUql; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.95.64 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674612832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vF2pu+am35RbVOYMQfYKOftYrvSOF//cIxDLK/Aq6U=; b=pSdCQd5aFqkKjWwvEk7z9/nohPwiTdjl9OcslHRTg8jiV/cW7VomA1hKozGgTGBor0Ohg0 cOi/czFn46UORP/He0OiW8mBXXeWWl201xRI8AW6lyWOJO4HIrHHlKx2lB/fEFR7RbJMEH ESpO4z9SybKLSPIHb+dy9wZJetCnyjo= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=O9FavUql; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf12.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.95.64 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674612832; a=rsa-sha256; cv=pass; b=5JJjrmewf/8tYO15vox9Ne8ei5lHcangNgf7nFwTkv6tvXdDQC88Fz/Q3CQX4S2nHzsps5 +LRWB1CvBggiAAv7E1VMpogDJ9CsJVSceQHTqctHQjdyO3cU5bYeEneWn8y4xPayHn8y8M jc6d/iFuH+EQn3n+cn70NI+yHBvFgu8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsOfW/v2L3PAnU5qrYg0t24rhIHEx8VDs961pB6tqb5qw2WDjeA176u74/saFQgkylaGbczwARDdz94ZcXB9rdVzvnK9jNeO8pR5XWXRpbwrH4pQj/jZ1EZn/TrEpCUW8fXzbtLLzoPsblnMdp3etzA0cWVHsgqBdgvgAL8N1An2GkK9hTTOrfHiZq2xbBezE5JUj7iZR1hIvlI5I0/EU0BM7J6PWml0foDXR0uqJaoI6nszz7IuT8NuGU0DhIjz8ObcZNMhrIFU4lrVRLT0KjaU9S5E5uCHTbbAILQTBQ8EbTnyZBSKWK22mUkAj2RbHDhic5UVzgBOdlA1bv2Tfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2vF2pu+am35RbVOYMQfYKOftYrvSOF//cIxDLK/Aq6U=; b=NO7gQ1l/V/1q7pioDPEnsXtO/uQqmA1J1yTcvX1yTZVXsAD45RPYe/7Aets2m7pO2z+7E+6ACct96ZInB/BQsKVdTcxX20akETMa671JJOhpkKQc0vFG4JHDzlw1xQtCVugDpXxN0i/m6n9h6mz/WBsCAHKkG5mUxjK2PN95Ysb/NLZ3wz/o+0zZNQTuPy1mxkcduUX3jqXfcYGjCXpDFjD5rd4+5ZvJsgWkd3IQzkvIANE8qBPCDrStYC6FYwe3WTlM64WBY6kvHYdsEq3foPRI4YBz5ASwNBQlXsAIdvK+1Q/pqa+n5KOQs3baLrYCu9E23/NqCFyhwGpTYwzK7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2vF2pu+am35RbVOYMQfYKOftYrvSOF//cIxDLK/Aq6U=; b=O9FavUqlfcpkJNLNzqeLtru8WEzAcEkE97z4C3KV5wF2YpS5gGA+Mid38RAAShk61GTbkrLKkKUM9fDMsNwxy23qgjygPJlxKgddq3enU0amhTpecawmTzRXLHt7WWWl8CH9zFwXapZIIVMCkkAT8cbx5gI33EhLzLRqWJGdjhrF/+fvUUenFZtwdcsQKFQKv9tTrPMcidWr9vduTYCKRw5Sez5YmbX47RH2ods8NAG6I/kFSnW9oPGKICZh5RPVQA7WRquSYLo0pgcjBwWa9mRBtKoucg7Q8itx7klPO3lVnfrMpqRbfHmibK7TVaOUhqVjJ3+jz8O7RzOYbSlm2A== Received: from DS7PR05CA0041.namprd05.prod.outlook.com (2603:10b6:8:2f::8) by PH0PR12MB7485.namprd12.prod.outlook.com (2603:10b6:510:1e9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 02:13:50 +0000 Received: from DM6NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::bb) by DS7PR05CA0041.outlook.office365.com (2603:10b6:8:2f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.16 via Frontend Transport; Wed, 25 Jan 2023 02:13:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT114.mail.protection.outlook.com (10.13.172.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17 via Frontend Transport; Wed, 25 Jan 2023 02:13:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:13:45 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:13:45 -0800 Message-ID: Date: Tue, 24 Jan 2023 18:13:44 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 02/13] mm/gup: remove obsolete FOLL_LONGTERM comment Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <2-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <2-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT114:EE_|PH0PR12MB7485:EE_ X-MS-Office365-Filtering-Correlation-Id: b57ef4a5-2ccf-4dde-2da0-08dafe79cc61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yaRBL+uSbRL6LEJsSgFJto233A0lk8dVVe7LZOhbHeg1qg4/tlPgemBN/xQDfAWbZLA0dLuw5LtUBMCwDBfl0g3On2fmufGNG7npms9UZasOnpmZjasM3B7khcQxx2JY1g3DgxqyyAW8VxjtCFVwuuLBfbOgoW54DddMbG59DGryMhFx6j6RRLyYZS5qoXtjRQ2/xBOSQ49bOR/fHZ5GkOFJr8LY10KvyKi2qhC7vvu5iTYsGQ1KafTVZ4Ddq4qrdtqRdJYGqzC4NapQZ0+NbnLMd0/957/ldaVsuN2p4A9kEH0j8TpvgaXN4bKRCcfWkFDEEKNkSxDdUXnoDsAulzpn0susT9XvKSbOL5vKdyHPmX+ro0XNDm36+ce/l8awhTi6aX+20Gq5OOmYTxcVxTkqWiHe2v9tPM49lBaE2q40e6uXXspeVY03pkUT+ejyG7rkMQOuJKwsc00qdoAkVxqyBkB7IlPkUsIekG7wOr9j8XT9RrefO7N5tJWMNT5QXR5V8ZMRJvFy+rd4KBoceq0KAywO9/hep7TvMNelfxxT4bSwfV6qVKPY8NyIbZu1x3BZ3S6Ter2TBDAUqYTUMyFXesulEIwjSEAllozv+wmVNVvepty5N6FOBxaVY8cpzDjOuLfrGEjkGH0kjDnlVxePWknd2U4M84kA6vblFfQKmAinbD8MZ8GvPLemIA1k3XAwylQwTACQKwiuiHIFphFiQSTNOuHrvy80ERpcX58= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(40470700004)(36840700001)(46966006)(4326008)(36756003)(2906002)(53546011)(82740400003)(316002)(31686004)(5660300002)(478600001)(41300700001)(186003)(26005)(47076005)(31696002)(426003)(83380400001)(2616005)(336012)(16526019)(86362001)(6862004)(8936002)(40480700001)(82310400005)(70586007)(54906003)(40460700003)(70206006)(36860700001)(7636003)(356005)(16576012)(6636002)(37006003)(8676002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 02:13:49.8202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b57ef4a5-2ccf-4dde-2da0-08dafe79cc61 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7485 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 23F334000B X-Stat-Signature: z4865bh5yrwuh3gfyj57r3yzfcmg166h X-HE-Tag: 1674612831-765886 X-HE-Meta: U2FsdGVkX1/X7gjjmxcZz/6IfKWCDnzysROgqBVY8f4qjlGQsZ8R3XPT5MNZDS6yfmn9pZn7QiSLbteVPdCjX681O8JcUPDOwOEHU2Y2A7TydR8N8L9IVD74Bzp+z/2f37zCzALDn7Q+WgmYbCJnUi1uBlnxwD4IgggSbXZaNAE3ke5j/bprNU6fDQgEmS30cpFFz30mVMRcUbjKK/kw23XbvD1gm02HRIwsSpu573OJ7A5ETHwh+H1Hf9aHLHJ9g+Ha/ASFwLmjgsjDuTeInCH6ufdNJhO77L5YnHBsK9taRtA94hOxHLXCLbRfhPTTQie9FWME9ELiow231lzO7eieQutPNB81vLP0zMXWXCfF1Lg4qGnMfoFiezT+dF66gwoTDvJEPxlsPfkNszl7or7Wt6Vs3ojREwnlKu3j1ZCW5+P9cLuYeTaTNEgCYAdpTqEKCglNYwzniV44qKPBmc4IOVz1kuc8K5iisgqD3Q403mSp1w1IQWSdwKM/4zHuFajCoq4WcIwzrigbtOhXE0L6eYgzMnOsbloLIl+I944lTRPVhogArEN7vBATxBfDhNDdH6vhm0UQuUBgU68bhsHWD43wSy8TOIqnIGpsBX7eyiUppFbnM3082pkSwiz2SO9zPTtCxAxg9tlQ1jQSYd2SjSudJ+IUKQLsAw8XFkk6an+2mRQYrnp9B4aDCZwMoJeNooT9zv4aK9xjNh/Wb5Zq5R7K2hvVCYxIiP44QDm8DfOKdVOYqCcbzmHiX+tJGqGV3G1ydIzWjIzCeCMnaHqL5Ft0ARKxcM6w08C419kGFv/kXb4gHa/TqF1sHt9fVQGzjC6/BNxdQOGzd17ML1U585CamedXy+dEJU6i2v2ZjO9/eHSDDKmO2FMrOV4ilYf3yKysAbAaaXnR9MJnUFAWkGSoeFyGJ47/O+eBAl6jhbMAt84bQgAJk2tBUlrTe1fBTf9bZBzAtMb8q2K RHC1L0K8 8M5uhsXQ+beZhP717m3IBJhswE/tEyUsRGB46MGj4QX2towz3BY8iPbOsAf7UmvrI7SefwTHpJTY9RzAISvgyleIxP9eTRafb7Sb3ZZuksD7Z8LE4DkRjagQEKQ42pP14eD3jMeXzCx9uieNDdsu+ZEmB3toENCEi/mMZETXXqw31RtdjCIGuK1Oh6hf1whsqmOnVFhvceMJNOqsrahaEyikVaPUOS8if1SXe6t8Y5CM2uO1nQp01sRrBvWTR2g6mTvcXay0scU0hpAZLoKfppS6FPQRFaiaKbcl+EieBjkJmphf+B23oJygiRRnrnSVGCC9oJ3cVcrqda3IoB8OaHfZNCdWXaw6vm0eiIpsCnVMZbILZ3rVaZHF7qShuLmMJ6UHTYRg5B9E0eg8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/23 12:34, Jason Gunthorpe wrote: > These days FOLL_LONGTERM is not allowed at all on any get_user_pages*() > functions, it must be only be used with pin_user_pages*(), plus it now has > universal support for all the pin_user_pages*() functions. > > Signed-off-by: Jason Gunthorpe > --- > include/linux/mm_types.h | 6 ------ > 1 file changed, 6 deletions(-) Yes! Progress has happened. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index a689198caf7408..8971a40c120e38 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -1052,12 +1052,6 @@ typedef unsigned int __bitwise zap_flags_t; > * specifically failed. Filesystem pages are still subject to bugs and use of > * FOLL_LONGTERM should be avoided on those pages. > * > - * FIXME: Also NOTE that FOLL_LONGTERM is not supported in every GUP call. > - * Currently only get_user_pages() and get_user_pages_fast() support this flag > - * and calls to get_user_pages_[un]locked are specifically not allowed. This > - * is due to an incompatibility with the FS DAX check and > - * FAULT_FLAG_ALLOW_RETRY. > - * > * In the CMA case: long term pins in a CMA region would unnecessarily fragment > * that region. And so, CMA attempts to migrate the page before pinning, when > * FOLL_LONGTERM is specified.