From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E48FE77173 for ; Mon, 9 Dec 2024 07:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B27BE6B03D7; Mon, 9 Dec 2024 02:58:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7C76B03D8; Mon, 9 Dec 2024 02:58:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 977776B03D9; Mon, 9 Dec 2024 02:58:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7AF6E6B03D7 for ; Mon, 9 Dec 2024 02:58:42 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2736F1A0277 for ; Mon, 9 Dec 2024 07:58:42 +0000 (UTC) X-FDA: 82874668254.22.9535D3C Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf30.hostedemail.com (Postfix) with ESMTP id AC25280008 for ; Mon, 9 Dec 2024 07:58:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=iplGaSoq; spf=pass (imf30.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733731099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8g2xdg9p5+uH4cGruNZ7ySDPkRDhVMxXNPc6aGQ32Hk=; b=YiXal8357awbBzFW0jSpIV8DnbIfaukIZ4QQ+Hm/sK6uYvBc0SnykTab4QryatLRFZ/YeL iCf1fwMVAoIaBq1q1TJkiSR9vTG6sM4JCvQe3nM/UP0oeSeFtHZldeeSjk97QT8auAvHHw KjBzuoyibJCIexI5QMjfJm96ivhi/+8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733731099; a=rsa-sha256; cv=none; b=dAcW/VUBflhDR+Cp05C/qQlB9kuiQrjYX1NPlLVaU03ggfkhf3G3E7fLEKKpf7KgU7Y4zG ww0xjLx3GP0oapPc3Y/jXnlpfRiFickwfULes7iUI/+baVe8jZosJL4NcCnkOOPNDMMka4 WwvFkj+yHvHljneJgmLCvDlgDnFHl/w= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=iplGaSoq; spf=pass (imf30.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2ee6c2d6db0so3649415a91.1 for ; Sun, 08 Dec 2024 23:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1733731118; x=1734335918; darn=kvack.org; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8g2xdg9p5+uH4cGruNZ7ySDPkRDhVMxXNPc6aGQ32Hk=; b=iplGaSoqlJhLmkcboCHUgc4r909nnZ0aS0+DKX6u4TJboQWVqMuPHHafchaEe2jkar 5zYoxz+kcrbMj5vFdRR13qN722zlpvY/momFpBbYEZ9DY6rSR/yLzwVOiMse6qdWUH5z LdrnXrcLOjOKrCkj5xbo9+ix4K6PSrcHoLWwMvyiZ5Buawr1DSaVtkwfVwnTUTJTVAaA 9A0vs60bpy4zN2C+uBC0IaF9X89YDIaZCs3fJaD2BlCztGHZ1R6xXaCV3zqou7yIylo7 7aY70FRtSw0F99BaaAIWVTe2JfslX2Lc1h01vGCFkKtZ2sa/FQqYYqOvaQRdHB3FCt7I hRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733731118; x=1734335918; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8g2xdg9p5+uH4cGruNZ7ySDPkRDhVMxXNPc6aGQ32Hk=; b=c5yvsYnELD6edMsbCWz4f4o0CGw2m9L0n8r4AS6uVejHHkh+68OmKrttTf0Ax8EsUg A0eh9kq1rtAcyYinmovGHqfsFcEv5bfj92PiApdlEuu5DfDLqoUefaSPhESQXZ8HTKCL 8gwA5IpKumGawFjbBzFKzGdu+Sl9Tkd7mGPQJdKSlxKggpHFfKj4ttUwUDAoNEzPJDeu TnksExGWr7hoRxZLC0AHHjmihqd22838mfisUmiyR9eGyx1QoCW+syro7/pi6IX6eLtT /VTX0578G7iSG1U5RVax3/32gV28q7BCiutufhdCzhAdiOOSEaGlYWi/k1Z3jHWoTzf2 sEGw== X-Forwarded-Encrypted: i=1; AJvYcCVguHXTF8ySCOWG7PRdNba1W/nXb+1uXpxJ2GjDHGmwq/TSLwVfYsTDB/+lsqZOnjDsodOnKlM2kQ==@kvack.org X-Gm-Message-State: AOJu0YxfjuskdKmD4Uw2Iv35hYjuYSx6CwXXdJYqYXNtpBOfFg03l7Tr kTONFakICnQvvFt+6A4e3y+314mZigiqH2Q05qN2/J09A7Jn6sYeC8Pov8T93F4= X-Gm-Gg: ASbGncskQfDqKXzJnr3TYPJJGw2DlZ80ZO3hzkcC7K/WVeszP+fqti1moNNTB2JpINp 5tHWRv1X+cz9wXtfio2DPZAl0W9JGtE+RdltQnOBWL+1d7esAzDq9GVcNAbyGgbQruYcwskx8qY 1K6F8PwQUL9AJwqQZsFtet9S3egeB2SMxMrll7UVdawxBUqN4qo4XIBlc7njAQvtOfNo80s+5gI 4sIGt9JJiMMsvYuRWrW5nJTYqhBT/yor5/eRyBrV1QueOEb23/cPGYrWPfF/8rF+/hkRz5Cdw== X-Google-Smtp-Source: AGHT+IHPR9lQduuFl9SmgV7fHugB2oUHPmbw4+VKgM0DNluz0xofkPR6h8mhwsz0kKeppVgZwt2Naw== X-Received: by 2002:a17:90b:3a48:b0:2ee:9e06:7db0 with SMTP id 98e67ed59e1d1-2ef69e12619mr18427663a91.11.1733731117984; Sun, 08 Dec 2024 23:58:37 -0800 (PST) Received: from [10.84.148.23] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2efa267857esm1972516a91.19.2024.12.08.23.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Dec 2024 23:58:37 -0800 (PST) Message-ID: Date: Mon, 9 Dec 2024 15:58:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] KASAN: slab-use-after-free Read in move_pages_pte Content-Language: en-US To: syzbot References: <6756a166.050a0220.2477f.0039.GAE@google.com> From: Qi Zheng Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@redhat.com, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, x86@kernel.org In-Reply-To: <6756a166.050a0220.2477f.0039.GAE@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AC25280008 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: jmjfbgd8u1fnhojjukmk5jpdgqjdt7ni X-HE-Tag: 1733731080-648232 X-HE-Meta: U2FsdGVkX1/0Xoo3MvCMU401FVZWhgJzzWrF6kc5FPierLxOIUIaQcA/+HkMx+xKzRjw6/x0ybRXc0asDPjKj+iFTuMQFU7as1tUKDSfjI7v/rfFW78EolE4l/5dduw/rifkswv8KKuWezYxNXEp8tA5BYuxOXaPLgsPoKtyRwGJ0wi0935mNbkgLkl4nFyabE0u5bEiQfWPEGKVV5njxC5Hx2cYMlPRlVee8VEbVcOKd3WW0acCRlFH71xapSoJP/XvfbvCkn5QI881TwLX89t9FjJxJOlBTKB/UDRwQTh4qYiO4tlFlftfmqrCKgXF6DBlZ+1cl9f3zjd1w4o90M9/ZM7qsnvu1UYQ2IU5xXV9jUMe69xcyaCifdAt7XJtQZE2AIDiRnQ50W/uV9g/2Hqtg+bN+OCsA8acngPAxsVTxmAjD8+ztyaey2pPN1fAnei33zKvVVdqRXH+E+DaQFliUqh1E/KFjCe4Cj5geWXDQqABF0IoC8c8ob17pqgnZllo8ZZ+3+3txbcW3eaMBd3lhG+NRvxsjNVjUdwZZ6UIr9/iyZIY/jGFTGVP9ARRpujKSY3hQXAsA52ErQXLNtABsyVHXdVZvfgH5ijagq8DZrVHqpF2jvpefTzVsBa9PYsYQieL7RxXiSkmL2gHHsPmnZDGvBnop7JzT2CVe3P3NW/B8rJ1B8GcKj1GtzeVrTZikHSYptWACQotULzEsVd35VCn6EQB1Coq7WUDHoKtCRsPDeEA/Vmj7XNaomOi0znJSxlhD3jtcg6bws9ZA/W8SmRPbd1CkK1zRBzWIA/X26ZxMQ6D7hAB4J2QOR4uKY7UG0hcBq7a4bw9jBaxC3l7kSajBm0hQxGcZyxIxfzXOGRyPc0qUUwbJHtO3pVX21OcdZ+O+ENzOOPfyZnZR8yt7cFD2bwLsi08iqEsYqFCmyMfGG31Os14eb8ISQk+V9exF1w/H1ImP5krdt4 oLcUjRZv TtYDZ7KAyYfZ+KGcxAVyfcf/knzjuoEKTQrz3vCtmoCVztED5p6nj2/6Kx9wJnWCWVmMQ9UQi7hEiV7bRC+3Xa/6jmxgsWAoHCxECxcxKDmgmauFemQkEcdyCBOyQWrEXuKUrHTB0HI8oEIPF2kMGKF8Wk7gXTtPYx/1q/F4Np4j3K20FlXpcXVTuXyrK0gZmk22sRS1YNEcgvvqooayq8SqguPn60RsOiAGnGgzYBJh10pl/XLjfBXdU406EVoqHqCunGOzlq1mVbE4CSDZN+HXmnvDv5pYJRVJC4kjH/90pHf72GsTmzR1AM9Ziubeh43RtRKUJTwRE7EFHTP05+mqAsueskXPC0w0gFmcBTzfqCx1ZmKwJ3bgN2zi1ZJCICjztej8dzhEQerAjsCUDbbDoQtJZfPAfmmTd2ZFvnyavVKhACR8DEC6MwXwSZywUCdjgc1LUI+0bxSYtihf27of6hMyX2FX9TDw+NdBk2G57XGoGZ84T0PxYyTNEnpiQTl6+B+b3mFLAYMykufVlRyk3YQTiJbMrVnincKPwsFSdkzFUSWT/iGt11PbArTzYI8k1eHElCHYYgBzCF7qrScDkQtu+AyXmvDyx10ea+NnoBAV4sYnKPjnfqd7xf9DxrAfsShSdcuDPhcrwKP4Dms8LvOjKVKpII4EfiOvxtZF95NSzaQ5ixpDG5TVD8tCqtAmmd1W9dKWiORQVw3J2H9oYXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/9 15:51, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > WARNING in move_pages_pte > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 6741 at mm/userfaultfd.c:1188 move_pages_pte+0x26bb/0x3400 mm/userfaultfd.c:1188 The code of triggering warning is as follows: /* Sanity checks before the operation */ if (WARN_ON_ONCE(pmd_none(*dst_pmd)) || WARN_ON_ONCE(pmd_none(*src_pmd)) || WARN_ON_ONCE(pmd_trans_huge(*dst_pmd)) || WARN_ON_ONCE(pmd_trans_huge(*src_pmd))) { err = -EINVAL; goto out; } This is expected, we can just remove these WARN_ON_ONCE(). > Modules linked in: > CPU: 0 UID: 0 PID: 6741 Comm: syz.0.36 Not tainted 6.13.0-rc1-syzkaller-00172-g6e165f544379-dirty #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 > RIP: 0010:move_pages_pte+0x26bb/0x3400 mm/userfaultfd.c:1188 > Code: 8d ff b8 f5 ff ff ff e9 f9 f1 ff ff e8 de 41 8d ff 90 0f 0b 90 b8 ea ff ff ff 48 89 44 24 18 e9 9a fb ff ff e8 c6 41 8d ff 90 <0f> 0b 90 eb 14 e8 bb 41 8d ff 90 0f 0b 90 eb 09 e8 b0 41 8d ff 90 > RSP: 0018:ffffc900034871c0 EFLAGS: 00010293 > RAX: ffffffff8212016a RBX: 0000000000000000 RCX: ffff88801fbb9e00 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > RBP: ffffc90003487600 R08: ffffffff8211df31 R09: 1ffffffff2853d10 > R10: dffffc0000000000 R11: fffffbfff2853d11 R12: dffffc0000000000 > R13: 0000000000000000 R14: 00000000321be067 R15: 0000000000000000 > FS: 00007fd136ec86c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007fd136ea6fb8 CR3: 0000000031194000 CR4: 00000000003526f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > move_pages+0xdd7/0x1600 mm/userfaultfd.c:1742 > userfaultfd_move fs/userfaultfd.c:1899 [inline] > userfaultfd_ioctl+0x518b/0x6770 fs/userfaultfd.c:2022 > vfs_ioctl fs/ioctl.c:51 [inline] > __do_sys_ioctl fs/ioctl.c:906 [inline] > __se_sys_ioctl+0xf5/0x170 fs/ioctl.c:892 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7fd13617ff19 > Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007fd136ec8058 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > RAX: ffffffffffffffda RBX: 00007fd136345fa0 RCX: 00007fd13617ff19 > RDX: 0000000020000080 RSI: 00000000c028aa05 RDI: 0000000000000003 > RBP: 00007fd1361f3986 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 0000000000000000 R14: 00007fd136345fa0 R15: 00007ffd06723498 > > > > Tested on: > > commit: 6e165f54 mm/page_isolation: fixup isolate_single_pageb.. > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > console output: https://syzkaller.appspot.com/x/log.txt?x=14142b30580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=3884fb5fa6f2533c > dashboard link: https://syzkaller.appspot.com/bug?extid=1c58afed1cfd2f57efee > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > patch: https://syzkaller.appspot.com/x/patch.diff?x=11245944580000 >