From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85788EB64DA for ; Wed, 5 Jul 2023 17:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C4698D0006; Wed, 5 Jul 2023 13:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 274AA8D0001; Wed, 5 Jul 2023 13:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D568D0006; Wed, 5 Jul 2023 13:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 03A5B8D0001 for ; Wed, 5 Jul 2023 13:25:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C867840392 for ; Wed, 5 Jul 2023 17:24:59 +0000 (UTC) X-FDA: 80978233518.03.8ECF585 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 5B0D114000F for ; Wed, 5 Jul 2023 17:24:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W8aOYvbb; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688577897; a=rsa-sha256; cv=none; b=CGAScy0CRKH+moYdpXqkKyIozogWQab1UXMc02vb+vOAAze/3kdkZEirk2KGMTQRXwGcQf e1h9J472tOr83zH8hy+mChUUVQV2fe91KWaZQNsqiU2eVCdFeEKVY5Kw96/C/8Tm37F98+ qLE4GgbEciAd8Br7+eRrSlH+cwRMcOk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W8aOYvbb; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688577897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v27EJolWd9vgnA83/Nkc58pSBSJkYYfnU44c9IwfWFY=; b=qJmsmf4N7JB7kE26pyrx44fjbldM4mrUisHz9MVslYUEg8c9D6rPLYN1XE66keLySGTnje K/Y1F0hzXO3K6BcsCanDU97sycwP0gV/3Tbz6sxEjgrfKCDuFjpjAWqSAHlelQrr7ZpKse TYtVi1BS0tAtolO+3bQrCBiPeL9ELUs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688577896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v27EJolWd9vgnA83/Nkc58pSBSJkYYfnU44c9IwfWFY=; b=W8aOYvbbsar9tqJ7q27C0IrXHlPgR6pdjhHlyPANCSEmeoC6HTZawAW//Ui1HFDOrWNgrA ELDZ3R2tbm4FtVzch9X1a1hsvYsFnW2Cr59WZYEP2b5ctnrGWO0pbLoyRMg9STA1P4ALKa TxO39wSSOnipPXZf65NtjcPg7iAJ8SA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-U-7IhBBkOv-NpyjOabF21Q-1; Wed, 05 Jul 2023 13:24:55 -0400 X-MC-Unique: U-7IhBBkOv-NpyjOabF21Q-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4edc7406cbaso6971495e87.2 for ; Wed, 05 Jul 2023 10:24:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688577893; x=1691169893; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v27EJolWd9vgnA83/Nkc58pSBSJkYYfnU44c9IwfWFY=; b=DheNR02qUYkvtG3v/Sc69bq0SSfmlPKPzCEt8HZkAUZe0bWN/UGjZjvzoqSQZlvpx+ t0ppPnUgvCXCk+MSvwGASQO2sRN6CQd4+WqjWSlghAIPXCJ7cVSpJo1eLDKmpmFOnSeF bH2qbkhr8V9SeEuqtz0LcqhXltrBVMWbqGlQgfGLTXMgvSVlRqyYBqqnoCWNswm7OL+T ICgTbbFdPJBHAuF342lobVEDIoLnZOMsWy3JQCfbtdh51Ewaow1u/iRDdZQ6QQjJi6C2 TRxCeptIW5D7BjLoco2nNJBB/0z0PoWjuJrH+I0+xsUnkdxAzKFWdXq047U2QWBIC2Va a5Ug== X-Gm-Message-State: ABy/qLbJgBKzAu0Po67v7Uq2zm3LpQNAgvyfHFlbg054J6Qv2Wcj2qCC jc13HBHt5G9N5WeWvpsYdJ47d8esiJJlnGyzjEr8n+835w6HAb0XJKcqrIJnJxfoGyN8fMTG6ov jga0upMYQsWI= X-Received: by 2002:a05:6512:3bc:b0:4f7:6775:2a66 with SMTP id v28-20020a05651203bc00b004f767752a66mr10546756lfp.53.1688577893205; Wed, 05 Jul 2023 10:24:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlFwWvdb9CtRtlyPDaCglyB2byse00H+L5+2mWlx0zEDsjYRPwa8pgXijw9uCV1C55NL7pPWSw== X-Received: by 2002:a05:6512:3bc:b0:4f7:6775:2a66 with SMTP id v28-20020a05651203bc00b004f767752a66mr10546722lfp.53.1688577892764; Wed, 05 Jul 2023 10:24:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:1c00:e2b1:fc33:379b:a713? (p200300cbc71a1c00e2b1fc33379ba713.dip0.t-ipconnect.de. [2003:cb:c71a:1c00:e2b1:fc33:379b:a713]) by smtp.gmail.com with ESMTPSA id x16-20020a1c7c10000000b003fbe4cecc3bsm2682371wmc.16.2023.07.05.10.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 10:24:51 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 19:24:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5B0D114000F X-Stat-Signature: g5krjcuafjnajwpug63yk4ij5xfujai4 X-Rspam-User: X-HE-Tag: 1688577896-942212 X-HE-Meta: U2FsdGVkX1+/CW1RPn3oLVG6cTOTTyA+mkdaBT3hTowqxsSYhE5miAmUmh5oRf+w5PvY+J3Kp1eF+Wvyc++ibKN0cBFClKUWqR42N23hKppRtbo/x/lAVPKSPhqMHVbkaImQCsY0htwPkkwb3TH+aY69/Ed2ysFiIPm6YkyxGZ0QBjcYC6cJOKHnCiN0L0DytsrpHPPZlTvF2f/9KELA+AnQec0QvwJG/FTMTCCCqkl4DWT15c0ENjjuL+YDvII+AJ+BuJbTJt+plELNZr14H4vwDGlGgOWH/0ib2AErupeQDyMZ410ZvidLYuq4+hmCizahgcBw6NTHLZcUf1+Lm4QhWsbkhMYbYxfbRt0snbZFC/GSSBaexz+v6l67MwzAyW2EyuuZlfaIKGM0cpDtB14SYssigJptb+Dqj8Su8miendu19MtgTO+wL0eJt1vzD0yByVfgJNmOBS1Yf/VGJPJDUNTdTQNsrswTIBEXCyOgzaPUOhN5xnChDonwbbNeNlkiBuNZitOHBa1hAo0zs7aRl0HOx+oHHdItg/soEdhgkR+tgON1LJo1Q5aen0QcceNk/LNzjD9zFwFGac3DKibW0pIHD5hVR9fhm/bXP8P3YDiDPLNkOs852+TxgC1+L6VTInif7Ey1sQFDXgDm9DdgV6Q5WEZ6vy3V1T0WPWPgsTbG4ritAjgD7FCnrjGfams8iJJF5MrKXSem0XJsahb5jiHVv9457hYK8usLyghQ+3Z0WScFQa9jiCfAKRlC2HqPOThVd9vVy/f5d87jVh/6Pk9AtqQt3mR4gjCjxEpEwmtZLxRFb6t50QBYMLL684X4Cs9H6x1zR6iHE+9eM1cr4NzRkZQhJaJGUsc0MqC1JUNC/YikzpYLTB8zrc7Rhxp8IyHZDhyX23+FEGSk8xu7oNTYIBT9pEGnNsHpDLX1GMq/7EzuIBuk2Gwliq1halgY41SqQ0E+cvS32/t xTqh4JNN DW/OfARSYMw+74Pn5vFFyjYD1GdYKsrALejn3jEjD6swZvkh6mu6Lt9mPXQD4ca+fnyrjilkelvm0gWj0elkQbaNni39TCKIKPVu8/zkQk9cN0GrxK0OXkqyZT2Jpme3k84pdSqq5gLaksl3j1/yuBQV4vPIrhvQ2zqLBUcI0LFCgVOste7LpBBPzX8Ne+L7YRytpLL+O5asjlO711SpMOgvTFQyaNOkMD/zqhwgIwy5hwBehLTO5VASopquuksjyVsqtKnCYrvFeD3DD9TBRsaVpTpW+bE2gUFADt+t6SdXt7HA7sSMoltCWhhyiEe7qfI2BH+bC+5VTo7cgHBoZ9ydROANkfvF3dfG07r/L0f/C1W9zAiIyG9T+ZO1AxnRSJMMCjdRJ9JBgrBdsICA7dguZYSM0+c+xvUJDCGPxAnJy+ms36BMkpEaB4DnEk+IHLzCRfjVQ7sPymwuVUyKk1ESQ6iO6AU3GNmeFGb+JrJ7PQRJ/cOlN46W1UNe+FT/Dlf9lw+HnZd9H3FNFhmCAiXpx14tjK+P5WoqX5RqxGpX2qDdsv5ji/EFlH0905hviuHb0qI8i3qCVK395b/11QkE32/a0QnEHiT7BANUDG15dWg3hcSEQmE/p/V9qCXzOZsM2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.07.23 19:22, Suren Baghdasaryan wrote: > On Wed, Jul 5, 2023 at 10:16 AM David Hildenbrand wrote: >> >> On 05.07.23 19:12, Suren Baghdasaryan wrote: >>> A memory corruption was reported in [1] with bisection pointing to the >>> patch [2] enabling per-VMA locks for x86. >>> Disable per-VMA locks config to prevent this issue while the problem is >>> being investigated. This is expected to be a temporary measure. >>> >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 >>> [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com >>> >>> Reported-by: Jiri Slaby >>> Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ >>> Reported-by: Jacob Young >>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217624 >>> Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Suren Baghdasaryan >>> --- >>> mm/Kconfig | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index 09130434e30d..0abc6c71dd89 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK >>> def_bool n >>> >>> config PER_VMA_LOCK >>> - def_bool y >>> + bool "Enable per-vma locking during page fault handling." >>> depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP >>> + depends on BROKEN >>> help >>> Allow per-vma locking during page fault handling. >>> >> Do we have any testing results (that don't reveal other issues :) ) for >> patch #1? Not sure if we really want to mark it broken if patch #1 fixes >> the issue. > > I tested the fix using the only reproducer provided in the reports > plus kernel compilation and my fork stress test. All looked good and > stable but I don't know if other reports had the same issue or > something different. Can you point me at the other reports, so I can quickly scan them? -- Cheers, David / dhildenb