From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75576CF9C6F for ; Mon, 23 Sep 2024 05:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D65B6B007B; Mon, 23 Sep 2024 01:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 985B86B0083; Mon, 23 Sep 2024 01:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84CF56B0085; Mon, 23 Sep 2024 01:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 66FDC6B007B for ; Mon, 23 Sep 2024 01:36:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E461C12102D for ; Mon, 23 Sep 2024 05:36:22 +0000 (UTC) X-FDA: 82594892604.08.373D031 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf01.hostedemail.com (Postfix) with ESMTP id A039140004 for ; Mon, 23 Sep 2024 05:36:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=DugNqPJF; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf01.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727069663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EfD6aWYTSxhMi80whxI+ZCh5yYgjEVQIiD1705p5+tA=; b=bOE0v34q5saPSm7vGEsWlZOgXZW9rbuk1CTIk8r09q+GafGf1b3Q82IpTqC5xQTzHuILzx 2RMkvo2iYCTV5ehHhTW7X1vSuGutprPgBueuiYILMDiDGWJ3pQBFGI8b9hqesrp93eOhWT 3xyjWA4q6A7bj5YK+uuVMPAuxXRQU1o= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727069663; a=rsa-sha256; cv=pass; b=xtppfsrqYcZRPeEbVA+BHUojpeOGXh44RjY6YBzj6mpMnKia6ugpY4hwK3iNegZxebcYgI grD+Rw0XeU6+MVDCINe2wlQaOInLF5wFq4GBdmLyM6G+oSkOZgmQ3e7C85x0aHgeTaaZ74 qM4P+nIWl3lfDY39IWCoVfFQ6ee5DrE= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=DugNqPJF; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf01.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1727069763; cv=none; d=zohomail.com; s=zohoarc; b=GMaTpHGd0LWwpouQsRRcq6ruFf2xuHXgrb5Aq3er28AbUbR3KkMO+hvdccv/AnDfpBwRikdHPrxMRlQPDVDYD+QbsZl6BKzqI7nyRLDb5ds9iXr69eSIuG9MHVuSSph3ozKRZgeCE+xjeOQhComZk5WgvyKNp2O/etrdQfB4e5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727069763; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EfD6aWYTSxhMi80whxI+ZCh5yYgjEVQIiD1705p5+tA=; b=PDGOCnq0SOm3SnXNffLMJSQr3EWnt33/kGST3fM5zb7URfbMhJ9RbdOtJ38bek1TByDXOPT/Z2MuatWXI15qm0A/BiLCbEj/WLU4T87mLKQb0v77FJjANqyJ/8wZTjJ2YAjIwDZp3P5+OVlyo9nCIxuSf0G7Xjd3+uDG1ibbm3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1727069763; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=EfD6aWYTSxhMi80whxI+ZCh5yYgjEVQIiD1705p5+tA=; b=DugNqPJFZqJ8WvbhZaql4mqylKjdjIDbLYg1rKky83Ab/6UgidWkQkO3u1qNXivt 6XfH66m8WQMZSIQFGZ5jmSArIWyC8w4nGiS3xdAJi5ghG/vhFgHx3dtQLso0bGHx4Xr cVle50xK9ZXbI0XPVkvrqSy6vgrhso1CBDDI/r7U= Received: by mx.zohomail.com with SMTPS id 1727069761276507.686379545268; Sun, 22 Sep 2024 22:36:01 -0700 (PDT) Message-ID: Date: Mon, 23 Sep 2024 10:35:52 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Shuah Khan , Andrew Morton , Shuah Khan , David Hildenbrand , Peter Xu , "Dr. David Alan Gilbert" , Andrea Arcangeli , Kim Phillips References: <20240912103151.1520254-1-usama.anjum@collabora.com> <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> <0b847784-a95f-4ed5-a0fb-1b7b4023df13@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A039140004 X-Stat-Signature: jbuuc14k99jkxmdomtk3133hqqh59xdg X-HE-Tag: 1727069780-664369 X-HE-Meta: U2FsdGVkX1/ezEdyuQ7vDp9qJrXbEcfa4OYX1OcIHt5I5bqpy3oJkpKlZiuyHCupf5iLWTOLVaJeyIQs/jCkWUBZsxSikFgLsvPBpyf+4CkL/J64jmk4RcmNvq9wyqrSApNDMT+8Ne+gIIU0e/KP2lcB8pYiX9CpZUXPydmYeGVXlIcENrF5aDZwn0P1TINwPisRKyCbOSJr+ziT12PwV9plqF+/aHifaqinJuQrELTktvYuiQ5397WL0Duap+4dZJQlcqM2/6POGBw1pVBn8qaA+YnLQXCNfis5nm7Bdd+hQbcWZw6OVtVchBBvzffv7KfqyqvqvgIcyqrae1hMd4bsFqVxwp15DHS0hsNO3V5Qsk9/xrpFMEZSuQJgJaG8iBGC6mxPXYTfUNcLh+f/AWfpf6gdD2eiWdjpVf3lNlkU0x0Mcv79Px/gbgKQ3T6PBv95g4UoFzWwJDK/e5pyGmEUHDL9FaxdE/IQiugwalYumfaoK/PMFxL8IRyA+srBCNSE6G8yElk2rSQKHf078HcBhSa12LCwuQwiuuE2Kaskh5MStJQZ+eSa0BAbpkwvR1s+s0kjPj96JukbbBoEb3BrKVg0clgYnMVSiMFSQY34V51lO9ZyVzIqtRONqHgaU3zYKzfD6jgxIV4DtKJ+4/oUg9V3SYVhF60KhBOmtJctp1ifOjl62rTewd0F4HobYM+RGHwFOnRgnEjfPvtByLD40NAlUMaDgCg8nlUs65iJJOxk1wurHyQl9b2kqc2Pot1+0qbMu9sXwzzPLcmDgoK06PjC31EcaL0LiUjJsqkmdTj8re0hFLLHZLkg1tZQj+gufpITKsiaFKfyT/F2CqIXgNcUBlTvt+onv163lPOIJXdmpVM9L5lr1/pA3yDVifAK7Wuy8cgk3X2xaSlYjGkn/7eKKhQ/Qza/TX28K/bGi6yskd0/iKgLm6Ojsr+hG7ceDtF/PAbL1iqCTBw 7uncEGW5 YxGdORqN6UJmshx3DzWYh2M4hVIlakg7U8up3L0WhuylJ/eyX9Cac8/hY3uw6UrTkejbhYMIPDl6dgzyb4exODVGSZMFdI9dYxpsy3ESz78L/UNfoWwYQsC+gcVQQ8g3PORXriSsAHGtrISphR97VLNVt4aUfmfbSAoznbAYWuBdr+LAMdIKgSwwFAnExqsH8U+bEhECCSWzvcx+8dYyQQ+4rA4OLHR7ee5QR35Ga8bhWWq7Qn5cMgolfvHESzjM74KMv4LnsY8UZyY3oTQEgn+r7wJPxsdt1v4OlrasuAVb2Hdu/CeG7w2qCP4jRXMClnmLwKjMKseTcuJRQFe5D8OvovCnBkTBz6ev776cDylejFPGZ18SWUCHrWj9+KQ536TBz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ... >> grep -rnIF "#define __NR_userfaultfd" >> tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >> arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define >> __NR_userfaultfd 374 >> arch/x86/include/generated/uapi/asm/unistd_64.h:327:#define >> __NR_userfaultfd 323 >> arch/x86/include/generated/uapi/asm/unistd_x32.h:282:#define >> __NR_userfaultfd (__X32_SYSCALL_BIT + 323) >> arch/arm/include/generated/uapi/asm/unistd-eabi.h:347:#define >> __NR_userfaultfd (__NR_SYSCALL_BASE + 388) >> arch/arm/include/generated/uapi/asm/unistd-oabi.h:359:#define >> __NR_userfaultfd (__NR_SYSCALL_BASE + 388) >> include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 >> >> The number is dependent on the architecture. The above data shows that: >> x86    374 >> x86_64    323 > > Correct and the generated header files do the right thing and it is good to > include them as this patch does. > > This is a good find and fix. I wish you explained this in your changelog. > Please add more details when you send v2. I'm sending v2 > > There could be other issues lurking based on what I found. > > The other two files are the problem where they hard code it to 282 without > taking the __NR_SYSCALL_BASE for the arch into consideration: > > tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > >> >> I'm unable to find the history of why it is set to 282 in unistd.h and >> when this problem happened. > > According to git history it is added in the following commit to > include/uapi/asm-generic/unistd.h: > > 09f7298100ea9767324298ab0c7979f6d7463183 > Subject: [PATCH] userfaultfd: register uapi generic syscall (aarch64) > > and it is added in the following commit to > tools/include/uapi/asm-generic/unistd.h > 34b009cfde2b8ce20a69c7bfd6bad4ce0e7cd970 > Subject: [PATCH] tools include: Grab copies of arm64 dependent unistd.h > files > > I think, the above defines from include/uapi/asm-generic/unistd.h and > tools/include/uapi/asm-generic/unistd.h should be removed. > > Maybe others familiar with userfaultfd can determine the best course of > action. > We might have other NR_ defines in these two files that are causing > problems > for tests and tools that we haven't uncovered yet. Added authors of these patches. > > thanks, > -- Shuah -- BR, Muhammad Usama Anjum