From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29B9E77194 for ; Thu, 2 Jan 2025 11:33:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7694A6B00AB; Thu, 2 Jan 2025 06:33:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7189A6B00AC; Thu, 2 Jan 2025 06:33:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 593246B00AD; Thu, 2 Jan 2025 06:33:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A7DE6B00AB for ; Thu, 2 Jan 2025 06:33:17 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A8EC4C0B22 for ; Thu, 2 Jan 2025 11:33:16 +0000 (UTC) X-FDA: 82962298440.08.ED9984F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 9EE3F10000A for ; Thu, 2 Jan 2025 11:31:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EqAjeOuj; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735817542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mLSWWA52yT997AEOuJwytCzUqDcxJEdXu9wbmXsgczE=; b=H8e3tkMrbAgwyQAhV9rzgW9y5Ys+5iYdb/Bk0DXOQCiRlP2+WKnaain/DWrKA9N7G71O9f 6kwGyVqGvXYKwNXmXaLXKLs9eqC+nwE2a6zZEwuetnpmcBTYU/umS8hLv07iLlT/rXVdxP F4LSP+P7NyvxYMtQ5EFuqF1N7GfMzcQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EqAjeOuj; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735817542; a=rsa-sha256; cv=none; b=tODdIcPo/m8n2rp7OpjRVSbC9LHM8ZA2Dv0QFLBu0kTsWXGTfBk4IaW2oCBbqWr5W6ktxr VN10hTTg+2ImH5rOeYtZ4XZ8P3L/IQfdLvNDrMm7W3TiFleTpOgt+Wgb0ykW9BONJD2Vr4 eCFtvqPFRbYnXwnITmFIZtISgQS4JWw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735817593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mLSWWA52yT997AEOuJwytCzUqDcxJEdXu9wbmXsgczE=; b=EqAjeOujVKHxGS623mZ5hK8wUuJTvaWjho5ROXVzcsjeJM3szvaSootcybzsiNJB4GMcV9 +GNVas4eDwuqHCUCwQ0ZFWFF0HAU/M65bfQWxPtPPcOGtuUFo66boBS6KjxlR2FVxOg9Bu ycc0P8ts2ClHtZFD6gHKo2R50ruzPJY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-6dc7a3_pNju4qQZJphbh1g-1; Thu, 02 Jan 2025 06:33:12 -0500 X-MC-Unique: 6dc7a3_pNju4qQZJphbh1g-1 X-Mimecast-MFC-AGG-ID: 6dc7a3_pNju4qQZJphbh1g Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361efc9dc6so62619625e9.3 for ; Thu, 02 Jan 2025 03:33:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735817591; x=1736422391; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mLSWWA52yT997AEOuJwytCzUqDcxJEdXu9wbmXsgczE=; b=uoIoJNSODvO5C60A9NcV+KOuj3XeSnQn3QckovzIUKX7PQn0Rjb1PsRjb5pR8z8P6t AYFtVfZ2PGushbBDXfv56Y35xnZvyldlG6EZq48b+rGxvdDdjStaomClz0T1KWN4NwHM IkkXhYULStSGVRMdKxdRr2ggTAcbiq4MXgO/TTwa6jCAc7l1EzPRkvZj9aWRKpR16Wzu j2sS29YYgAxKMMXiv9YRixyc3xU3lamJdrRE9VhBGSqjOyVWtsTaeG4CkT+NrczBuTIw QQMBWWTdlFlezE9Ovik1r0UzKlzYI4+YBQpMMfNyHOWTA39sWRqCra2qDB1lrwmKZbJi l+iQ== X-Forwarded-Encrypted: i=1; AJvYcCU/xXoh1mlLqo8Qlk7DyIxmfUtBzFDbIZ/bYrhk21uMXZxhqvuIFXY5wbJgCsnS/P5TbeIMNFqF/Q==@kvack.org X-Gm-Message-State: AOJu0YwoHMsJKdMa11fMrnqeJuGkPsau+Er2J/4vNzbd0YUrROad1aWI F1+3I+tEqK2F/AqKUK6gwULWL88qJ5f2TfQO+mexfBDujI6X1d1Zg5nDcEvxYWPyQuM/97pCft7 Nz6za4yNEZ+SGdpru5pPVRFsDBnh2SZGUk912iPEHT3Lev0l8 X-Gm-Gg: ASbGncsXGDNOEw8jqiOSaaD5+eAyR6gtYKO8p5FxsL0nF23x0QZwgG7Fjp4zf7AJJxW qDma+Toq7VWUEpAAktjlkKszQED7PlT4RwW9zeuzmPaf08164Q0Xv5AoR5t4q1K2Cs/vErVn27h DQ1n+w8OXez2WtsKA4NgGrcr44ycYnLaq0Mf8yMY+1Kwb7vXqj1p69p7kpU+DWqBWnY8mqAOOKc ybsBMIa2N2VKnSYICc+LFsM0M34Nq43tsQ4TBxnvBz4GyWOaPGW7YNxD5XMtXPpy/zvrVZp285P h1Qq8XhC+14/l9HCk5x83B7xC3+ceepakyxjjepExO9HrdvNwemhfepuTWZqW8KtzNzb/hhhU0P H9Dg9902u X-Received: by 2002:a05:600c:5112:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-436c2b5b491mr2644525e9.13.1735817591015; Thu, 02 Jan 2025 03:33:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTX3tPQ+BahOJXy8WMYJ9SLwiimVpaV1P8aZElUVdfYcjhCrwqjTDuGv9rburyVFkE2PoIAQ== X-Received: by 2002:a05:600c:5112:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-436c2b5b491mr2644055e9.13.1735817590505; Thu, 02 Jan 2025 03:33:10 -0800 (PST) Received: from ?IPV6:2003:cb:c735:9400:f91f:1f24:e403:81fe? (p200300cbc7359400f91f1f24e40381fe.dip0.t-ipconnect.de. [2003:cb:c735:9400:f91f:1f24:e403:81fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b214sm489238855e9.28.2025.01.02.03.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 03:33:09 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 12:33:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/12] khugepaged: Introduce vma_collapse_anon_folio() To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-10-dev.jain@arm.com> <2215dd8e-233a-427b-b15c-a2ffbce8f46d@redhat.com> <28013908-65d8-462e-b975-cd0f63d226b1@arm.com> <0368f4f2-cb0f-4633-a86d-5c3f75839b4e@redhat.com> <8d752d25-b9b2-4bf9-9a81-254aeb3ab0f6@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8d752d25-b9b2-4bf9-9a81-254aeb3ab0f6@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iACuqj0qhf8hdcWTsZfv7NFHmuUdgDcb732R-dkSrdA_1735817591 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9EE3F10000A X-Rspam-User: X-Stat-Signature: nnmzy9g4erseubzd1dygpgnzko3tgqy7 X-HE-Tag: 1735817497-911998 X-HE-Meta: U2FsdGVkX1+JSdDwEiw91LjKxqBbFDK+XlnMTIS61v8T8kWekCIMVwmS59PvkZAmABI/PLX1pjsi0ACeFmXHpPcxEXx3nnTDYZJy4v8uWIn5l5B++vvBuWefVjbMtkYp9I5/KDGR9z7JnsCsWrJWPil+yiAPuuGYQ6DfjNQqEBN6GMmzu/q+NU19ONpnQcpegKkqhUuG2vU9vXDYHLmbbkn8O1t8pNYpP+f5ZpPut1sgW0LXmDu1sI9zxgs7jw6KL7mdrTZy4W3KvRx3OjQZyobe0ZbgL7g09AZ30UhI3xulU9dQnHafZhXqwhsbYBwH1zr+CS1zusp5Bsk0JdOLLrdY6P2aQSgsdkgKRFvgidhE1BNczsjlsEKnKq5xQ18vsKQHAd6EJMedOTYLr/ns2XlXEqMreNwFjQWxrqieXmGVn4seZuua0EYMRFnFQ/Vh4a4TFaDfqzHxx2LpZkgs1p8XQXE9xggoCSkC9UG+P1DSQddNCD4lSY4ZIhuZMXBWsnYIJsNQLGeV37KKRGfBUHuFfbEWS6+Y9g/NOA3jvDbi3Ir3NB0KhjxbiPvl56T1xGreGeVT1KwmUvLdvfbQgRq1VTZCvVSXGnXy34DFX0p0ozGHIzKk4F4fTmWWnrTc32qC6L21oINtS2ea6yH1XMoFmoGVEcb7AzL+yB31vO+hanAvBqWWxgmTfyNhZxHw4CNyMxXgmUmAJuKRtXDU6+Q7/CzL8zre6DB9adq2gj8ZhJtWhnVk7Nm52L7ViYKLMnchQuh/BKU/aYc2ACBtRQsQpNiyH8X/wuJq48d4AqvfzpvyP8cK4r37s9DsvAETvzKj4pObwTCxLF1pYQ7GWt3tARBJtogiBgFOC5otBCrDuk0zk8tH1kegldiFZz6m1PeLa8P4972hWDjiTPQyEIa8mGyw9U02v6HrsqFAmcYa88GFTE0P0E3Z/GpnZknfDjXdZLj3bo73s6mO1k8 Wp8vVi7X RrC97k2NjjpS/QQL+tQy2lYSw6Xw+T+lw3Hyl2z32TPNCbv+NK8MXYhWUf/j3SoWzxm6HYoagYK6kL0taJTn52LVYfYdokMQrMsucFrd/t1a3DKWC06nW8F3VlC6ZtlVP+TB3wwg2wABWKDqK9300EDuOwVrxmgRxZEs9Fzu1NywDp0eg5PoWR3Bfqne8TxwzJhFKT3qO8E/xau0JNJ24G5D5vq1LlVh+cNslnKh9mibxmZ9XwtfWPPfPfv/BiidG9jKw/6ZwlQbmgM1b/Hjia19cS4FnjKBrLRpK8pN0vrSftrbl1vhkefyKa7QZtuZ2MGoWLoQKP94i0n1yquUEufOWnA5cSHjnMicpF6N5gYwiQVL9sIITx1jf1ZGzaeQX4QoJ96nc1c5QJsvWO8eBSEyM3pVZgjjyEZay62yypQZ5XRk0wbykqKmi0iOMVH+7qon76DJUUZZi3JhPUmB2mFkhiVIikao0XDfWcgiKwNgmUQ1PAQFPpOLTpGSIDwB2+LqlPKmYChJBr0Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> >>> When having to back-off (restore original PTEs), or for copying, >>> you'll likely need access to the original PTEs, which were already >>> cleared. So likely you need a temporary copy of the original PTEs >>> somehow. >>> >>> That's why temporarily clearing the PMD und mmap write lock is easier >>> to implement, at the cost of requiring the mmap lock in write mode >>> like PMD collapse. > > Why do I need to clear the PMD if I am taking the mmap_write_lock() and > operating only on the PTE? One approach I proposed to Nico (and I think he has a prototype) is: a) Take all locks like we do today (mmap in write, vma in write, rmap in write) After this step, no "ordinary" page table walkers can run anymore b) Clear the PMD entry and flush the TLB like we do today After this step, neither the CPU can read/write folios nor GUP-fast can run. The PTE table is completely isolated. c) Now we can work on the (temporarily cleared) PTE table as we please: isolate folios, lock them, ... without clearing the PTE entries, just like we do today. d) Allocate the new folios (we don't have to hold any spinlocks), copy + replace the affected PTE entries in the isolated PTE table. Similar to what we do today, except that we don't clear PTEs but instead clear+reset. e) Unlock+un-isolate + unref the collapsed folios like we do today. f) Re-map the PTE-table, like we do today when collapse would have failed. Of course, after taking all locks we have to re-verify that there is something to collapse (e.g., in d) we also have to check for unexpected folio references). The backup path is easy: remap the PTE table as no PTE entries were touched just yet. Observe that many things are "like we do today". As soon as we go to read locks + PTE locks, it all gets more complicated to get it right. Not that it cannot be done, but the above is IMHO a lot simpler to get right. -- Cheers, David / dhildenb