From: Yin Fengwei <fengwei.yin@intel.com>
To: David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
Axel Rasmussen <axelrasmussen@google.com>,
Mina Almasry <almasrymina@google.com>,
"Michal Hocko" <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Shuah Khan <shuah@kernel.org>, Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/3] mm: enable MADV_DONTNEED for hugetlb mappings
Date: Fri, 18 Feb 2022 08:39:44 +0800 [thread overview]
Message-ID: <e4d6dc06-30cb-1f92-32a9-d9057bcbf6b0@intel.com> (raw)
In-Reply-To: <fad42051-6816-08cf-1430-ad4da5dbc951@redhat.com>
On 2/17/2022 4:58 PM, David Hildenbrand wrote:
>> In man page of mmap, NOTE for "Huge page (Huge TLB) mappings":
>>
>> "For munmap(), addr, and length must both be a multiple of the
>> underlying huge page size."
>>
>> Should we apply same rule to MADV_DONTNEED? Thanks.
> madvise() already has different rules than mmap() for ordinary pages, so
> we'd much rather try staying consistent with madvise() rules.
Thanks for clarification.
Regards
Yin, Fengwei
next prev parent reply other threads:[~2022-02-18 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 0:23 [PATCH v3 0/3] Add hugetlb MADV_DONTNEED support Mike Kravetz
2022-02-15 0:23 ` [PATCH v3 1/3] mm: enable MADV_DONTNEED for hugetlb mappings Mike Kravetz
2022-02-17 8:32 ` Yin Fengwei
2022-02-17 8:58 ` David Hildenbrand
2022-02-18 0:39 ` Yin Fengwei [this message]
2022-02-15 0:23 ` [PATCH v3 2/3] selftests/vm: add hugetlb madvise MADV_DONTNEED MADV_REMOVE test Mike Kravetz
2022-02-15 0:23 ` [PATCH v3 3/3] userfaultfd/selftests: enable hugetlb remap and remove event testing Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d6dc06-30cb-1f92-32a9-d9057bcbf6b0@intel.com \
--to=fengwei.yin@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox