From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDA1C021A4 for ; Mon, 24 Feb 2025 12:13:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66DA66B007B; Mon, 24 Feb 2025 07:13:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61D436B0089; Mon, 24 Feb 2025 07:13:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50BAD6B008A; Mon, 24 Feb 2025 07:13:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2AC306B007B for ; Mon, 24 Feb 2025 07:13:40 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EEC2850BF6 for ; Mon, 24 Feb 2025 12:13:35 +0000 (UTC) X-FDA: 83154728790.14.327EC2F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 2AA9A4000D for ; Mon, 24 Feb 2025 12:13:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740399213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=heGJaT8pu0zxBpZh0rGBHvZD2Wf0HXTD26JsNXiCq4k=; b=UE6CuQtZ20pg8a8i9srLsCiD4LbnBzfHipjIpABWVvdeoBfsypcWiZDoUUOLiTEKghZ1DE +O5SxcUyTrhcLlQZWmwn/kapMDyPwMC8zEXqp6VAo7bZdM9MyN1138WC8RJVLpbuuHSrrs GKAoRWiM6bW0HL7BcpOG26p9mIXK7dQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740399213; a=rsa-sha256; cv=none; b=Zj7bgjG4MZpmdHst6RXhrD9NJX9RH5KLU7JQHrWlI8k/JW13bO+QJIG9ze4KrlEoXoMtbM rRYr4dRSeA1IrowpcQSvGrUXu58jZ6iXHJrv+0gJu7TZmF5C8XH7C0gWyZp9TOk4F8kA9j ScEfqDpvmB4VVPTVpCbujBIeK1MdJB0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF6111756; Mon, 24 Feb 2025 04:13:48 -0800 (PST) Received: from [10.1.27.150] (XHFQ2J9959.cambridge.arm.com [10.1.27.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 391C13F6A8; Mon, 24 Feb 2025 04:13:27 -0800 (PST) Message-ID: Date: Mon, 24 Feb 2025 12:13:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/4] Fixes for hugetlb and vmalloc on arm64 Content-Language: en-GB To: Will Deacon , Catalin Marinas Cc: Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250217140419.1702389-1-ryan.roberts@arm.com> <20250221153501.GD20567@willie-the-truck> From: Ryan Roberts In-Reply-To: <20250221153501.GD20567@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2AA9A4000D X-Stat-Signature: tgceywysnfiipzr4m979eqk4h66rhdab X-HE-Tag: 1740399212-271410 X-HE-Meta: U2FsdGVkX19fuiWqfchW9lg+3xO3+s4NGGnv/KHg2NGLoIRCrO82195opl45YLpF7whzOrQIyKSlOGTJOzI8ES0ohZgmxzS1nQhu+Ww/Q9xFjUW40gQywA9GUWFOQ4kWhnFcw6bXt+Lx3Rk66BjwhNPfbNPRWWHny8o3MZdJQu9CWhLOWvIIbr83H4V2A4mEY5/IJ7gt7+klFRM3Sj0ixkbBlZ01QudSFxhTS7H5W2YvSOyyvcKi+JXBxARLBrd502FI9wMGK63gwIvdfgmw/npbt8NwuZq3tzEFSl+AWTu6bbkr68QJ8i5ml/RJgpwObs0XXQ0R7OuJGMB1qgNs1okLHRKR+borbduwjGwpf9NlNTsCP5vHs56CzA5ZdhSr5mlJiM8L7Yf1GCex0BRRyhVi6JHH9qgcyYlZUvpTDF0WW2/jjwjmo0DETxDueQKjbv1FOONFPHRMEHT1BGBRWE+xhg2m/vyOnYHyDH+uru1LHSf3P8nTIr/5UDIkOGSmxfq2tFym3e2zYX5Ur62VxsoPva4fuT3i9Y609Lnkj0eWoWiVhyN5FzmEkmmZ2fc3WV4A7vjdjyxOa0YRrVYdhi+nH95jgUR1zc+EVzfpT/KcGM8I6nq81m3ZhBgNoKdc9KaiXn61+fCZpeAp/7Nok8VPVYj/JvI+FTx6dM3ixlhts4Sv/rHt0r9wtqkIe30+HJItZvrG0C8wXC7uCwCgv8TBTtJ/iH+9VAQ9RcoMpf6pG53Bb4EqHaEbIKw+udagBZWQu/gFv/qKQFb2GDV58r+c+d8Is892UwCY6V0lZPoRDfSPxIHnNHjH44+YRmInfZagCaVWXcf7OfPykl5l7dn6pIFIkZuwnv6KUq8boVgVmhoTeNTWYzNIH2Oa+N1cuma/ni+KjYzbf0sPjsBAO+1gfkTaQb95wtPwJnD9ldlMTCBnxcmJiUwl+mwTyVL+4X1H0PmlYhuQif2ZUko 69AUplST EiqOneh11PbtGrzGHnpBWE/yP1A1FudsShlqNi9FYB+E3VdLrWSi5eHyC4nogP/AMML4RAFmbr1a6XCcjzEYi7RlCV7bHETaRNQRmTDGmfWDperd7ZQTS1qJ2Tix+DaqCihjGSoSv4RQ2boeJHP71e5z7t964yFLNxnrZSHxah65/dpxXo3X8bC3PKQTN0ApY1xDuAQ9+Iifn/JHUUws+GoJn9zOhAE6gGEOR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/02/2025 15:35, Will Deacon wrote: > On Wed, Feb 19, 2025 at 07:10:32PM +0000, Catalin Marinas wrote: >> Will, Ryan, >> >> On Mon, Feb 17, 2025 at 02:04:13PM +0000, Ryan Roberts wrote: >>> This series contains some fixes for hugetlb on arm64, and is split out from v1 >>> of a wider series at [1]. While the last patch is technically targetting core-mm >>> and is not directly related to arm64, I'd like to to go via the arm64 tree so >>> that the wider performance improvement series (v2 to be posted shortly) that >>> depends on this series doesn't have to be robust to the fix not being present. >>> >>> I've included maintainers/reviewers for all the arches that are (trivially) >>> touched due to the API changes, hoping for some ACKs. >> >> These fixes look fine to me and I think we should get them in for 6.14. >> I think Andrew was ok with them going in via the arm64 tree: >> >> https://lore.kernel.org/linux-arm-kernel/20250205235219.3c3a4b968087d1386d708b04@linux-foundation.org/ > > I think the diffstat looks worse than it really is, as the arch changes > are reasonably mechanical. I'd like to let it sit in next for a few days > though, so I'll pick this up once we've resolved my comment on patch #2. Sounds good to me; if you're happy with my proposal in the patch 2 thread, then I'll respin. > > Ryan -- did you find all of these issues by inspection, or are you aware > of anybody hitting them in practice? All by inspection. So I guess they are not urgent to fix from that perspective. > > Will