From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB454E7717F for ; Tue, 10 Dec 2024 14:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6045F6B01FA; Tue, 10 Dec 2024 09:27:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B2E56B01FC; Tue, 10 Dec 2024 09:27:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453C76B01FE; Tue, 10 Dec 2024 09:27:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25F0E6B01FA for ; Tue, 10 Dec 2024 09:27:14 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C491CAE17E for ; Tue, 10 Dec 2024 14:27:13 +0000 (UTC) X-FDA: 82879276494.02.01E06C0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 9DF36A0009 for ; Tue, 10 Dec 2024 14:26:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ssf8SlF3; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733840808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kjYmwEpc9GvINrn7+0Dqy4dw2ORaC+4QWuEM34daqho=; b=dMjuuisE8JtnuBm/nDVYHopbH8y1IXbEUMSFbFZ3xPsFgN0LTO0gRCReKC4335WhEndxC2 oTdtEcKhg1Fa51YXoWQy0At9cwzVoTyyOOiKDp10drg/HErsoSKTuXdgnTZIJnhHN/sX9L kOEm0tNqK612e3dwsnzzYOPuFyNyirw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ssf8SlF3; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733840808; a=rsa-sha256; cv=none; b=cToS9+jwxmTcCJzH8KFuLeaWRaCOkKqarNostwOCbfntd1G64txIbVBOlXiAlsD3j7WgaI m45AAnD5BAEdmXiTsO3E80rsOwJirQaSsb5WPekqPxgIFxMuyuQG6eJqTuhJdS5YXUMDf4 urkqEBA9KmnEf41XEMv/9yP24XQY4yc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733840830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kjYmwEpc9GvINrn7+0Dqy4dw2ORaC+4QWuEM34daqho=; b=Ssf8SlF3cjjaxbM/jOc3Xr1HNP+Ad6mFDIjWDeeuo6OR+u9Z/OgpKQie7/FqOoKtkwihrM P/rBkSPV+IzKZvpLQ2wZ8sbI+emi7j7frvCceV5qD64DFZTX4mZTUKHwoOskOtjHJdpUIl ehDAoYZnbJo+xnJEti9r+84tX/Yg2LQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-1XRMEYZeNRKYe5lmGylIdA-1; Tue, 10 Dec 2024 09:27:08 -0500 X-MC-Unique: 1XRMEYZeNRKYe5lmGylIdA-1 X-Mimecast-MFC-AGG-ID: 1XRMEYZeNRKYe5lmGylIdA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385df115300so3117134f8f.2 for ; Tue, 10 Dec 2024 06:27:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840827; x=1734445627; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kjYmwEpc9GvINrn7+0Dqy4dw2ORaC+4QWuEM34daqho=; b=cf+5j+0bPep12/Icm/9LwVInlkfZ23JSmPptKu+JdSbScw29odEL4ruDMbq68mGRLA XT4YGBJVg4OpTMppJi1gvjBuKF7+YqoHZtYOetCUhLmBdCFUOwcvu2oSGN4OYspJtGDp NFviwk7B0K18iFqdb8YtNlt3El3t3zUQUZw/B1HKG49u8ukg4wj8ETbCeBWCtzCOU8QV OtO5ixIvLvi+a7sPECKSJcf42P4AzciTJe0CUa+iuguzK01Eo39CnhSEMchj1I28FpEk F3n9i9exjun0rqs64UJ4dPeJP3FSxJeRJYiX3px6/MkKvlig7OKt1Rn9Z+FosJ+zOIY8 qkjA== X-Forwarded-Encrypted: i=1; AJvYcCVxwVvYeyfObfgdBKReE9cQCD11gmo4dPFCl2rl8HqA/gMbNy8pNLNi5JL4kArN2yYJ+nb30pT1MA==@kvack.org X-Gm-Message-State: AOJu0Yx3UXrO5optyeb2Z/RBQSke2UJx5J1sltW1mplVjgkd+xAqZ/3y QuC40W/X2CFSw1p/rL4o2rqUvuFWeXlJCrRKLw5S/rCN8TrjTvlcFcUt0+wHDxIvOcB1yBSCQfJ hsJDx9S3wGQn+SA53dJ008LYyUfl7EHHPKs8RlVyh7u/sxvVI X-Gm-Gg: ASbGncu5qudkkzT2XwAZHwxvntYLGZ73uwy30qPU7E0JSd4rWeR3ashLfYE2QwylC0o jqx09B1J3JaPO7RSb8rHlKw7avygtzYGwpM2UuPgeoGGY1okOdl9jMtaUi+ZY4f54YaKoqAPKhq sw68GoYFzjpXM+zlOI6YCxVwNT/pYMl9IDiRQgfxIiy1YxGedqalaH1RIJSjrRxvfCzkAiD0y0z RogQOYw2h3ugiBiRcKqhjp5HOOillyay4NyCsrPMR/nsJTs+n/x1TGhfTFxMQSVIZw4Fo4jqke6 QoT8MKLAAhMUnvk6D9V1oeVlpu+8liUzJOBqSUC3HZ2CSkwJTkIFR3OjtF8jpinKrjrLO3dnUbi fGFo9EA== X-Received: by 2002:a05:6000:2ac:b0:385:e429:e591 with SMTP id ffacd0b85a97d-3862b36b8d6mr11280956f8f.23.1733840827364; Tue, 10 Dec 2024 06:27:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFA7TU6la9RqQsAEAfNvBH7ItL2dEC3Ur7vP89Y5/zO+E8rGF7O2x7M66VejnD4Uy/w5Weg1g== X-Received: by 2002:a05:6000:2ac:b0:385:e429:e591 with SMTP id ffacd0b85a97d-3862b36b8d6mr11280928f8f.23.1733840826945; Tue, 10 Dec 2024 06:27:06 -0800 (PST) Received: from ?IPV6:2003:cb:c723:b800:9a60:4b46:49f9:87f3? (p200300cbc723b8009a604b4649f987f3.dip0.t-ipconnect.de. [2003:cb:c723:b800:9a60:4b46:49f9:87f3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f5774454sm85292535e9.13.2024.12.10.06.27.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 06:27:05 -0800 (PST) Message-ID: Date: Tue, 10 Dec 2024 15:27:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 mm-unstable] mm/migrate: Remove slab checks in isolate_movable_page() To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Vlastimil Babka , Matthew Wilcox , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , linux-mm@kvack.org References: <20241210124807.8584-1-42.hyeyoo@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241210124807.8584-1-42.hyeyoo@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i0Yit8mfPQhRZecCWT97n2dqYlIXBGRP0qw2GBvFBJI_1733840827 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9DF36A0009 X-Rspam-User: X-Stat-Signature: h7nn9xeouqrb171xx9zukoi8ri18i3hp X-HE-Tag: 1733840815-280740 X-HE-Meta: U2FsdGVkX18BkyrmnU7sJKKT0uS9Td26u4cQ4/YOQCtaQFbfw9YmfdqJzvI/Jx52Cz4wQp6uvjpkEh3OecclGBgk0zMYOHvsD2Q/m+HbqafLmvraDxGVKKGzUnmWE7WV5MelSbNJe4+NJxImqjzgcEq1//QAOH+wdcIME+kOlE8s93JSxwAnYGklradgXNS8H/d5Y/cPEI+CGLKu18o4c3aBdyVCQBu/jEX8ValvbjRNd9KeOF11KlxiOoYB+o76XsQRAPD1ZKv21p8BNel/R59nHoobzOHPLkqhSEuK1ruPifna9E6zGoKZ0C+skdx3m0nBN1GeTlJtRFTDrXEtWIMpUoar+U7RI3t4ZD+nnlnviW6MxYp/m0HBYqOnUJBxftXXvdBE9htsoWx32zuS+l/SrVmx2yvJOgAZTJQ6bmo1mhdn80WZfluGPDsbBhTXxqE65QvC363+3TN4957DnK8koaTALL4/x+x6O9k3FK7CfDc9UcZum2sjMTwL46fgHGQm/YsOZoV2SV+q5+ZwDI9QAMnb0t2wAA+KFvMXHJ8gABkt3jgYwsyD5nUTyuc60w0jOQTOpQoO4kpKrgUjdVN5Ke9E2SrKu9t6u7DYnUuBK9lQDUe5cHjqAN8aA2Ae0d6wN2+RbiLJyZTiQY7HdKGMlq3KFkM+5NyuLCbNxxzNxCA/hU59UcmVC3c4aEp7ZHTwXVVZ6IAqvdXnsQpR5lE576SPz7LD4QfMqE5kHVxvkT1gcQ5F/hrjPQ14sfUfTamnvAAXwh6ZstoMUb+1NoMIkxO7uATmxn4X4pq/99O8KzdMme/2WYqXbasqjUV+XuYjd+lIdOs4cXRzTOCJWcCopdSTWHyjtJ55eBhrkCzvuYhiwp7NBa7uQ90mQ1gZE+Nq5vIz0MbkiBzukv8WD3A6/0HffrNx6jd1wXvEZzRwQL/dwiszM/j8ZAISJcCSynubKzOkt8Kk+JeE8uV A+Wb4Pp2 opbvnxXQQQdKHYfGye5OXJztFY3JArUG9uIoRYvaDEpHVsNOvlowJVZMCmvB3jkycLQmPcuDVh0DmFfVA5VS8qqDGiEGVlBGsz03PmTht9MiJkGAuS3QZWC++e48EEuxPyXTa2kwg8lq2agENEs2NgWhtgWfxOQnzfzU90YdZkoyI1vZ13+DUykSWXXYA8tvBE9LZpk8GlwlfKYgJaaEvuuYMKrFGdKK9AjqULaZm5+/3+R2TApaNMDA3nVTlioI1vVkRr/LKg/2gvY8MjZICH5pHqRV+FvZ3XFRJalrmClVYzIO77ZKRT9EiO5jnbfAWO3GazsCoIIduKeCSPDT7yofnmzipi5G823fPijcV9DOePoNfaJzauPlstjIHplIi4G27GiF1W/awAv9owyrPix9tqFR7pYB+V/FymMtwZtdzKDeICA0igjaxedDZTa5I4+kByn8H9RmDn4cNjz+jAKBsuU31sF7sN4iEvO8fCcAQfBkj5jg7XW92WO1VHtSu1ojJpoawjXbjG1eCDH8OOFF2LaBrQxB6ahu76Ax2vssklBvNIMMexdoRtA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.12.24 13:48, Hyeonggon Yoo wrote: > Commit 8b8817630ae8 ("mm/migrate: make isolate_movable_page() skip slab > pages") introduced slab checks to prevent mis-identification of slab > pages as movable kernel pages. > > However, after Matthew's frozen folio series, these slab checks became > unnecessary as the migration logic fails to increase the reference count > for frozen slab folios. Remove these redundant slab checks and associated > memory barriers. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/migrate.c | 8 -------- > mm/slub.c | 4 ---- > 2 files changed, 12 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e9e00d1d1d19..32cc8e0b1cce 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -68,10 +68,6 @@ bool isolate_movable_page(struct page *page, isolate_mode_t mode) > if (!folio) > goto out; > > - if (unlikely(folio_test_slab(folio))) > - goto out_putfolio; > - /* Pairs with smp_wmb() in slab freeing, e.g. SLUB's __free_slab() */ > - smp_rmb(); > /* > * Check movable flag before taking the page lock because > * we use non-atomic bitops on newly allocated page flags so > @@ -79,10 +75,6 @@ bool isolate_movable_page(struct page *page, isolate_mode_t mode) > */ > if (unlikely(!__folio_test_movable(folio))) > goto out_putfolio; > - /* Pairs with smp_wmb() in slab allocation, e.g. SLUB's alloc_slab_page() */ > - smp_rmb(); > - if (unlikely(folio_test_slab(folio))) > - goto out_putfolio; > > /* > * As movable pages are not isolated from LRU lists, concurrent > diff --git a/mm/slub.c b/mm/slub.c > index f62c829b7b6b..ee94baba12f7 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2414,8 +2414,6 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > > slab = folio_slab(folio); > __folio_set_slab(folio); > - /* Make the flag visible before any changes to folio->mapping */ > - smp_wmb(); > if (folio_is_pfmemalloc(folio)) > slab_set_pfmemalloc(slab); > > @@ -2636,8 +2634,6 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > > __slab_clear_pfmemalloc(slab); > folio->mapping = NULL; > - /* Make the mapping reset visible before clearing the flag */ > - smp_wmb(); > __folio_clear_slab(folio); > mm_account_reclaimed_pages(pages); > unaccount_slab(slab, order, s); Nice Acked-by: David Hildenbrand -- Cheers, David / dhildenb