Re: [PATCH] mm: remove mmu_notifier_get

[David Hildenbrand <david@redhat.com>]

On 16.09.20 13:27, Christoph Hellwig wrote:
> Remove the unused mmu_notifier_get inline function.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  include/linux/mmu_notifier.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index b8200782dedeb9..acd1cc41f25d81 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)
>  
>  struct mmu_notifier *mmu_notifier_get_locked(const struct mmu_notifier_ops *ops,
>  					     struct mm_struct *mm);
> -static inline struct mmu_notifier *
> -mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
> -{
> -	struct mmu_notifier *ret;
> -
> -	mmap_write_lock(mm);
> -	ret = mmu_notifier_get_locked(ops, mm);
> -	mmap_write_unlock(mm);
> -	return ret;
> -}
>  void mmu_notifier_put(struct mmu_notifier *subscription);
>  void mmu_notifier_synchronize(void);

The doc of mmu_notifier_get_locked() has a reference to this function.

"Each call to mmu_notifier_get() must be paired with a call to
mmu_notifier_put()." - that should have been mmu_notifier_get_locked(),
maybe fix that up right away.

-- 
Thanks,

David / dhildenb