From: David Rientjes <rientjes@google.com>
To: Charan Teja Reddy <charante@codeaurora.org>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org,
vinmenon@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm: compaction: update the COMPACT[STALL|FAIL] events properly
Date: Fri, 12 Feb 2021 13:16:48 -0800 (PST) [thread overview]
Message-ID: <e4a4bd48-a8a6-2c3a-88fb-50161f23bed0@google.com> (raw)
In-Reply-To: <1613151184-21213-1-git-send-email-charante@codeaurora.org>
On Fri, 12 Feb 2021, Charan Teja Reddy wrote:
> By definition, COMPACT[STALL|FAIL] events needs to be counted when there
> is 'At least in one zone compaction wasn't deferred or skipped from the
> direct compaction'. And when compaction is skipped or deferred,
> COMPACT_SKIPPED will be returned but it will still go and update these
> compaction events which is wrong in the sense that COMPACT[STALL|FAIL]
> is counted without even trying the compaction.
>
> Correct this by skipping the counting of these events when
> COMPACT_SKIPPED is returned for compaction. This indirectly also avoid
> the unnecessary try into the get_page_from_freelist() when compaction is
> not even tried.
>
> There is a corner case where compaction is skipped but still count
> COMPACTSTALL event, which is that IRQ came and freed the page and the
> same is captured in capture_control.
>
> Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2021-02-12 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:33 Charan Teja Reddy
2021-02-12 17:38 ` Vlastimil Babka
2021-02-12 21:16 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a4bd48-a8a6-2c3a-88fb-50161f23bed0@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox