From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80BCE77188 for ; Fri, 20 Dec 2024 21:53:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03A406B0083; Fri, 20 Dec 2024 16:53:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F032C6B0088; Fri, 20 Dec 2024 16:53:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D55B76B0089; Fri, 20 Dec 2024 16:53:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B3B7B6B0083 for ; Fri, 20 Dec 2024 16:53:24 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69B2AAFEEF for ; Fri, 20 Dec 2024 21:53:24 +0000 (UTC) X-FDA: 82916687448.03.C124BCD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 7508D140010 for ; Fri, 20 Dec 2024 21:52:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C05tqGBi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734731569; a=rsa-sha256; cv=none; b=bgZWIzLAsRAC1xIMQ0/gstYgNZ9mr182aaIBRDj7p0R86xGb9r9bvosxtmcGQdCJ/4DQsg ktqxRuW81rmZtKpePe0+4vX2g8E00575v9HuQYc9y8lvYYZ5DPvg/eSIwQrmYBfyr6jUcB e/AEKQsiSrJJyMGAZ8dGwWo+EUokvnE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C05tqGBi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734731569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tzaHhuxKCpnmNHsFinwHJZ/KXJiGt/Icy1kgSSIGmvs=; b=Ub/nwEu65WEnV0DHHHI/HQOimPoRudORsjKL0uej98hoGJH824YKTXQnLI6asaXNtAE3E/ 7xwkU6IXduNR5+tuvMSLy1LRHj/7kSdPWEX6i2sWcyPye9m2OtFHA7meEcpejLG91+BpR0 +KQnldLktGPywS8qBoJ90cquCto1MkQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734731601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tzaHhuxKCpnmNHsFinwHJZ/KXJiGt/Icy1kgSSIGmvs=; b=C05tqGBichRYgUuDyjVfNRlmlNIlJ2wT2n9A6T6VYZIahEEDcaYfSxIvpOAcjCX7zNMI6Q 4lS4ZUtFOCA/ln2C89KcLiVewPMq3c1JtOC1NheffITpoqYAoqago2ylo9oJ9vbt0B8V8E HgbhnIvNi9qEaLB60FNB5QEiVowRVPU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-azi8koNwO3C7rtrDcGOlzg-1; Fri, 20 Dec 2024 16:53:19 -0500 X-MC-Unique: azi8koNwO3C7rtrDcGOlzg-1 X-Mimecast-MFC-AGG-ID: azi8koNwO3C7rtrDcGOlzg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43651b1ba8aso17847825e9.1 for ; Fri, 20 Dec 2024 13:53:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734731598; x=1735336398; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tzaHhuxKCpnmNHsFinwHJZ/KXJiGt/Icy1kgSSIGmvs=; b=pYo41kW7orRMFObm4OBV3m2i7YdtIO8GfEY1eKK3OIODUqvIk8XSLeTwbSym047Aef g0i0dL3gVhGOgp3W+xnCfskm+NWUh+J3/KxjvOU7GbumrH4JJzEmthjludzLiQlTxK9Y S3aYlqL0okODQqQybuvxzIUy+uO9vUCCxHY3J/fp8GmdsueUXbWEGdaWPi1PkgBhrIMD tTzHp8WBTFQy2AsCHkKxQQxD0qzo8akM8BwJIR8c32mlUcu46NXEHMz5PSX3W2GBJ1B7 LAEsFSVleTh+fqTmP+e0gz3k3SSNyd9PTFwAjvxB/UkDfCpG49wvLH0oVVG9ENTcQPpt 578w== X-Forwarded-Encrypted: i=1; AJvYcCUTyA3J/x0F9nvN8HLe6YQrtGiMun6L9GVxc4LnTXYBoOzrURUdpigN24rAKTILBh9o8s4/yPYVgA==@kvack.org X-Gm-Message-State: AOJu0YxRqaAin2KWsibjl9JFsvz+no4Ao6TMK9ayY6queyOvp+AJ2Pm9 W39VSeMzb4CIVbebOLrHP1/bOueEcSAZxCqjbNl30vHaYS/VUfikpRSp+l82Lj4pcY1XxQTAHpS HkUSzDU3ZQbxYpjPuXkLJiXGUFD+v0l0t8WwhjEL8PuYZGZrC X-Gm-Gg: ASbGncvqE3LC1iPTSkM+GLtqeOwKmSm4K+s/div/1f+aUl+6ojT5JkmiC7jiVgdScIj a9N2Op07H6tSsUc29HzqA2cfdJ8ZNEEIEvzH2vi3rasoOSEsicKKRo5KB2MTndyuJPWU2tmlD+4 wwxNysDn6qRcHJ3+iQBSzAV3Z+nN0bQfbbS968SiLTha7xugfHBLD1MzhnyL3GqCHrBjutTSNPR t4Khk5qJImOfbECJvgrYHnLal77YEyfQCpjkOU0XV0nqF2f0/z4O21GPFqNM1z3EJc1z0ZCldOF 8v1O5gvh2kG+MpUS5ZL/UeOr7J05L2ucPNp6twLYU07kdraY72VFXAnHeW8rOzf6leaG7mqOLzC 9FQGumOub X-Received: by 2002:a05:600c:4f0d:b0:432:cbe5:4f09 with SMTP id 5b1f17b1804b1-43671247b46mr18766835e9.4.1734731598288; Fri, 20 Dec 2024 13:53:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3rnv7Ika86NARxVsSo6Jyhm1kPL572OzGaGwSE4AgHQdFlnReiSeXXtpYxqy8HWFihfGrBw== X-Received: by 2002:a05:600c:4f0d:b0:432:cbe5:4f09 with SMTP id 5b1f17b1804b1-43671247b46mr18766675e9.4.1734731597906; Fri, 20 Dec 2024 13:53:17 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c84705esm4992924f8f.44.2024.12.20.13.53.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 13:53:16 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 22:53:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] perf: map pages in advance From: David Hildenbrand To: "Chen, Zide" , Lorenzo Stoakes Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Yi Lai References: <20241205082948.56212-1-lorenzo.stoakes@oracle.com> <65a04f0d-668b-47b6-a532-d1e11ef4835a@intel.com> <4ded2d63-03dd-498e-9810-690a9eff0c22@lucifer.local> <860a1ef0-678d-414d-8511-9695b90c3ca0@redhat.com> <74fd8a75-66c6-40a8-9ec3-d7aa74469755@intel.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ivsDnQFgaJMDTg_vdW-pT376D2NFSLY-b10YritoxFs_1734731598 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ssjcj4zmn3z1ijcgagzzpaynwjz1nixn X-Rspam-User: X-Rspamd-Queue-Id: 7508D140010 X-Rspamd-Server: rspam08 X-HE-Tag: 1734731575-517739 X-HE-Meta: U2FsdGVkX1/BmXxaWQBdrF5TZ39TtxPkprRQQTg1OoM4B8GNwaIH2JiZ3mQ/VpgZH01Z67Dd0AoXRA6QW1Pv0JR9K5UjL5zBZI8g0mc5gIgImNm3z1B1uJr0FupZidRb1Pf6uvrkWvO9GQBnqaybwlXKlOz+w846SfQOAwxqy39jC1Zky2312TB8/DYuS5mJu11uNjhIvGDSoT6KUq8rF28hjj38p3HgOGAn2RJYfUZ6V3BXGTLznDTFMjHQDzrbPrmCkqnGfzyHCvmuL3tkq6qsyRcUwEF7I7CL8Oc/Wd2J/iuznyFehSu9xXXOvtDEcrqvHRK4beJtes049VsgHlVGiGhgDYPUmuMSXd8ZC2yz9JW284o92LNgaXId9T9aIg2CWo4lHpDu6Ftx7JGQKH6/GUI3hSnUWMiyOfhesQbEDNh6AnnZuz71Lbaiwm1ZowXKRyko2kC/gzQzusdv9fKCA7w5Dwslq3PN5TIyI60Il2ghIzHN+NcV/qhxsEsZR+xCu1fgFh3Vi4VZ8jwOjNlW5PqfLqxZ2oiokMzLuhIyXaEUPg9/nDadhWRrj7mYZtbEI3oS1TRPL8x6Hp4OSBzlU/KDsfL5772+ViEhyxHp0RI+wi+/PGnupOUigsjuIydVbNZbmliV0EvwATQa68f/2o04dz7RpPljBNM0+RGXvLFb69m8zmC7pMM5tn48HKrqdTo2C9OuLbCPyft1iCxlyKvGOgGFGSum+G8afR5KR72VE0YSfHdF03TTK8w678tutCRkzp+4Zyck7m+1Rw2lJ+1JmAZVj5r/q267fKDekr7dfneE9zASXz9UnnThhTr9XKg7V5bPPDx6TOtchGLAQUAtZkobu1lwsdr+UXHifJy7avbGHNe+JcHiXTOw8ZYkhoxzM1GYIGakfrBLMrbVwDw4WBQYFhBKPK00RQr+gPN1aMjMjHHGpRn+PXnsLzXF1RAu//K83U0IJyw VGbgGcGC 38O8LXbk+IbRo9mQKccxrMuOCakIjjsmeMENlRm8sf4KCFPBU/zfoNKU5P7br/tLJtKWTbamtB44jutrrAqyEDUQBePhXjfbGJG8Qalu6CPcnHi9XFi+yseRdMImo9CWOFhx3N/86ABQsSTJLTS1LgQbqbYYSpqkEaZiLpjCWNN9KC7rya7yyxsmcGtYBCPV9FQdJLCbyNXSkuVz7h0+mpB+bJBW4w0IJqLA4dTMUQdTtPphmNCHAVt/loBYfCl1CpD4UyIbALVrgcyxCGNPW4bEDRNkqxV01Y1heRCaXwb8WoNarzTSw6ILVQ678b/tn8oQF9X7EHILzZ73AnweKcvy43ypr4wcBbe2P2dXCnVR2UHvRvi8b5x/BtKnOqwo9M1x49vGnOVnQMC+f4dV2xfrKPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.069437, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 22:29, David Hildenbrand wrote: > On 20.12.24 20:36, Chen, Zide wrote: >> >> >> On 12/20/2024 1:56 AM, David Hildenbrand wrote: >>> On 20.12.24 10:31, Lorenzo Stoakes wrote: >>>> On Thu, Dec 19, 2024 at 01:17:44PM -0800, Chen, Zide wrote: >>>> >>>>> With this patch, it seems perf tool has some problems in capturing the >>>>> kernel data with Intel PT. >>>>> >>>>> Running the following commands, the size of perf.data is very small, and >>>>> perf script can't find any valid records. >>>>> >>>>> perf record -e intel_pt//u -- /bin/ls >>>>> perf script --insn-trace >>>>> >>>>> >>>> >>>> Hi, >>>> >>>> I'm on leave (and should really go back to relaxing :>), returning on 2nd >>>> Jan so can't really dig into this. >>>> >>>> But I tried it on my intel box and it 'works on my machine' with and >>>> without patch with commands provided, so I'm not sure this is actually a >>>> product of this change (which shouldn't impact this). >>> >>> Zide Chen, can you try with and without this patch to see if it >>> introduces the issue? >> >> Yes, I re-did the test on a SPR server, and the result is same. Without >> the patch, it went well; But with it, "perf script --insn-trace" doesn't >> show valid records. >> >> This time I tested it on the clean 6.13-rc1 tag, base commit >> 40384c840ea1944d7c5a392e8975ed088ecf0b37 >> >> Also, with this patch, running tools/perf/tests/shell/test_intel_pt.sh: >> >> Error: >> The - data has no samples! > > I just tested it on 6.13-rc1 vs. 6.13-rc1 with this patch. > > Indeed, there is quite difference. Below are the main parts that changed, only. > > We seem to be recording data, but maybe what we record gets corrupted somehow? Huge parts of the new file are full of 0s. Either we are mapping the wrong pages, or reading from the pages (via PFNMAP) does not work as expected. -- Cheers, David / dhildenb