From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67E0D68BE8 for ; Sat, 16 Nov 2024 10:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D7B6B00AC; Sat, 16 Nov 2024 05:40:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6436B00AD; Sat, 16 Nov 2024 05:40:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F23C16B00AE; Sat, 16 Nov 2024 05:40:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF5906B00AC for ; Sat, 16 Nov 2024 05:40:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7AACCC181A for ; Sat, 16 Nov 2024 10:40:28 +0000 (UTC) X-FDA: 82791612624.21.1D666E8 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf27.hostedemail.com (Postfix) with ESMTP id 19F144000D for ; Sat, 16 Nov 2024 10:39:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=vMWL22t0; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731753480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lSXFKM+ARjNBrckMO4jvpnEJoLVPjxN4kzAqYuwUUFc=; b=2aZP1GlQNp/WjLnMApSkpSFMQtpruQhFAuqFWtCyRosoFZNxUCffHN4jimwQxuqj4C1f3Z l/lecX3bdge5Nd5rlV1R//nNhVHjpQkD7F65LdS8+8wbtA4dWI5EcAx7KUPvPpsKEZplLr rKeC9GBcD6ZUulcZ5wHMp3cJSOOCnZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731753480; a=rsa-sha256; cv=none; b=L9XQWUXwhEZ4mtUlyYxoJQj+zSRgLTWpEgpto+jonZbsCENl2Ok5S4yoH5BZ9pkx8FYz8t kRFv8bDPuk2com2Hwafvc6/LaGQtcfiBP6hcPVVy0wf38swkIxl+d4Tcx6pizlgEkgco22 wE+ObN0+K6ovr2AOrchLbihrccdTfdc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=vMWL22t0; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4315839a7c9so23100495e9.3 for ; Sat, 16 Nov 2024 02:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731753625; x=1732358425; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lSXFKM+ARjNBrckMO4jvpnEJoLVPjxN4kzAqYuwUUFc=; b=vMWL22t0iPJZEAJrvXUN19JfNH8AT0aohxjFeqM/fMA5uvied3QSIrNQsP0iI3n5PX VV1yJ881worX5a4Ao/RySMKhvDFARYZvTn0nuWBkv/4jxnX1B4faOYM2XEQG5PxutpDd VgfOiQB6k+7IhhhdbkG7eOf+tuGWHoTQILsVPUXnBYpVZI+k0SwLJLsBe8ch0tDnS8Rn 1zJtYg+sfctlgKT7mSyxW7d71/RWgXEENwGEed9NT1K7r/1wOju7Nc2wawrWr9zqSqhO 3L6MayOEYUopt9S8X7Dm2M/CVxhQ9mYsB6OhM/cOuFpbJzv+saGVj4TMiDl9DQoeeE7C WnEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731753625; x=1732358425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lSXFKM+ARjNBrckMO4jvpnEJoLVPjxN4kzAqYuwUUFc=; b=iteXV9TLYs4p2rXIjdE/Zpee9TWk9UuIgYlXRy3zbGedetmAsEhET9U2Y0lJbBbV4e EgEUMojyhN+kKkLeLcqxfD7rxIrCjn8uSdsu25nlFxcQwooGCl5HW2Bww5f4IAXHz/lK oxqzrmnSsQULk/10tM9iH3+8k0DWNCEM+srpqL75QlFP6wWER154aWTcEun2sP98qzYX +q3T091I0E4L5FaDTRzJIfKMU5nRUvRuH3G0hV80R2z9DS242FflASCJJcyGePQBie/4 3Yx+ieE+BygDlOIHy8VsQJJOyinvV1m22XR6OK0umMDflFyNjLC3p9oa18ypIo+9FjkE oLHw== X-Forwarded-Encrypted: i=1; AJvYcCWY83lenaMSSZ7zLV6xaXko8cogbiTCDqbNjf19lnQmsXuKQCSgr+qa356GRNC/pUq5e45h7zXRww==@kvack.org X-Gm-Message-State: AOJu0YwoMyjq2yIwKiHHhKEIZPFQ2DDwV8C0QvKWAu1xb+OBbN4KiW+R BLmtYFsL4oGVtXlTt6d6n6YSA9G1TkDMEo5H0U1rlqSt3eHL83G+zhwGUkyQM28= X-Google-Smtp-Source: AGHT+IH8fBA+4s5F3P6X/kjn5LT5A4plOne9CKmDoZ8QUK+uLzjM3K0QAglApJbsapoZYtb9Ft2RHQ== X-Received: by 2002:a05:600c:1d1c:b0:431:4e82:ffa6 with SMTP id 5b1f17b1804b1-432df78c5b5mr46184285e9.24.1731753625076; Sat, 16 Nov 2024 02:40:25 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da2800absm87243245e9.25.2024.11.16.02.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 02:40:24 -0800 (PST) Date: Sat, 16 Nov 2024 13:40:20 +0300 From: Dan Carpenter To: Christophe Leroy Cc: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() Message-ID: References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-5-911fb7595e79@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 19F144000D X-Stat-Signature: rcxibbgfe5s6sou54hxpwyim1umhjjjs X-HE-Tag: 1731753578-135652 X-HE-Meta: U2FsdGVkX19DCEAUxPab2/nH73OHJ6o+g2zzC2UsXsKp7++90nPFzL6tVnFmDZyvgntO9HX4VldhsNMS7l4emoIBnEwkrCAuXfuzYYHKfPU6TSzLOHh9giO4ez7ImBQs2tt9PvDb7iLBOaGQUXZN6xLW0C27r9VkQj41chLwMJ4BjMuLB3hqnJEHj+75dPdp39iKxVvzYhrEVxc295oCFN8T3cgyx2EAEgiBueNCnh1JuQhMQGd2Q+F9U1dMoBINkFVeRUHKqQ/27KHmZbgF2utJkVpt94KCljN07txrUfWDnUpn1jarsRhY7tDZ9jxc78kM1rOfyLxEulsiG4p0BPrZTnFZRntjzVSB02ZblCguHh96Lnlb8qkkyEK5agQn40OO0JVlltvy663YKUfcs0fpSvnx286apMmVDSBp9B8cPPHyJerokAURjAMviLZDOu110M6UsyIdmrsPOIrc52Ebwfs0VMD+gXaG6FeQiVZ2DIFHlkwrQVdGu4IP1LBGKXQSXK4f1SHDvFJ3W6/doNCS2lARzMFLp9MBrQMz2YzwGWqy0vUpWizQK8lEv1Y7JjJxuR8r0AIjgGik9IzC6F4r9J0u3m0kNHDERBN4BQc1qskZkCg4hC4YRm4eamF3RF9SwOM6vZ2O7ZMhgHpHht6gyanqKoACHGWTa80TUs366JzOEJhBEOytT5f3vxQA4dC+TkfRK40g47gvjhOacILJW3plCeXVPW8YpTJVtwT6nP/H3NW12+EhpnBGFOHdPS8HPYQysmPl7yVBkRw/wvsMcQZs2ygcu3F5KXaKcPWKchg54OPCJJ7uqYGpE2Blk0uVHkmFvwmDndrN4IE+DdOp2WvgemUfTenp5A3IlXaRsN3ff53TDIXittpNZUaL0ndk6BhEnbImBJoT38ya14piOM7bHWfb0OPwRrer2LjB0DOKsIZvZcnYKL52Koak3OhcUXvRE6fFFyrVIZV thEV7/fN cgJ+EKdxOjeif2OhaciYLgqfQJTdl8L4N5VRpITzJega0+mfV+oKOF+et/KPkl5D5KhW0wTyg+32uIDitDpLQ5afytmmCQXxHPahwmGLCxurM+snZvXqG1Sq4zZuL3FZ9VNomaZfAPuvVR7vS8i0e3WY2FjT5hM/PisLZ1JIcuu1aPcZ5ZmSsE53a/Cd73ykq+b/oRH4eXIHHbfkDqqz5OK0/XKqjfb2d+xhyM6Ye5N+bXavi0kEWSj612GtywDe3NhaCDrS8g6NMWTqSg6gPGV+ar6Aspfqh5M6sypPdiZ+N/18dKq8LkPJXWjZ/9n2zR+9ckWvcQC+AAW3g/aSGh6ptRCCxwo+8JgkP+nX9kUGzI67OkyHDeIXT90CUHmC2OvRvNQeJm54FqlRVGTDyuPqHkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 16, 2024 at 11:06:55AM +0100, Christophe Leroy wrote: > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > > index 9e297f88adc5d97d4dc7b267b0bfebd58e5cf193..9e8086ec66e0f0e555ac27933854c06cfcf91a04 100644 > > --- a/arch/powerpc/platforms/pseries/papr_scm.c > > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > > @@ -543,7 +543,7 @@ static int drc_pmem_query_health(struct papr_scm_priv *p) > > > > /* Jiffies offset for which the health data is assumed to be same */ > > cache_timeout = p->lasthealth_jiffies + > > - msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000); > > + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); > > Wouldn't it now fit on a single line ? > Some maintainers still prefer to put a line break at 80 characters. It's kind of a nightmare for an automated script like this to figure out everyone's preferences. In this particular file, there are some lines which go over 80 characters so sure. Earlier in the patchset one of these introduced a line break that wasn't there before so I think maybe Coccinelle is applying the 80 character line break rule? There are sometimes where the 80 character rule really hurts readability, but here it doesn't make any difference. regards, dan carpenter