From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D36E3C7115C for ; Sat, 21 Jun 2025 04:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763C86B007B; Sat, 21 Jun 2025 00:27:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73B3F6B0089; Sat, 21 Jun 2025 00:27:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 651106B009E; Sat, 21 Jun 2025 00:27:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F1F16B007B for ; Sat, 21 Jun 2025 00:27:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C693512205E for ; Sat, 21 Jun 2025 04:27:42 +0000 (UTC) X-FDA: 83578124364.19.0342895 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf04.hostedemail.com (Postfix) with ESMTP id 7E1C340008 for ; Sat, 21 Jun 2025 04:27:38 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=L0UyB8+L; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750480061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B0gYkZDG3902TE6IDALp4GeQ2/n8W9XRX9u/h5JaMIo=; b=OKQ4LQOA244idk529PG819yBP2YkSonToNAzVyL7T8Que3eO4u6S0l39KYheRB3jMJcT4o bZh++xzXG26lv50FSeNRkJcCbCerme/OVyyLa4ToIgod66YbIItbMEIIpVyOKQouiWs4co MqxLxKb5+rE6WBfsssfoCaQLIZTwqoQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=L0UyB8+L; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750480061; a=rsa-sha256; cv=none; b=zMZ32eMoToJUq/qrgO8PxgJyFB7O4GnB8GoZHB5pi7u3zUSm0qv3KQtAJfPx6ogwW02ex7 1Xd2OFXH/ke9PhGuSvrCIoO96yZEnX2H9k/KXteY4RX/BGhqmqFTZtudIz6E1+iDWDewQZ L9jejcckvAO1bCihDWvorU4p8qQ+pN0= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750480053; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=B0gYkZDG3902TE6IDALp4GeQ2/n8W9XRX9u/h5JaMIo=; b=L0UyB8+Lfv1z2gHyrRlUuFCLeRAHSYWzvwVudXiJibBSrF1Y83HUEu0st03t1WiIImZ6nN/yorPzqfo2GZFS2RvZ8268WgH9w6ZOlyMUnWQV/iKupa7zu7bKnUEpmiFO3f0RUYF9Q2IaX8WcMNYax2RnJez8172Bg/d74nn3tLY= Received: from 30.32.92.233(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WeMrdqU_1750480051 cluster:ay36) by smtp.aliyun-inc.com; Sat, 21 Jun 2025 12:27:32 +0800 Message-ID: Date: Sat, 21 Jun 2025 12:27:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] mm/shmem, swap: avoid redundant Xarray lookup during swapin To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Hugh Dickins , Matthew Wilcox , Kemeng Shi , Chris Li , Nhat Pham , Baoquan He , Barry Song , linux-kernel@vger.kernel.org References: <20250619175538.15799-1-ryncsn@gmail.com> <20250619175538.15799-3-ryncsn@gmail.com> From: Baolin Wang In-Reply-To: <20250619175538.15799-3-ryncsn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7E1C340008 X-Stat-Signature: fmjrqcefuejn8khi48osuhzywbfqbwp9 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750480058-463395 X-HE-Meta: U2FsdGVkX18YF81GLimyjiia4tk6pYAPBalSX0CO+E+30G1i4GtbAsYz+3nJTAqXfXsCfsRWpTX+4eHGsjHlBIZkxWYRnEOmJZ1rA7qXq7e6Rds4iyOvdLLLoUiqCoyYfUFVSm2tjA8yMvZnXMO4Ptv1Sljnv+GQnJhkLWVp6lYeZx7lR0lPPm6rhwZg0+qlzAuJnIzJafjQc3W8+eC/Xahu0tVZlOTIGgnxTDaHiU/H9TA5x/eD4WoW3U8DDUehE92a1QlS70fqWzC5HmThZ6XDd11x6F5ON6RJyX/XXZtVmRIjAkjfJ8lz1BVhwO8cGjinmGZlkctVqEBrg2C1HuD5zQHbpenQyJuvrtuV96INtZby1i6KJH39Qqdr6OD8oS6qbg7yrQMMBpwUCOXp+hKTGe5QN1FU4EsXlRSzJIOqL2gwuJ09OjeIsJpkos0L6BCXmLZzjXLqeGdMOVxPcTLWd3Y3UvMwOxfrsU+UKMENOQVjRQ5zUHc2MTODI7ZyAiW777xCfONUz854Zzr+gddpsVD53H8vVf2E0elyGnrMMjbG5djpN45o+PZow0KBa9cJ4I5tmQQn6F5HxBME8ui86kWJCHXELgOLNjkRf0yjBKYQXLl+MEWWkMqPKD5Gtux9UDXa6N9uQlq9Sl9h+mZC8+q4evENps0j+VHYQJdfb8TLjoIxRMwBY/vYjh5LBIigRo4xdGy3y30dquCq/hPmxA2XCmFFxEi71t0++jedEzDO1y1LxmvOV4GouMBcPFU07yWcPDSL4X35dFTaaSLVIvXC88wRBvU0RSd/EGO3UK5Dw1Q7/uyBj2OntlkjnwQBA1qFyaaiezah0EWgOn9fKXuRCUa8wRShiJNQbozMVhxW136YYRfYBtlknfqkmbeD+c+KiokLIfIsGbCS2pYPqQFm38eLdzFIJY3eZas9fJRKqsAVUJGDRY+fZAJ200izM9pNyQ60G5+cL86 gV0dWNaO SXGZ+rbsxOBXvr0YGVHrtOuG3xX0Mh3DH9dQlBrlZWWXF60vsiDAgmogqABy5C4Yc5bsD+Pc4DFmsDnYeLLd76Ru/c1+9w+oEW0sexGzI5OOSSLYPvhmktEyeGTC7qwoJDevgNFrl9tFa5MXOdS/k9ddr40JlFHd2FKUc7m68cFyIQyIlUktZmxA2vPvfYm+WVH7KhjvN0ZoUM5tGv1vmDIAub0y68T03gTal3PFaS7FHWBFqeewmN/1oPKaUQ20sVTjttiVacBN7nLzn42gCQM8hSaUVm34eEbXt2OyJ1qi3JOoFAr8/ZFSrtk1YEChkFxjyc2ZXFHElDnbf5lfEm1d2OfvKNM59NUMHHWApIXwAoZ/7uI4zYbeV0Sr72hiJI/CqEpLSWy4wy8mbe096W9uD5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/20 01:55, Kairui Song wrote: > From: Kairui Song > > Currently shmem calls xa_get_order to get the swap radix entry order, > requiring a full tree walk. This can be easily combined with the swap > entry value checking (shmem_confirm_swap) to avoid the duplicated > lookup, which should improve the performance. > > Signed-off-by: Kairui Song > Reviewed-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang