From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D48FC3DA79 for ; Mon, 15 Jan 2024 13:26:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E9C6B0071; Mon, 15 Jan 2024 08:26:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81EE66B0072; Mon, 15 Jan 2024 08:26:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E6366B0074; Mon, 15 Jan 2024 08:26:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5EAB26B0071 for ; Mon, 15 Jan 2024 08:26:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 311521404A9 for ; Mon, 15 Jan 2024 13:26:07 +0000 (UTC) X-FDA: 81681618774.30.FEB8511 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf12.hostedemail.com (Postfix) with ESMTP id E0AE24000D for ; Mon, 15 Jan 2024 13:26:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705325165; a=rsa-sha256; cv=none; b=2yHszbqrDFJ4bP9c8TEj4LcUkxxUM00+J3e3WJR1I8YI/y5b7p+85Aczzp1l2QpGwuoFTy xLE/oRHuj4AWRqQWVuxlBPkOZf1HDK2bbpzN673TMwT1ehDRx+h/GQ9dymCG6SoxilP3Wl k+rRYFeqkwfHSKcRg6WWMEjMjNoL4wA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705325165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7WgmtnWhD17haAYQnBluAy6uAcslCoF4QURqxUqam+s=; b=hA46hxuFPHWIyHDpBKfw/XLiiju3A7Yg17pjTJhwfivMFYIYuRFQIg7auwL9RWYoq20qUM 6Sq9amx8B+hcvNTW64IKw4WiJq2T/GX2vMCD/QSj9I3ROVRrskoyA1fvwSNA8aAVY5IUzm TeQscz2yTBlh6wQOp4iCdZrw1vkxWU0= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TDCYR4CzfzWmgG; Mon, 15 Jan 2024 21:24:59 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 85B5A18001C; Mon, 15 Jan 2024 21:25:58 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 15 Jan 2024 21:25:57 +0800 Message-ID: Date: Mon, 15 Jan 2024 21:25:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v4 0/3] minor improvements for x86 mce processing Content-Language: en-US To: Tong Tiangen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi CC: , , , Guohanjun References: <20240111135548.3207437-1-tongtiangen@huawei.com> From: Kefeng Wang In-Reply-To: <20240111135548.3207437-1-tongtiangen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E0AE24000D X-Stat-Signature: 767g5df8b5zy118mjxk9saqjunrceus5 X-Rspam-User: X-HE-Tag: 1705325163-898614 X-HE-Meta: U2FsdGVkX1+Yqin/4sHgRw73ZJZxEq1jGfOKl9sYoIMQbZsdqN+F740bQk8Pj9CRXclntD/rK5k0UcXKnSHl271S7fojUZ0LjNIbaFDrs4LVCDhc3lP/kFNDn4IihNKYOT6goC/VqMebBs6gnm8VUIS5JLB9vO5YhYT7ISlnqVCkNGpShrvOJa+Mg2HrzzafI+c/qXOlvHTHCqmJlPRXmstgL/vM62Cvyig0LvGPt9hc3RCafTpeqC267V1rrQgAye2zxhhAO19BY3ZE0geYZEiWUI0HZ2LYHk4Gk1X8wvg4I5sSomYCfnr0fi6qGZ9j4Rzm1HKqSwLjV+7c5p4cvcUWvksLPxAk8/MvukmO3o0v2zNglvfjXBimjgcSpXbPYKgOn/T3680nO7iOH+h95KuhaXizNBEcOkWT8h9hTU7fgx2XdYhW3+liFCP12uraWA5TjyRGvs0UCIyo+1lDQDuT47Y5EGNLUBEcNfICr5eldumsCC3Yi8jXHXQMfSa5jOgp8uCfQhSIFyhjcWslWnlAP5w60wFOn4QxITd3D9xR3k+jU8UwJTZeHdlrjL0+LgwrXbEJKbjMedYc/yl2lyHroHFZ9g+Qw/XboO5AsyOCM4Etje+NChshBj/+fmM243aPv1Z+EW0nC36txL3/el5gq9ziwF80Z12URp32KErRAWsA+lIZk245OHqeFTBzIDGbeQ8uhxmJgIRc9mHUAkdl1o23yDwnC6w1S3wpMBa1USW8sCVUuI90wXwbP0Gt8m+dehCYpYX53sjktgdOucZXLKkasvzOe5ShlQ4xO6uMpjI22z1/0HAiE1+GInplU8NEo2a+kn9aqBYbB5TpI/13PIopTNm/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Borislav and Tony， On 2024/1/11 21:55, Tong Tiangen wrote: > In this patchset, we remove the unused macro EX_TYPE_COPY and centralize > the processing of memory-failure to do_machine_check() to avoid calling > memory_failure_queue() separately for different MC-Safe scenarios. In > addition, MCE_IN_KERNEL_COPYIN is renamed MCE_IN_KERNEL_COPY_MC to expand > its usage scope. The patchset is a followup[1], as Borislav suggested[2], we firstly cleanup unused EX_TYPE_COPY, then rename MCE_IN_KERNEL_COPYIN to reduce confusion, could you give us some comments about it, many thanks. > > [1]https://lore.kernel.org/linux-mm/20230526063242.133656-1-wangkefeng.wang@huawei.com/ > [2] https://lore.kernel.org/linux-edac/20230602160138.GDZHoSYsWoPAinMszk@fat_crate.local/ > since v3: > 1. Rebased on linux-next tag next-20240111. > 2. Delete duplicate commit references on patch 3. > > since v2: > 1. remove redundant fixup type EX_TYPE_COPY. > 2. rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC. > 3. update patch3's commit message and the processing logic of > EX_TYPE_DEFAULT_MCE_SAFE based on the discussion of [1]. > > Kefeng Wang (1): > x86/mce: set MCE_IN_KERNEL_COPY_MC for DEFAULT_MCE_SAFE exception > > Tong Tiangen (2): > x86/mce: remove redundant fixup type EX_TYPE_COPY > x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC > > arch/x86/include/asm/asm.h | 3 --- > arch/x86/include/asm/extable_fixup_types.h | 23 +++++++++++----------- > arch/x86/include/asm/mce.h | 8 ++++---- > arch/x86/kernel/cpu/mce/core.c | 2 +- > arch/x86/kernel/cpu/mce/severity.c | 7 +++---- > arch/x86/mm/extable.c | 9 --------- > mm/ksm.c | 1 - > mm/memory.c | 13 ++++-------- > 8 files changed, 23 insertions(+), 43 deletions(-) >