From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5110BC4345F for ; Thu, 25 Apr 2024 01:09:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D37306B0098; Wed, 24 Apr 2024 21:09:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE73B6B009A; Wed, 24 Apr 2024 21:09:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFD3A6B009B; Wed, 24 Apr 2024 21:09:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A285A6B0098 for ; Wed, 24 Apr 2024 21:09:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4B93BC030F for ; Thu, 25 Apr 2024 01:09:51 +0000 (UTC) X-FDA: 82046272182.06.C33B9D8 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf29.hostedemail.com (Postfix) with ESMTP id B5C6212000A for ; Thu, 25 Apr 2024 01:09:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714007389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FOQpHxyUBk7f+BWNLHrIwsBwm4SZQanPPHHdilwCxLw=; b=bqT9kaiLoSbdGJhjDlyOwbCqjYXA3+O0cbiC5gCVErDWwi7I4SHp5N+NbZgzq6Z2A/g/jg S4v/txTBqFhusL+iualTFNWBrroLw5cAkT9XF2T2NWWieyusAXmInuV9O1fdjR5BzH3F+m HMESIsladyNzettcN+z1He/tEpo6DzI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714007389; a=rsa-sha256; cv=none; b=7cFmpgIz4IOswFLXCtBxwZnVzgGjQcsmfyBoh9c0JVInbvo4dJ0L0E8tlDB9dvCuHbgEUm w5yCn4PC8auktmgTd0A7/EZ5DehbPX4Tm2ytnWkDHYJUT824wdLns29miPn91PhaDkI3Rq QWzDy9pQS7Hd+jxf6rglhGTtV+ITZFM= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4VPyRD73h0z1wr57; Thu, 25 Apr 2024 09:08:40 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id D7A321A016C; Thu, 25 Apr 2024 09:09:42 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 09:09:42 +0800 Message-ID: Date: Thu, 25 Apr 2024 09:09:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add more readable thp_vma_allowable_order_foo() Content-Language: en-US To: David Hildenbrand , Ryan Roberts , Andrew Morton CC: References: <20240424140715.5838-1-wangkefeng.wang@huawei.com> <2e878f93-2b45-401c-8ee1-00338e22866b@arm.com> <6febd97e-20ca-4396-b7a4-c361e7608d8f@redhat.com> From: Kefeng Wang In-Reply-To: <6febd97e-20ca-4396-b7a4-c361e7608d8f@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: B5C6212000A X-Stat-Signature: 49qxck7b46zqzq3xnp3juidf8xioni4j X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1714007386-325310 X-HE-Meta: U2FsdGVkX1+nz9DY/LaybDs9Zz6hoJbwSVXAHfOxZMxZXZv8IuGC5LqBIL0UP8/Rxx53qW6XMFvHT+Y8c3c5U5yunsGbnaqUG/ROKBNCUYagjqcE/zWJMg1JI4+9tbzUJqa0F7LcYDIz5ZMX0Mk39vcaIpqGp2MZOkzvtS4a2Oi7SaaUsyEPR7pBTN6YHZvq96s12CWxIPrJVHsAyFHxIPynP0N2TzrfSFVeTOzjq6u4dWXg1/jBRB7U+RTaalUlcAgazhxtFaZONR4TY/Wk+EhoAS/9yMXLX8KI5Dot2waPdpGCFxScdKYdmlJckcL8UEfGs1Viw2ATPt9eMXUBAB/fSmUdD+x/qg1XDD2BMWOqIZ2g5eXRX3ZRJNzWSHNpx6aeL3nKsxZWnq1O3IlFxkW1Xd1y4xE8M9CL8qpXn2tMqaoYcVcmu2VREP4dTytvI+r9ofJugk2KCYUbIOZF4Tbn6Q9Xf9lvgg+SNDhaQjDg0ZGzhNXV8osg1TWLN7dqHc7KzzfJ02NBgQJInGc2W/QF9su1cqH9/uCEuYQH8Z4g6mFG73ZvMqTBUhrEGNK+WqcKx9nGISEZ6unkTobsRMz6Gc7Z9SdeNiCjKH0XAog4T1HMR18+n8WownO2Q+1NkY4B/2TT2Xr3h/jGj528VWaMr2df/oO01zJdkhopz50vZAFC9curW1qcCYf6DGAkhvQiZHwGbSnBHwfxlkFMgNaQ/uLMUdIok0E6GBfLLoOh6NlUz4GkXWYD7BDqHXZP9wf/nyObVkOBzG0IXugRLb7YtfTE58UGbgtmmvu9oegZc4TBLQvFEKlJA6IuegK948QV97XO/o9Sf22lDeAu13wRB0Q36c9GdKvWIABVvPSnl4xRJkqFdebIgmPQhhRd29mEyUr8FyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/24 22:58, David Hildenbrand wrote: > On 24.04.24 16:05, Ryan Roberts wrote: >> On 24/04/2024 15:07, Kefeng Wang wrote: >>> There are too many bool arguments in thp_vma_allowable_orders(), adding >>> some more readable thp_vma_allowable_order_foo(), >>> >>>    thp_vma_allowable_orders_insmaps() is used in samps >>>    thp_vma_allowable_order[s]_inpf()  is used in page fault >>>    thp_vma_allowable_pmd_order_inhuge is used in khugepaged scan and >>> madvise >>> >>> Signed-off-by: Kefeng Wang >> >> Just one nit below. With that addressed: >> >> Reviewed-by: Ryan Roberts >> ... >> >> nit: Personally I'd leave the order as an argument rather than >> encoding it in >> the name. It's likely that khugepaged will grow support for non-PMD-size > > Agreed. > >> collapse in future. The first part of the name >> "thp_vma_allowable_order" is then >> consistent and easy to search for all variants. And perhaps "inkhuge" >> is more >> precise? > > "_khugepaged" or something else that people can actually parse and > understand. > Try this before, _inkhugepaged is a bit long, so choose inkhuge, but I can't find a better name, as you and Ryan suggested, thp_vma_allowable_orders_smaps() thp_vma_allowable_order[s]_pf() thp_vma_allowable_order_khugepaged() Thanks.