From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CB4C4345F for ; Sat, 20 Apr 2024 17:25:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6396B0085; Sat, 20 Apr 2024 13:25:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9978B6B0087; Sat, 20 Apr 2024 13:25:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8854C6B0088; Sat, 20 Apr 2024 13:25:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6987C6B0085 for ; Sat, 20 Apr 2024 13:25:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BBE7D804F1 for ; Sat, 20 Apr 2024 17:25:11 +0000 (UTC) X-FDA: 82030586022.19.6C3BFAE Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf01.hostedemail.com (Postfix) with ESMTP id BCDE740006 for ; Sat, 20 Apr 2024 17:25:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZVDDcPQX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713633910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0O5Kqv+lWIEjkECM3hCos+L1qfRqovCo3P8M8cYHn5A=; b=0b3NKiuzqL6Ko8fXZmY/ZIJNvcfpO2LUwWS/IHMHFRa83libqYtotwtAJheOdnnDAw24CF d5kbrlVknXNpgiNCWMyioJySfoPDA5adp0pRNasHHUvezTm/AL5Rn7hGRUg6P5lG1iW1pQ I26IXS2Bh07ZW+xs+B7RuwQC5dVJPAA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZVDDcPQX; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713633910; a=rsa-sha256; cv=none; b=TjzRb5kbT/8gIfirlF8KadpThWt5P3MsZWDd+0gEeti+XPSojrr+HUS5hC3L+uiN3pSXsn YXnJdA7H92XSxb7/gFIbX08b9NjHoviXHHwRLe8/GKDza8B1mJbXjxSJwEuH8Na5B0aNkv f6Jhj+a+uQC+dINHtD6c3p8vZIRgMNI= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713633907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0O5Kqv+lWIEjkECM3hCos+L1qfRqovCo3P8M8cYHn5A=; b=ZVDDcPQXo3ncZ5TFGRKOizmo6NwmIYZWh7lTT4DKWb1xJ7bauKWMbRI24iB2QCmduiwHmv A7U4osxkoa58waEHg5ZS7usVnPq8MtJ8zJAZRwsq+A0+4zWDGJGmW8VYKtmPUbSERX6oPc WiJwtPkRwQtM9CYnDxoYRAO8BfW0tdw= Date: Sat, 20 Apr 2024 17:25:04 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: shakeel.butt@linux.dev Message-ID: TLS-Required: No Subject: Re: [PATCH] memcg: simple cleanup of stats update functions To: "Johannes Weiner" Cc: "Andrew Morton" , "Michal Hocko" , "Roman Gushchin" , "Muchun Song" , linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20240420132326.GE1055428@cmpxchg.org> References: <20240419233949.2326100-1-shakeel.butt@linux.dev> <20240420132326.GE1055428@cmpxchg.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BCDE740006 X-Rspam-User: X-Stat-Signature: 6y3of5iaeddkj8tsunk4xbt6mj5hnmu1 X-HE-Tag: 1713633909-112707 X-HE-Meta: U2FsdGVkX19rqOty4kNXi3700V12vfh1Q4m5n8oYDwcq+caeYRdwpuJ2sYmiKN+CpzYoeZ6fkr8sJ0lZ7cFjRR00mTE1IxBxsgcuxZhxcOWM96Cmj+V9woPsrd++z/8RlZXTV2d5r1vXcYC/jt1l9Dem+6d6ShrgfYkb/o5vv5q/qJW5EZsVIz51DP71p56JzuhtY5B540oN+mqKlS9URdpAZHASDTNHerCK0KUNHlwvaB5f2dYsWVpr1yIKbN6hq1rqPevJ4PmqrDngtOkmM4aid/cn0vPFMGMmQlD7AHQEhmPz/tP6FkpJf1p3UHwfK4FYB/WiJ5V6uSgInp2LNFZs6AEOnGst63M3MZEhAZuxFB/rvumz2eI9sw4WIsKV3Ib9XOVnMODHBkkK+xCQ3tqdLXlSbgGYsSBEC5sSoVaRpXKlmtCuwj1nKLUN9WFqCfl6ij5REYOq2+G7GVhnBHPagP2g3hp1Sq9qBmECF8qvUiPt4RrfncLpUS+UMBEb7lgxjBGN9YgVI9e9XumM8jYSTHuqHMyhXUJbfDBJphfQ+nLvAWncfX41n3A3mKwvAh1PkBDK9TAjt4F1j+ocWqcaOwHuzm8nEBXxTd6JjCgcSJ4RAteQqBdj4Mug2JzjpHGbElhNvvEnKriPCf1IDiHZNty4BWIS+Xrdibuhm3yakUm5RF7keBLEY0QTu1jPYoI2QjDrKFxElMLgTrYEwGjyNfkLX3AvRgYTERQLaEz1nzBaIWtoc1wBRMhURV0avtgkAmNyMV9zNqPJXslaaixdgD2aMcxt7bQNJ/92v2WhMhyFdmWndGehYGamwSOr9LdePqAtAiBMKmIISZelyd+NakvWUJGV74MS17gjEwItXUnHCOiLkjwgmdAsn8Dm+CgrZDXB8oJroxVlX+FF/IlO76tu6UV2OPNpDYq1Bba+6EPpEndbosvI/O6orLQpXlsvLJ261OmBAiq2d3I baHL5bJ9 lyarfYMSuAbftZCX+lnFyjQZIS1CyDPpVnO/vntdCIHiqSZ3AG8EYBXIQTmDXsVXmatq8NbH5gjXuY8i08YV61WJ/UlOJZwUePH5nT6Zw0F+ZBZ4Ne5CSg3JS6ltjDux1I/jkxXm8tEioFSR+VebUSoG36w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: April 20, 2024 at 6:23 AM, "Johannes Weiner" wrote: >=20 >=20Hi Shakeel, >=20 >=20On Fri, Apr 19, 2024 at 04:39:49PM -0700, Shakeel Butt wrote: >=20 >=20>=20 >=20> @@ -2983,10 +2984,6 @@ void mem_cgroup_commit_charge(struct folio *= folio, struct mem_cgroup *memcg) > >=20 >=20>=20=20 >=20>=20 >=20> #ifdef CONFIG_MEMCG_KMEM > >=20 >=20>=20=20 >=20>=20 >=20> -/* > >=20 >=20> - * mod_objcg_mlstate() may be called with irq enabled, so > >=20 >=20> - * mod_memcg_lruvec_state() should be used. > >=20 >=20> - */ > >=20 >=20> static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > >=20 >=20> struct pglist_data *pgdat, > >=20 >=20> enum node_stat_item idx, int nr) > >=20 >=20> @@ -2994,10 +2991,12 @@ static inline void mod_objcg_mlstate(struc= t obj_cgroup *objcg, > >=20 >=20> struct mem_cgroup *memcg; > >=20 >=20> struct lruvec *lruvec; > >=20 >=20>=20=20 >=20>=20 >=20> + lockdep_assert_irqs_disabled(); > >=20 >=20> + > >=20 >=20> rcu_read_lock(); > >=20 >=20> memcg =3D obj_cgroup_memcg(objcg); > >=20 >=20> lruvec =3D mem_cgroup_lruvec(memcg, pgdat); > >=20 >=20> - mod_memcg_lruvec_state(lruvec, idx, nr); > >=20 >=20> + __mod_memcg_lruvec_state(lruvec, idx, nr); > >=20 >=20> rcu_read_unlock(); > >=20 >=20> } > >=20 >=20 > Best to rename it to __mod_objcg_mlstate() as well to follow the >=20 >=20naming pattern for whether caller or callee handles IRQ toggling? Will do shortly in v2. >=20 >=20Otherwise, looks great to me! >=20 >=20Acked-by: Johannes Weiner Thanks a lot.