From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D436DC27C79 for ; Thu, 20 Jun 2024 20:44:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14A6D8D00E3; Thu, 20 Jun 2024 16:44:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D3158D00DB; Thu, 20 Jun 2024 16:44:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCAC38D00E3; Thu, 20 Jun 2024 16:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B54A68D00DB for ; Thu, 20 Jun 2024 16:44:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 614021A0604 for ; Thu, 20 Jun 2024 20:44:21 +0000 (UTC) X-FDA: 82252444722.12.C9A9126 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 13A4718000C for ; Thu, 20 Jun 2024 20:44:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hX4U8HkZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cRZoRbFf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hX4U8HkZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cRZoRbFf; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718916254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UUY3ZboMLKJz1TS6iQDuB4Vm9DuxvmRHXybUstnJPdw=; b=WUYTpA4rhTgC5KRtfzxXS9WGD/IQpnwcXUUHwiL3z5uY3rroKdFae8QDCEY9TC8nuW2lHp cKOrEo1BTcgT/ZWMabrIK7TdJ1yMyitsbfJQ3OMppYA0ddowlAxPV24EJTOdGaNxEJwQmg 31ZO4aZ6YstaWJUf8UhZZjKA1GcG/B4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hX4U8HkZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cRZoRbFf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hX4U8HkZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cRZoRbFf; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718916254; a=rsa-sha256; cv=none; b=CaSRGTeQ/cZJjeByUIif0IpqFV83KJ3tMA17Bt3liMzOexJpmZBOkfgzsEbQ6EQSRF0Cme xi6exbc+iIyxLtJcQ/uQ3n8I7l2h8KhZ23FkmdCd8uQdksj2MghGcCpbvh4SJbWpgjwdap IPIODmOxOfVEW20Xrs67i0Q49mmQNeI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2B60A21AD7; Thu, 20 Jun 2024 20:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718916257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UUY3ZboMLKJz1TS6iQDuB4Vm9DuxvmRHXybUstnJPdw=; b=hX4U8HkZSlBtaV/yZ/8e4outtpguZjKgiHnQXLTArjuFSiE7PizO2Elrm7QuJxjuQjmWnO fK9FIKMKFHtnWDyfN1tI6wwB+PjCXVwi/O7r5yykws10zuHLncT58EBfrlesc1i8e98UOe +styDjZg8zvJh/67hft9h/gm3PvNV6U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718916257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UUY3ZboMLKJz1TS6iQDuB4Vm9DuxvmRHXybUstnJPdw=; b=cRZoRbFfeYVejp0bZ3QNHndIWWctZQrOueKJQ6IqaSc6avropICd0xZKPS/aW55rDGpCvi OIa4RIq60FGnGaCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718916257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UUY3ZboMLKJz1TS6iQDuB4Vm9DuxvmRHXybUstnJPdw=; b=hX4U8HkZSlBtaV/yZ/8e4outtpguZjKgiHnQXLTArjuFSiE7PizO2Elrm7QuJxjuQjmWnO fK9FIKMKFHtnWDyfN1tI6wwB+PjCXVwi/O7r5yykws10zuHLncT58EBfrlesc1i8e98UOe +styDjZg8zvJh/67hft9h/gm3PvNV6U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718916257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UUY3ZboMLKJz1TS6iQDuB4Vm9DuxvmRHXybUstnJPdw=; b=cRZoRbFfeYVejp0bZ3QNHndIWWctZQrOueKJQ6IqaSc6avropICd0xZKPS/aW55rDGpCvi OIa4RIq60FGnGaCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E87831369F; Thu, 20 Jun 2024 20:44:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E2FcOKCUdGYRVgAAD6G6ig (envelope-from ); Thu, 20 Jun 2024 20:44:16 +0000 Message-ID: Date: Thu, 20 Jun 2024 22:44:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Content-Language: en-US To: Kees Cook Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org References: <20240619192131.do.115-kees@kernel.org> <20240619193357.1333772-2-kees@kernel.org> <7f122473-3d36-401d-8df4-02d981949f00@suse.cz> <88954479-01a3-4bbe-8558-1a71b11503f8@suse.cz> <202406201144.289A1A14@keescook> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <202406201144.289A1A14@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 13A4718000C X-Stat-Signature: 6sdi1askd88b6reswjc89jjtqmwo8ofz X-HE-Tag: 1718916258-754706 X-HE-Meta: U2FsdGVkX195HQ+ikOCJEGcL50R4GV0coRiehvBfW3bOeEwJ6lqKGlgUDbcmx9MI+vTOriCDwSumvB9Uxb37uaN5IlRGzkAl+ABL9I7ZYPwgcMOYTQ+gor9emicfEabTIS/rh+Ea06GvXasr62L0WmdMExpgIfvixnIM/4NDJ6NyjmlM2KIDPBVFA5tf99Q3rwTY0yNwkYO1KceRW9E9Am448+4o7SUVPzQXsVcFgAZRMRrJAWsTJj1gCYWDjOjiknMK7AJj0GqYwcXS4WV4N8Dnkxx8toc7MNCgm52x4pNTSHoGuHlchh1LXVUmweutvMkzvM9ZZ6fPuEgjgbM05YaORsUMlcRkMmAw/TsJxIBUJBjDaE05Z4492mNeAWxn0aIKXmTbQKGzvr4L/r4K0Os8ATQjyuM04NuesBCmes263S44PRRHKY37ubBsSl+N37YL0YHBvesoXSGnsnHVu/0NoKAMO1NhPFLRWLwuAokp6yEvbivFiIiTnH1i8X5p933naTdnLrBO50sNmGX+5hJAqy1cO+3YeNf31Hr4qUYJmSttgo/I/vV7AojOrViTzpUMa/krbq1Ehzpz9GI/z0n4GceZSl1Gc7rHualMGRSVRQl65cIuGYPkaGLwv/dxuNgn2uxq2WYs49F7rdHFrp+Z3XaiMQwsA2CxiFm5BRWgvzxvfjJRlTD1HQEze+R1Q8aymqjp5b8eLJvbklMSo2ejYB1SrkGPPthK/CRVKrGb/TlBBrwPQHu1G/iXJwIJKSzXJninmHM2kEQKnAT+0yMCGju+yJYl4eJVmwuZ1p4P/k8H8zANEywzkkRBzcU+FE5wINR+Ziiyav/7KJfVFfH2QGbKuU3n61n3Lb1fopBuUQbYn7zUBDymWrLe8NediywzIkHWHbrAYN6f21NAdr3PJTGVKMzwUSwARuKqhCnjPkyhTGTZP3fGWAaXOjLrlEVUYfQlOk1a5yyIcum wXTKtbIT k7g8Z/vJs1zwJ1gGv0cRAb1aDyGZY53JK1ZwcdmCdPhanWlN38EUtuwB7hNETSK8vkDd/1/1HxBUc0hq1L06C3nG/luJSkNkc8Wiwg4RlblNzdFFOZwa8ZSgjK1b3HvvloSfOlF1TVP1TTiQciGiQD+pGHSkl10II5iccFVOb0w4ZuUEbjRJfRtWqTNzjK7xZ1vT0ClsYScVhec6PToIfTu7oatfh78k1B3o8/anG/QPCyP+Zr3CcRXlf98jZQfkNPF19rWU7gwAdHIYCXuP5upCYGtc3LQlllb2eEyZpYRnje5IsXjDQO0euTuVsJULhkhhwTvMlf2MmFDGOp5g1K46msWfdamNsQwGLNDEZBC/JTgQzcpoRYUGDlphw8KmUNuAe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/24 8:46 PM, Kees Cook wrote: > On Thu, Jun 20, 2024 at 03:37:31PM +0200, Vlastimil Babka wrote: >> On 6/20/24 3:08 PM, Vlastimil Babka wrote: >> > On 6/19/24 9:33 PM, Kees Cook wrote: >> > I was wondering why I don't see the buckets in slabinfo and turns out it was >> > SLAB_MERGE_DEFAULT. It would probably make sense for SLAB_MERGE_DEFAULT to >> > depends on !SLAB_BUCKETS now as the merging defeats the purpose, wdyt? >> >> Hm I might have been just blind, can see them there now. Anyway it probably >> doesn't make much sense to have SLAB_BUCKETS and/or RANDOM_KMALLOC_CACHES >> together with SLAB_MERGE_DEFAULT? > > It's already handled so that the _other_ caches can still be merged if > people want it. See new_kmalloc_cache(): > > #ifdef CONFIG_RANDOM_KMALLOC_CACHES > if (type >= KMALLOC_RANDOM_START && type <= KMALLOC_RANDOM_END) > flags |= SLAB_NO_MERGE; > #endif OK