From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D152C77B7F for ; Thu, 11 May 2023 13:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F15D56B007B; Thu, 11 May 2023 09:15:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC6796B0080; Thu, 11 May 2023 09:15:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB53A6B0081; Thu, 11 May 2023 09:15:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CAE216B007B for ; Thu, 11 May 2023 09:15:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 32FF01A06AC for ; Thu, 11 May 2023 13:15:30 +0000 (UTC) X-FDA: 80778020820.20.35809DD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id B4A9C1C0050 for ; Thu, 11 May 2023 13:14:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683810854; a=rsa-sha256; cv=none; b=1s5fkTLYZgTyiQ7+U1RORPIClMQuGSjFki32nieLK2EbG9XH6xQOI+b2eqXLkXz18RRKBo xqtrTmULHGrPDr2wcX0DJ97Di1LlgfiUkzTrezmgO84cuMtlDoZNK7Gu2asKSfi+gC08uF TqZDNrvx11o8njExxs4gYAqVONdb51Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683810854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMlvKh+OUOmCHdPrXAVyzXozerfiv35QSwKp6YkAtQw=; b=Mm1ZfQ5OZ/gcFTWz1YUQHh2/KUQ+3MuhruHOG/yiyMQuZLg8sI17m2G/qMBtcTTHwPrJhg stF41YwxumJ4Kyp6I4edpkRiBp8Adrj2D2YNOfgs+LbpI5UN3UERc6qT+zQwAvCg8i+IWa ZnnNKXpVsIq5Cryw9iIM4DnZ3BhwzUM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F832113E; Thu, 11 May 2023 06:14:58 -0700 (PDT) Received: from [10.1.34.59] (C02Z41KALVDN.cambridge.arm.com [10.1.34.59]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D65933F5A1; Thu, 11 May 2023 06:14:12 -0700 (PDT) Message-ID: Date: Thu, 11 May 2023 14:14:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 1/5] mm: vmalloc must set pte via arch code To: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev References: <20230511125848.78621-1-ryan.roberts@arm.com> <20230511125848.78621-2-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20230511125848.78621-2-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B4A9C1C0050 X-Stat-Signature: xcoyye85yb994j1m9kqu5w9nccqa75rt X-HE-Tag: 1683810854-5613 X-HE-Meta: U2FsdGVkX18kxaNiweFGTOGcixha+akh3o3/lPckz7aCuxdu845rkYCdBVbRJIt51Jp0Phb/XUiztZj8tii8+Pfy0K0Cmd6bMH4eX1sngTGXMHUVd7Kc5ZtMz+RdhnJ9/TE8yGyUJNyul8hATdZrBYwqbLDlHsjbX1EGzdgYdvT2qVV8Cks2EdJ1gY6+wxJQPxp0NIKn3S5zqFgSiVO4B80CbRWCPepH12SoAxdYBJ6Mn54JPcXNw7VDqUPPmkqM8QU207asgOy9aC8xoXk4zFz1B3lxoGcUImXUxIxRybMPsR78+79BM9vb2Dy3y8jsdQ202K3C/IXCZKYdfKKSAE9wEbLm5mAV7MVS1XY57h7Hq0+C/DYtCJe5+N3aKzGW1uJeLqTU9uhEILRedpudglyR11ehAIXUnfgDwoIZMGTSJK/nuVvGylYlKVrZPy8OjiksrtKlYdXUGXkgJ1z3pt+qXXXK+Jo6NK7MHSA/qy9707lcGIym3Got62XiIHkRQs5aBMQITRZF5GsHUFbSVbItbp92Ety5Z2Q5NbYeWJCJLYPkqB1wj33aB1sscclTbN4cE/ruegFuBaPXPWBqyaq3+Q+cpbZRHkOAUmw09g0ARONkTMosvrQuFvo2B5sxlEaCxDUMtYNqGr1ALV80uOV84IVFwjmC7r2sIiVD7qZ8sk9HpSmAqM4wmokWSGLFC1jRe0Vjs+N0PCHvLPVrLEI3trUowGn0yDjngSMfEV3Zo0plLkJ22G0zCHJuKFLX+NHqTF+ONBMkxNUK4oulhT/9q08mCVXbZHppx3QdOhwnK6TuQQCXJTgikTBAmRoASEAqb46RB7/fMNzQ89ML5ny+QouHSqbQWoGNVT9tQ/p+Tk7Web3OfQ5KuNfnadhRU2zBOHyY3c3zTjAAHmwISGC4saX/WkaDnx++dhVZShjI6IDsJuP6aaPrgPObzD5ebUKshZZqsqjZ1ob0qCl KpGxwG4f wkMa7fl217p+/o1ErySejQJ7gld2H4Nf7QMazp+7jm17af8X3z3npfrYJOnp3AX+95NJu+gBYiLeSl4su2b5ncovgkwIPcr6IxigJWou1GRs0CnxkNZt5NNJWje4ox9HJSTg2qIhtuk19vel7tlR43Q5l4fcuSWC9CmSn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: My appologies for the noise: A blank line between Cc and Subject has broken the subject and grouping in lore. Please Ignore this, I will resend. On 11/05/2023 13:58, Ryan Roberts wrote: > It is bad practice to directly set pte entries within a pte table. > Instead all modifications must go through arch-provided helpers such as > set_pte_at() to give the arch code visibility and allow it to validate > (and potentially modify) the operation. > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") > Signed-off-by: Ryan Roberts > --- > mm/vmalloc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 9683573f1225..d8d2fe797c55 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2899,10 +2899,13 @@ struct vmap_pfn_data { > static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) > { > struct vmap_pfn_data *data = private; > + pte_t ptent; > > if (WARN_ON_ONCE(pfn_valid(data->pfns[data->idx]))) > return -EINVAL; > - *pte = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot)); > + > + ptent = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot)); > + set_pte_at(&init_mm, addr, pte, ptent); > return 0; > } >