From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4583CC25B07 for ; Tue, 9 Aug 2022 14:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9C06B0072; Tue, 9 Aug 2022 10:55:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A788C6B0073; Tue, 9 Aug 2022 10:55:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91A1F8E0001; Tue, 9 Aug 2022 10:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 81D0A6B0072 for ; Tue, 9 Aug 2022 10:55:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56F561A0F93 for ; Tue, 9 Aug 2022 14:55:59 +0000 (UTC) X-FDA: 79780354038.09.F81C7F1 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf18.hostedemail.com (Postfix) with ESMTP id D1D141C0166 for ; Tue, 9 Aug 2022 14:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660056956; x=1691592956; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/y03tk8Vi+r4ivUpOIzB1qW/+LcKMkgnnn79oUwijQA=; b=QaX8Y5wgvgho4K6ecAwaYs5Hd+7nHUeEomsnI3UcEdT6FhH8+SC/3pLe 87BR9cJQUBaDe9fYgpzIH8XZU+yCS79M3pDvEoUli9cem6SCnBRgzRvdE qujcEyiy/6w54Qvfx0RyXjGstDldHCxX0BasOu7uc/PwiUV/PqI7Ix07k tI798S/3GwItVcQcFK/9382m+45+7gLY1nvati+85azVaAj9dweaFsZTC /Z1ATx4FERWMJegAmpwyXwrNdVM8UFBsDsNaL7eRNxdthWk2HSe1c8jTB 1ZoIl8vR7WPP9O5adufow8vye8YGB9EZ1mNbx8dvV3lCF7uBbLVTbVPTv g==; X-IronPort-AV: E=Sophos;i="5.93,224,1654531200"; d="scan'208";a="213252217" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 09 Aug 2022 22:55:55 +0800 IronPort-SDR: WKfWuOfJ4mQnOl+BtyX4NwFaTa0dJGrDBMxYi25bQ/lMMpe7hm5TZUUKtkxdsekAfLar2Hogl1 lKF4j5s2g1Aojc9045R2IjzshlFFJKJwf92J8GNMRR+r+2A/f8tWxr4GacRtbvljRSMlLbqDfG 06RUhUWsWi4u6Aq0Ah8YDAYyXT0r3v/HlOyaAx07IGcBzAS/QuvpmHcwWoJT0h99YG2R125F/M PGD5kaAl4Zp1HpkSYlNUMb+PWz13Yp/9mAQiY06bMi2eTJd0RtGiX2jDn5zDYUlHEiTcX3LaFc vVon6eq3qIQOUghbTZQecd4f Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2022 07:11:36 -0700 IronPort-SDR: tDNVzC8XlSEtD3Jw2WZ0FlaKa+0MMFICsHSRGHhh57+5sU5NBfIOhU6aWtPJRgMQwCqZTCEB8A MxVDwynUDmmYh6idgWOpv1gAcdh8SkejSK5c642q7jrAHChQMghGTCOcw6idiMGoG3uA6uX+hC m/fnVBR31OX+2xS8JW84Qw0r9a2ocd9KcrMcy52YDNjPZDh9/B+tWKHT5jEjbs6JFt5wb8O6Cr KkRZvr8k2ct6CfbSe/ZKPXOKR4MwBR2N1ghqIWVGJtOwyF7xqscBMt3p/2rargTrh6Jv2nJUe2 v/A= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2022 07:55:57 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M2GNC6TfBz1Rws0 for ; Tue, 9 Aug 2022 07:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660056954; x=1662648955; bh=/y03tk8Vi+r4ivUpOIzB1qW/+LcKMkgnnn7 9oUwijQA=; b=YNEtop4DprzBm70dwiE9MmTa4GQNcwnbxPG71WIfihcSK1PM3+b TAD4DKNN5x12SFJeUKZuQpYh9X1OSo+OWYqSxhD7oFdIUjlGU13CchNadVF6Pesi vqXjsvbL+dFANoTuNegdW+eLcJ10jPxb9xbod0GJ1W9gtgLUqnqAIgMs8YCaTTMJ pjxH/aRKEbycQXRxr551JPdzF41eSfa6f8pLAsJTZVG0Gq5DhuXolct0pK8Ss9B5 SRo8uhFdyQzwrvk9B0cZXtF2ZQI1MawhbVsuk9+HaIXpQjlXLNQH+27yNlJ19ppx eIf7DOMoZ8X0r/H03JNTkjaLFjEtpZIyMPw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7DwMTVX6kS8F for ; Tue, 9 Aug 2022 07:55:54 -0700 (PDT) Received: from [10.111.68.99] (c02drav6md6t.sdcorp.global.sandisk.com [10.111.68.99]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M2GN94KBrz1RtVk; Tue, 9 Aug 2022 07:55:53 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 07:55:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Content-Language: en-US To: John Garry , kernel test robot Cc: Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , linux-ide@vger.kernel.org, lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com> <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660056958; a=rsa-sha256; cv=none; b=QvzW3K2IAt9ViAx7r204XQaNXzj9ziU6GNG9zD+w3SPD56ihqouE3x78o8JkEsSeHxHG3s THSoky99KzON0L+q+hrXWjS3559uPJfg3XUfZd5a/4ebCGpHREoXmvVievoQOCo/ZpVJTG eQ+6T86rS0gjenuC9tqqT0BW5W/bU/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660056958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PbRM1gMQkCs+OZSBWJfEgw8sgJ653mG91VQqp0Ic9Y=; b=N6i8ReL1xV8IRjtTrzmI+4TRqXcIWtAh81ruDBqun4ke56zwnGAezyYy21UTqGPwCq4vMY 1ozCB+0/xP4BGaZGNc0H4P1dmy9CEPsIQDQ5c2/v9bZTW4E67497Hx+WxU+JEG1EMQW8s3 9Kd8qmKS8AZde3Is0LQjvibqOfWXYgk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=QaX8Y5wg; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=YNEtop4D; spf=pass (imf18.hostedemail.com: domain of "prvs=21358209d=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=21358209d=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com X-Stat-Signature: 5atxbqsh4yrquab89gpdxhiau9xuw16y X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1D141C0166 Authentication-Results: imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=QaX8Y5wg; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=YNEtop4D; spf=pass (imf18.hostedemail.com: domain of "prvs=21358209d=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=21358209d=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com X-HE-Tag: 1660056957-484198 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/08/09 2:58, John Garry wrote: > On 08/08/2022 15:52, Damien Le Moal wrote: >> On 2022/08/05 1:05, kernel test robot wrote: >>> >>> >>> Greeting, >>> >>> FYI, we noticed a -15.0% regression of stress-ng.copy-file.ops_per_se= c due to commit: >>> >>> >>> commit: 0568e6122574dcc1aded2979cd0245038efe22b6 ("ata: libata-scsi: = cap ata_device->max_sectors according to shost->max_sectors") >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git mast= er >>> >>> in testcase: stress-ng >>> on test machine: 96 threads 2 sockets Ice Lake with 256G memory >>> with following parameters: >>> >>> nr_threads: 10% >>> disk: 1HDD >>> testtime: 60s >>> fs: f2fs >>> class: filesystem >>> test: copy-file >>> cpufreq_governor: performance >>> ucode: 0xb000280 >> >> Without knowing what the device adapter is, hard to say where the prob= lem is. I >> suspect that with the patch applied, we may be ending up with a small = default >> max_sectors value, causing overhead due to more commands than necessar= y. >> >> Will check what I see with my test rig. >=20 > As far as I can see, this patch should not make a difference unless the= =20 > ATA shost driver is setting the max_sectors value unnecessarily low. That is my hunch too, hence my question about which host driver is being = used for this test... That is not apparent from the problem report. >=20 >> >>> >>> >>> >>> >>> If you fix the issue, kindly add following tag >>> Reported-by: kernel test robot >>> >>> >>> Details are as below: >>> ---------------------------------------------------------------------= -----------------------------> >>> >>> >>> To reproduce: >>> >>> git clone https://github.com/intel/lkp-tests.git >>> cd lkp-tests >>> sudo bin/lkp install job.yaml # job file is attach= ed in this email >>> bin/lkp split-job --compatible job.yaml # generate the yaml = file for lkp run >>> sudo bin/lkp run generated-yaml-file >>> >>> # if come across any failure that blocks the test, >>> # please remove ~/.lkp and /lkp dir to run from a clean stat= e. >>> >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> class/compiler/cpufreq_governor/disk/fs/kconfig/nr_threads/rootfs/tbo= x_group/test/testcase/testtime/ucode: >>> filesystem/gcc-11/performance/1HDD/f2fs/x86_64-rhel-8.3/10%/debian= -11.1-x86_64-20220510.cgz/lkp-icl-2sp1/copy-file/stress-ng/60s/0xb000280 >>> >>> commit: >>> 4cbfca5f77 ("scsi: scsi_transport_sas: cap shost opt_sectors accor= ding to DMA optimal limit") >>> 0568e61225 ("ata: libata-scsi: cap ata_device->max_sectors accordi= ng to shost->max_sectors") >>> >>> 4cbfca5f7750520f 0568e6122574dcc1aded2979cd0 >>> ---------------- --------------------------- >>> %stddev %change %stddev >>> \ | \ >>> 1627 -14.9% 1385 stress-ng.copy-file.op= s >>> 27.01 -15.0% 22.96 stress-ng.copy-file.op= s_per_sec >>> 8935079 -11.9% 7870629 stress-ng.time.file_sy= stem_outputs >>> 14.88 =C2=B1 5% -31.8% 10.14 =C2=B1 3% stress-ng.ti= me.percent_of_cpu_this_job_got >>> 50912 -14.7% 43413 vmstat.io.bo >>> 93.78 +1.4% 95.10 iostat.cpu.idle >>> 3.89 -31.6% 2.66 iostat.cpu.iowait >>> 4.01 -1.3 2.74 mpstat.cpu.all.iowait% >>> 0.23 =C2=B1 9% -0.1 0.17 =C2=B1 11% mpstat.cpu.a= ll.sys% >>> 1.66 =C2=B1 37% -1.2 0.51 =C2=B1 55% perf-profile= .calltrace.cycles-pp.f2fs_write_end.generic_perform_write.f2fs_buffered_w= rite_iter.f2fs_file_write_iter.do_iter_readv_writev >>> 1.66 =C2=B1 37% -1.1 0.59 =C2=B1 25% perf-profile= .children.cycles-pp.f2fs_write_end >>> 1.51 =C2=B1 40% -1.1 0.45 =C2=B1 26% perf-profile= .children.cycles-pp.f2fs_dirty_data_folio >>> 1.21 =C2=B1 49% -1.0 0.23 =C2=B1 33% perf-profile= .children.cycles-pp.f2fs_update_dirty_folio >>> 0.88 =C2=B1 56% -0.8 0.04 =C2=B1111% perf-profile= .children.cycles-pp.native_queued_spin_lock_slowpath >>> 0.14 =C2=B1 26% +0.1 0.25 =C2=B1 28% perf-profile= .children.cycles-pp.page_cache_ra_unbounded >>> 0.88 =C2=B1 56% -0.8 0.04 =C2=B1112% perf-profile= .self.cycles-pp.native_queued_spin_lock_slowpath >>> 3164876 =C2=B1 9% -20.2% 2524713 =C2=B1 7% perf-stat.i.= cache-misses >>> 4.087e+08 -4.6% 3.899e+08 perf-stat.i.dTLB-loads >>> 313050 =C2=B1 10% -18.4% 255410 =C2=B1 6% perf-stat.i.= node-loads >>> 972573 =C2=B1 9% -16.4% 812873 =C2=B1 6% perf-stat.i.= node-stores >>> 3114748 =C2=B1 9% -20.2% 2484807 =C2=B1 7% perf-stat.ps= .cache-misses >>> 4.022e+08 -4.6% 3.837e+08 perf-stat.ps.dTLB-load= s >>> 308178 =C2=B1 10% -18.4% 251418 =C2=B1 6% perf-stat.ps= .node-loads >>> 956996 =C2=B1 9% -16.4% 799948 =C2=B1 6% perf-stat.ps= .node-stores >>> 358486 -8.3% 328694 proc-vmstat.nr_active_= file >>> 1121620 -11.9% 987816 proc-vmstat.nr_dirtied >>> 179906 -6.7% 167912 proc-vmstat.nr_dirty >>> 1151201 -1.7% 1131322 proc-vmstat.nr_file_pa= ges >>> 100181 +9.9% 110078 =C2=B1 2% proc-vmstat.nr_in= active_file >>> 846362 -14.6% 722471 proc-vmstat.nr_written >>> 358486 -8.3% 328694 proc-vmstat.nr_zone_ac= tive_file >>> 100181 +9.9% 110078 =C2=B1 2% proc-vmstat.nr_zo= ne_inactive_file >>> 180668 -6.8% 168456 proc-vmstat.nr_zone_wr= ite_pending >>> 556469 -3.5% 536985 proc-vmstat.pgactivate >>> 3385454 -14.6% 2889953 proc-vmstat.pgpgout >>> >>> >>> >>> >>> Disclaimer: >>> Results have been estimated based on internal Intel analysis and are = provided >>> for informational purposes only. Any difference in system hardware or= software >>> design or configuration may affect actual performance. >>> >>> >> >> >=20 --=20 Damien Le Moal Western Digital Research