From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629C6CD1292 for ; Mon, 8 Apr 2024 07:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C36926B0098; Mon, 8 Apr 2024 03:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE7CA6B0099; Mon, 8 Apr 2024 03:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60226B009A; Mon, 8 Apr 2024 03:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 894A26B0098 for ; Mon, 8 Apr 2024 03:35:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 154C01C05E5 for ; Mon, 8 Apr 2024 07:35:33 +0000 (UTC) X-FDA: 81985554546.11.ED7B899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id C807A80007 for ; Mon, 8 Apr 2024 07:35:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IUzk4h0V; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712561730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d3GySbiGeorRsqZIt9Ijfkj1iWt87wQlFpIRAmiy934=; b=FIPRQ9ahV8rU39RlX50gGhu8pVf2c6XxE6pllKgWOq65vPVQoP3B2i/nxsb6Epe6X+GiVu Ay/vwDVuOAJc3BgOvqCVO4VdHMMbmGNq+0SZHvaufgIroLzJMi1J09rEjI+bbY47lZqf8S kc9aHu2yws3JemJ9KtMhPhpUj/RP1CI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712561730; a=rsa-sha256; cv=none; b=GtCga4e2vBqChGMX/4+dErcCl/QTqDOMM0Ofsvknr6mIkVI8bFO739khsxT+KEUxfy2+R/ 1FM8RmpmMaN3Q097/MKJdtm6DABW9CvTn5k9Imm3V6jSl0EhKe+cfH3hj+V5W7o9fOC1jZ Rv1EL9Nh37F4DTx2oLkcpwmAERAPbOE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IUzk4h0V; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712561730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=d3GySbiGeorRsqZIt9Ijfkj1iWt87wQlFpIRAmiy934=; b=IUzk4h0VU9CSrp8DWtoJ4joj57cmy/s+R0349d19QkeiCrHjt8hbzG1y5Xw8HrSG+2Rs8P K31x+NNB0MTYnQ78JWuFGnEcCJ8LjtmxinV9/mBaX/QECfsnYnbHZf2hSpUwX4HX6WFP8E Bwyqx0V5I04Vl6jNGbRrxgqDFjSIfIY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-yMg6oFF8O2mgB_zxIcLM8A-1; Mon, 08 Apr 2024 03:35:25 -0400 X-MC-Unique: yMg6oFF8O2mgB_zxIcLM8A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-416661bb85bso3563215e9.0 for ; Mon, 08 Apr 2024 00:35:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712561724; x=1713166524; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=d3GySbiGeorRsqZIt9Ijfkj1iWt87wQlFpIRAmiy934=; b=l2NXFk8jIgC/HdYDZoJdjzhzkf9Tlu/silZkLwDujUInZpYnKdiV+ocCrFpL+IemaN 0HE0x6TTUnp889QMMJ+h+q35MMtqOJEzOulKhokmgFgELwvF/tUV7c8VY9zE/jFGDmBd dtmjnJKqcwkaDO8RrnenWcI0yzrz/Tfd8BxnohPvYlpVzLgXGBv+szz7nUs3AomTeksw G10YGd/yoMmU2KorEGDHMrYo6hWV4s2KeI9ri2uXkLEk7Sp7tz+x4StVpV9o/GQRsi3B wXxqdZpWDyHA0K9zZF846WsVQdrnD6HdzhKJSy204EKcBD9i7XN6HzN9/dY2iPYGYbg5 hwOA== X-Forwarded-Encrypted: i=1; AJvYcCUhA8g4NWuJEEaU01d6cywj1UdJbjMZkjqoGO0LiXMFKmzzjSTYWe46k0yncjouxyVkuvCAcYL3KWVycI5fkONOlhc= X-Gm-Message-State: AOJu0YyGf/5051eqz2nr8aay58d25kDXW78Yz3ntSH4OLIQXup3t7/do dhiHrUZg4qw093j5Nyxqc4aeDpdq228YfYFiqcZajSh+KP1zpFbtWx2H6E2vqf7MJUcKv3t3lZO pa/R1L5m7EkMp1zYz1+ukmRFOX/qdUdZd8awE2HBxImJlvNzX X-Received: by 2002:a05:600c:4ece:b0:416:3365:b9c7 with SMTP id g14-20020a05600c4ece00b004163365b9c7mr4607152wmq.13.1712561724289; Mon, 08 Apr 2024 00:35:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjZ9VCYB4AUQb07oKhGHJ1GEtWztGeMgSbalcZWN1jAdx1q+6Zl+lVrclpocaKQsTfHoR1hQ== X-Received: by 2002:a05:600c:4ece:b0:416:3365:b9c7 with SMTP id g14-20020a05600c4ece00b004163365b9c7mr4607141wmq.13.1712561723921; Mon, 08 Apr 2024 00:35:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:1300:9860:66a2:fe4d:c379? (p200300cbc7181300986066a2fe4dc379.dip0.t-ipconnect.de. [2003:cb:c718:1300:9860:66a2:fe4d:c379]) by smtp.gmail.com with ESMTPSA id l35-20020a05600c1d2300b0041680911b0fsm1228331wms.30.2024.04.08.00.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 00:35:23 -0700 (PDT) Message-ID: Date: Mon, 8 Apr 2024 09:35:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mmu_notifier: remove the .change_pte() callback To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Sean Christopherson , Andrew Morton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-4-pbonzini@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240405115815.3226315-4-pbonzini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C807A80007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yia44xafhxa159mnxr5ip1j5i4anpcdt X-HE-Tag: 1712561730-355153 X-HE-Meta: U2FsdGVkX1/v86sevD6aQdO1seJia5MbWMc/ZaLZuEsL+x5UZ6EsnYw8gdLtB4lYtQwTOJhvjW3M+qpToCLgJAC6ySwLp+jEcZDr4nQZBj3BYeMMjqe61HvO5FDadwkdfqC2S9j7oG3s1wY65wj/87Ka+J6dA6T6L2QBis/t2FYEt5A0i2vsXNmw5+n4n1hbT8y11iBFI43Cv02pDnbodXsEbe+eM0PWayNXn52TGT25+RuG34JiXrsXjTVcgA48Qnlmr4eVU7DhSee4e9UyB8erB2UiyWPzjvw3U3Z3qXsiPSsgf6MbdNp28j9rInrtudVynoVjj6xGcMpHN0FIIkfs7x2BgG7B3+1Ye26n4RWOOglunLjTz3xYELP7w62Qzd/QfK5TtxLYTohpi6lYJ2Jg6AhtVJQ02PmRYm7h6ky9kAcHIw7t3TdHIW15AgbLxnaMSAccm6zRYju4HQ85FCBhkPgujxBY8kL1DCwQb75uMJUQ28xnwReGCJriyWUwVFF5lIFmBpljZnAf2+VNDfiCHzEy8sfrLVFh1Xff2YxBr8fFVMyjLsj0aYcvDARP9LzO7BMowfYBQRLdCifd6LvFgP+Ht4I2qb6rd9SP6NN5gDotyH9d7dc5tnXPvyNac5vVvv1RvTh+OChE/tvNEZaK+LwfL6s5iD8qbtUeLBOIaf2n3wa99CMywhhp9kSIzR1hmsFQgYmCKhkMKHw+/F4RahQLguqfOLvj+pnFeJoXogov0gIFMls5twHmMixpMkWh6XnLib4u3npqbBWWJXpHMjMh0ToIGyozfQlMYFrXWsORywkPAa7f90zCfRYg/gCvGNo7j3YD4k+2zrP9MVy9F93k9Rlo9UbUq+UGdXZIbwOfpFpEltBzYs/QbYmkt9N+E6ufssZ+B+BsvnztA/WA/OlGGg0ilWTUZOlySvLrFDnQ7Ar8HrJjF6QcWtSmS4NI8yaW+YKke/mTgHe AZsJcQQc 6otdldx5bHda7zOipLEWMv4o+kb7TafTMTbGPJPuRpQrW0j7irovi1Jr9i93+bBUoAVEuiYN/mHadSAKbD802WiP6Y2uJqHcp+Zlao0mM3ratQU5cgMOlhuK4pI3iiOr80QUyei9Tawa1iqtFmcIdpTJaoF2dXVsvt+Ny97KSWIeJDEPXZR2y+wS8M2wBDbrO6AncnsvdGUC2lvfusHHfzHxe6NXkGcTqpjpfJXJrGYqFX6IsQY1xanxfu9Yi+/p+/DZBzp68VEUWd9zM042mlYKtAEL04YO1ZOJOCj1qH7s3YIdcLJb8FXz3sNOO0xeJfeHuwBr7rf3BifymiaME7yB0TVCJ6uN/h5fCc1nsdRzmCtN/ukVdxutpuX9JknisDaYNM7abbppmw/5Eyd9Q4CTbZGR4W+e0q9APx4NqtRGuH+T5/6e70XNl13ldC1xL0Px600AS5Xc7rM7rsojiiAJGoAJqCvANmV33nvamSB+e2oA/0kHrpH8J4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.04.24 13:58, Paolo Bonzini wrote: > The scope of set_pte_at_notify() has reduced more and more through the > years. Initially, it was meant for when the change to the PTE was > not bracketed by mmu_notifier_invalidate_range_{start,end}(). However, > that has not been so for over ten years. During all this period > the only implementation of .change_pte() was KVM and it > had no actual functionality, because it was called after > mmu_notifier_invalidate_range_start() zapped the secondary PTE. > > Now that this (nonfunctional) user of the .change_pte() callback is > gone, the whole callback can be removed. For now, leave in place > set_pte_at_notify() even though it is just a synonym for set_pte_at(). > > Signed-off-by: Paolo Bonzini > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb