From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B769C4332F for ; Mon, 30 Oct 2023 18:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 379A06B0277; Mon, 30 Oct 2023 14:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3293E6B0278; Mon, 30 Oct 2023 14:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F14C6B0279; Mon, 30 Oct 2023 14:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BC086B0277 for ; Mon, 30 Oct 2023 14:11:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E15E01A024C for ; Mon, 30 Oct 2023 18:11:08 +0000 (UTC) X-FDA: 81402919416.19.6EB84F4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf02.hostedemail.com (Postfix) with ESMTP id B93C080011 for ; Mon, 30 Oct 2023 18:11:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PPa94rF6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="1/23uOzt"; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698689466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8gKDFOEPmhqeqgEnPsJX/gtAMRMS09FFpFfsCT7nylw=; b=5oWNxvEPqV7KuNAD8qKXNKp0Je0Zr42noYXwYfhNox6fJtcNQlj4jMgoDsnTVjCgPEMWVL TVa425mFc14E3a6/n4yICPCTGPT3JcRzM084xRjNjxC3GXuEj1T7cr66psYlkcHCNAgj4d IFSgBhoU2gw7iCQU2MMZoTDuDJu/lDM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PPa94rF6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="1/23uOzt"; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698689466; a=rsa-sha256; cv=none; b=HIlD7Hocu1cBOwV2JtBrZunuL12b6dWASzlj0nRl9tsBAxMXUmehKt1a/lpAludvB12ZK2 H9/gFwzlf98njWutXbk2O0o3dRnSNGkFmXWgD8skb+r2XICn0NBVW5s+pWQipqwU/aMmCY 9KyrVXXrkM01wJIQr2Tm2V/eujHHQh4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 713D41F38C; Mon, 30 Oct 2023 18:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698689463; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8gKDFOEPmhqeqgEnPsJX/gtAMRMS09FFpFfsCT7nylw=; b=PPa94rF6SmntBiDNKBoLhVuSW02pU+ugAPhNI0SSzoz/akaOf6kPGuS5UhxYuavBqT/jqb gbqfXsbQClZbed5V0YjeAoKZsisK3Hpn7hDbCULivUtzrGE3e1NJE2JlBHXyCtPr9cIyOg sd1A5LPcEMM7acMrJi7PX4nYIdKOj2s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698689463; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8gKDFOEPmhqeqgEnPsJX/gtAMRMS09FFpFfsCT7nylw=; b=1/23uOztM2hXq3WV635Bl+sEZlxQEbb01b6Kr47P21pm/8MiQru2RBDzL3OdDwbXtm2t5J l1I2riomtpEJygBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4570E138EF; Mon, 30 Oct 2023 18:11:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zrNOELfxP2WHRgAAMHmgww (envelope-from ); Mon, 30 Oct 2023 18:11:03 +0000 Message-ID: Date: Mon, 30 Oct 2023 19:11:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v3 5/7] slub: Introduce freeze_slab() Content-Language: en-US To: chengming.zhou@linux.dev, cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <20231024093345.3676493-6-chengming.zhou@linux.dev> From: Vlastimil Babka In-Reply-To: <20231024093345.3676493-6-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B93C080011 X-Stat-Signature: ynxwg95cf9km7b1tnymdbhc4sdhepin8 X-Rspam-User: X-HE-Tag: 1698689465-913032 X-HE-Meta: U2FsdGVkX18V3eu+5upt78BoU13O8E5khrIhkir7aouVU721zT70liLXVJlWarnrkcS8GEfP85jza+YESyHk0MUT1xndHM2eycwAbzWqiBO0y0VLl1b0WL7uam6fRtuE4c6zEaJXT8rDjgsEdQDiFZDlzNM5uO7L+exifg0EfvNMdAsTU5CJK9Jhj8GPf4+2xuiAAGtTpzjLCR3TQn2VkbaEZBO3rsFbr3PhEvGyDW6/8oL25zDSZggZCq3yo1Z1S8O0eza0XcABNs87vxN2YF3sIzxvHaKtf/Z8Y8oxn3NPNbGjrnCKBn8LU6dVXG0JHZD5B/DGu46Z9whptAHgh/a+ZmiLo+4hH2ZGQmZFQ/BirElnK6Vvenk77OB9OAzguXJvQQEsNxYhEQoEFnUKqpizI9Q9B8pv3iX0OpegS4ZMuAL/9osYmUPpJCfbXizS9vnyJemG1zuV8g1qgb189DCCvyd9lWZARUguaKareE3Cu8Oytn4aRm/kbqjSMvObdeMe7mQSJBVcJhvkbW1nhtacxqcKIUE1m3JGnxhuTiAu56WMoDuChgtdvAyxEeolCRiqT+SNLXqnnhLQQBs0fhq0Xr+0UJy2pRhycvjhQyOB5Hroc6VjMUgSOWfu8Q4bpD0zV+xUuvWTKBDrV3ww01M4wKrGyc+W017iWVSZxwfiiB1Fn91v8T7HtlQZ3uEZonMkzVrwb27btkAEbbWW4rYYUXEd/R3/lvZRryWTSCvKs1fFlTE1WaVlX/8acwtylrjrnP9TLzOC2an3vAe//W1k7Z8wh7lc6YGykkTp5m/L2Cc4zOdZ5DNUkt+JKgZw5CYEtDntfSyoIdmB1ViILy6H0TOSTXHoLRZVMt3gSby7+14KGGqeFXheooNj2RY43x4mm3wGyGCS5dNLlse3IMe8MZ2gty4TVHMthncKETdNHCXj6xXuHfpq9Uzww+088Yew283w8c/rI7wV1d0 A3q2bSYP ojdVX6jFpjOQp/wMUfGpa1jsoO0VQIVLb2sxiaVc8XBrqqSYdTeyY5+SdNHgEDGjv8rO0W8HODPaCdSi20jyFHuWIlKAHsCq3arFz7q+yntGjvRJgiMIAnwvTLtHha4CO1RsZIOw7ouyUrbMJvIo9QKYzrANRp4QeVLNZ0sKW0pe6sL0Qe/QX6ADorL71fv1PEzbveDRLKNLWGjYqETLg6C6qP2kacXxWcWrOnH6WITDT0vIYEzMlrYQmXEv/eD1M03UALfAG82yov5Ppmy5hP6pSwwhWSRIkdKZkR0a3pZmU7MhRYla2yexKHE35Nh4K1iPIqBEc5d/pUaCWJyPZetkMDySARlwF+XeenHB4+YfOrTOgf6dh1+mHLFrWUuWLvMwMJZnjZTcGooX9rci4Fxu7jkq07TrOH285 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/24/23 11:33, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > We will have unfrozen slabs out of the node partial list later, so we > need a freeze_slab() function to freeze the partial slab and get its > freelist. > > Signed-off-by: Chengming Zhou As you noted, we'll need slab_update_freelist(). Otherwise, Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 7d0234bffad3..5b428648021f 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3079,6 +3079,33 @@ static inline void *get_freelist(struct kmem_cache *s, struct slab *slab) > return freelist; > } > > +/* > + * Freeze the partial slab and return the pointer to the freelist. > + */ > +static inline void *freeze_slab(struct kmem_cache *s, struct slab *slab) > +{ > + struct slab new; > + unsigned long counters; > + void *freelist; > + > + do { > + freelist = slab->freelist; > + counters = slab->counters; > + > + new.counters = counters; > + VM_BUG_ON(new.frozen); > + > + new.inuse = slab->objects; > + new.frozen = 1; > + > + } while (!__slab_update_freelist(s, slab, > + freelist, counters, > + NULL, new.counters, > + "freeze_slab")); > + > + return freelist; > +} > + > /* > * Slow path. The lockless freelist is empty or we need to perform > * debugging duties.