From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B63C02182 for ; Tue, 21 Jan 2025 10:19:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E27F4280003; Tue, 21 Jan 2025 05:19:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD85D280002; Tue, 21 Jan 2025 05:19:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B8B280003; Tue, 21 Jan 2025 05:19:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1E02280002 for ; Tue, 21 Jan 2025 05:19:23 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 444F0C08C0 for ; Tue, 21 Jan 2025 10:19:23 +0000 (UTC) X-FDA: 83031061806.23.C2B747A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id B37BEC0006 for ; Tue, 21 Jan 2025 10:19:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D2o4NAhJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737454761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9DnzRdOSCu77qQIHS7mIp0u0SjfyQZ2DCsGExznz0po=; b=eGtNtJO/OAMr5uIQ+GAml2/95Ltlp7Ml6EtmrPglVofUpwuGg2sWNR4TGjHpZADfAdlDDh v/bqCuNmonX8wF4t16kEPlAcPrkrjr0CxUibnrbKo4hSIPIgflUsRxAJQfr6E0OU31m+q3 38RwFw7qCPzVh1W0eyXdXQubC5rm/2U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D2o4NAhJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737454761; a=rsa-sha256; cv=none; b=MFECAZE6nwv3wAbivLJYdAA9hpw8eY42eq574aVEd1Wr1LK0GNfnbhjIMcBE36RbqT3Dz8 dF05+8VCpGItRdktTNy5G89MdOdu54pMiQCYdqhAsDWcPobmXgaQlsGoQg3XFEPP5eol8Z wCEGA5+sfW6SBTJK+F6/ySQbzzHwKtM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737454760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9DnzRdOSCu77qQIHS7mIp0u0SjfyQZ2DCsGExznz0po=; b=D2o4NAhJVN9S+QPvx+zn2aLecLZSeBNX1ofqSI1FJ3XZmcAMIjFbF+BKeGo9kKjf4RPUYB fgDXg9v6eQ0HD8rtO93T0WN2pyyu+gaAohUsbpMXfBYaHLY9+b0303NQ3zURg7MRN+OYrO od1Ik1BU1fTjPwnc6oXhSiBI46Cp5OI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-R82ZTYoFPqWQ1yIzKjKt9g-1; Tue, 21 Jan 2025 05:19:18 -0500 X-MC-Unique: R82ZTYoFPqWQ1yIzKjKt9g-1 X-Mimecast-MFC-AGG-ID: R82ZTYoFPqWQ1yIzKjKt9g Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385e2579507so2399551f8f.1 for ; Tue, 21 Jan 2025 02:19:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737454757; x=1738059557; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9DnzRdOSCu77qQIHS7mIp0u0SjfyQZ2DCsGExznz0po=; b=kFk7+OyKr/fshAOZctHGTz0gRNucGguPw24Ni/6vihVDSiON+HOy/gEzlVWmrGqXoz 1fA+rVxGLEJ1tOGU8Zx6lFQWoQJaUWPzioM+J84XWQRZGtt6ke+/z8XcvVBqUau6TgUp FozkQGdQgi2bZIdSUDfmvtNRqWPNS6PZq47vNmzooWy2rrPZEm7Mo8nEimsOud9Iv57m jwudbceOEhQPxBd51jjBX+2sxR+FxzgNNwb0TdnhKvi9b9lqm66V5Pk8KfC3lGW4YHam 4qYWVi46v4delb0FbN/gpEuxArqkbYBnnNv9YdOFxqKdbJv2LSwK8SZkSvYyyulDCof8 0hCg== X-Forwarded-Encrypted: i=1; AJvYcCWARH2BY0aVkzhOnj/PBWgoZWVEuca4AQ3WNqxA+fIOytH2wYsrJqizSk25pW5baiV9baazsof2jA==@kvack.org X-Gm-Message-State: AOJu0Yys5bieG3vU6IFxlzhSQ2cmAa0mybadVX6RkkVqKoXwAtOPZv6p /JSfNH4Q1L2f3YjfDv7JJ962oVpYD0RYP5Kz1M8e0Nl24f0jcqjSKDrkeOBJX4jDF+SPfco1hbT 7/QrrMAThyU92tt9JLcwdX8yAIyx0d0FiarSPj5Dkl0KL3rL6 X-Gm-Gg: ASbGncsATOaP0Ll+X1ECCKEolu5y/mVhuyPz9AWby4tZAxqu0Jr3CP4d/7I/jbZX677 DE96q8L3e3U1/j7DIQA8scnHw/M0lApqyMWl8i5MNsyhJjfsAv8BimaF56Jlm0LY6V7ip4bGnT+ YWzhyTyh3MDRJjVkV5nF1Wt3POmAja0pqTUwTHl185Lq/CXlkDzzMVGPYrULBZNlwaPJVRg874g 0goFVDDIIqAun8zgHezokUjDMMtmlzGPkb6MZ/yLEiCkkCuEusWt3x/PBPHLae5WNfVNx1QvS9V w72uHtgfNyXzZYZhNQR0PgYhUBUZtrWEctK4YMKZ1DEMwL8RwuhitSCxjrH7OFwauq/zevjU1N0 lDo7YJYNoHz/PUkDfnsAyuw== X-Received: by 2002:a05:6000:1faa:b0:38a:88e2:e703 with SMTP id ffacd0b85a97d-38bf56622e6mr16099508f8f.13.1737454757156; Tue, 21 Jan 2025 02:19:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGXU+Z18/kGLHyFG9n9OWfVo3kjmNZwU5tAA2LWGqKGaK3lf6dTE5j482gn8aKYxzw7QekjA== X-Received: by 2002:a05:6000:1faa:b0:38a:88e2:e703 with SMTP id ffacd0b85a97d-38bf56622e6mr16099349f8f.13.1737454755178; Tue, 21 Jan 2025 02:19:15 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327decbsm13161161f8f.90.2025.01.21.02.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 02:19:13 -0800 (PST) Message-ID: Date: Tue, 21 Jan 2025 11:19:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 00/11] khugepaged: mTHP support To: Ryan Roberts , Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, willy@infradead.org, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, sunnanyong@huawei.com, usamaarif642@gmail.com, audra@redhat.com, akpm@linux-foundation.org References: <20250108233128.14484-1-npache@redhat.com> <40a65c5e-af98-45f9-a254-7e054b44dc95@arm.com> <37375ace-5601-4d6c-9dac-d1c8268698e9@redhat.com> <0a318ea8-7836-405a-a033-f073efdc958f@arm.com> <8305ddf7-1ada-4a75-a2c3-385b530b25d4@redhat.com> <9bf875ad-3e31-464d-bccd-7c737a2c53bc@arm.com> <95472249-44f6-4764-a5fa-fac834eb5a49@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -kO6AnNVN9IS_qk-Giad6f3cO5b9agwzkciMxBYRW8Q_1737454757 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B37BEC0006 X-Stat-Signature: xapn3rdyjc8q35yoneibqqgfjiyamj7k X-HE-Tag: 1737454760-677035 X-HE-Meta: U2FsdGVkX1+jCxYsV+D41m6LVJRyfPupveaq8Cj62jAbdx+DbgJv5fAfgi/iMukLTWc3oISNQ5uC2Asu/JTv07iS7k08GKao+VihXqpbFsmwHVaZ4N3Nd2KFimq8nGHttnK7BYZM98sKVguQY8vco8dUP6S2xYRnmJqdDRPXcYMzvqjYYVpK04NQQSJQOlcWYvJo82921U+riNfmtY31j9Plf44jfV2Hj7PhggA7NTiGOR+qb1ZGSxmufKtXi5gqt1s3mGkFO1j3RZPKJeUGc7OLaG1zwYQYpUVNBm6RUdNY4cD0de5k9sMUluERbDcIFxTkps//AOkXTxYzspr3OJ+/fmsbR9WBwdawogP8sPmzRS2m6QlMjllDt9jOzE26CmUEhFW/gzgJgXJBa/DavO6KdBa6keZb2od1DuP+o0v6DNMwXs1PXcXR9jl/nKaex1RZ6dtJzcNXNdD1i9F5UJq62ThCjRZwKyHc7MOBJ3eHctJAvk6W2t/x3rWh2FIETZyKrt0RK9YW6mwmxBwFCKm79e+Ak7FMoAGM0Iqk2jzQmFfcZSJJK/A8dlI8hIJPOtuF6fn8cNQkpCJGcFQKNOD7BkrDus06erAKpUbEd3fy8xUX+CNA1lFnSgeN31Fsain05aI8UEl2+M6rh7JLsMMftOsVyz41wJlUZVZe46+GuNf5uDMX3tKWKS9DaVSV6MXaW0TsOG797nyBLY19d+26G5kwRDtSq1Q3P7vl8LxLpej3ibp7JU/mVl+3Y9w7BHtVTlJ98j0OHdRzBIjMMWVltvQmJnsE2Nv7ca01rt3S21JM0UlinmjbJoEBA+GXsSD5rODwzJE00xudB1N9BXutIMeDwjnR8+FWRi/FABTODie11binc6R5vi5xmqyw9BoSIEQ44EIGYt0XSDU4MTonDSsgncvKgKqEFICgVR4AEw8qYOX8cryghs7gB67t2eDTMnR6bwKKc0xxOR6 YLyeQrAM K/uKSQ3Q702hZ0bNtuylKJO6CGECg5v6ZCzbRYaHGMWL8P4Z3LgSGkO6Zz68heVIbGKPvVOjhaUv+VBxgTDM9PZovnOvKSDGFDH4WWKHjvd249lgi4zM1W49gmVljg6Z5UICKlO3C1b2m3POm2L9/3o8U12TIQZsIoYQ+bAtSGdSKg0lIGMMAkn4fuPaoTimmL2yB00BdJvz4HKeuz8aohw6VjBBVhdell5M25vOzbyl3wmg4ZuYIvIP+LObRZJw2gcXJTkDqWPyOQaIaD7ixGQfj9ET1iB0HHVY9kH7GNs0aBIcYbYwshXNCCtyz8F/zTRdX0qCEIxjoPC89kURj/U+AAef8Qv7bQASV1JpiThombhx6ZpVwzD2oS+yS2jq/gUBotQ43WYPU1Mnh0nxl17N5rx1dbhVE8ZvVnSTYCF7wlp2kiafoWSHAH4OEuo73JvL5IBc+h+zCTnzxwHnkKhz9qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Hmm that's an interesting idea; If I've understood, we would effectively test > the PMD for collapse as if we were collapsing to PMD-size, but then do the > actual collapse to the "highest allowed order" (dictated by what's enabled + > MADV_HUGEPAGE config). > > I'm not so sure this is a good way to go; there would be no way to support VMAs > (or parts of VMAs) that don't span a full PMD. In Nicos approach to locking, we temporarily have to remove the PTE table either way. While holding the mmap lock in write mode, the VMAs cannot go away, so we could scan the whole PTE table to figure it out. To just figure out "none" vs. "non-none" vs. "swap PTE", we'd probably don't need the other VMA information. Figuring out "shared" is trickier, because we have to obtain the folio and would have to walk the other VMAs. It's a good question if we would have to VMA-write-lock the other affected VMAs as well in order to temporarily remove the PTE table that crosses multiple VMAs, or if we'd need something different (collapse PMD marker) so the page table walkers could handle that case properly -- keep retrying or fallback to the mmap lock. > And I can imagine we might see > memory bloat; imagine you have 2M=madvise, 64K=always, max_ptes_none=511, and > let's say we have a 2M (aligned portion of a) VMA that does NOT have > MADV_HUGEPAGE set and has a single page populated. It passes the PMD-size test, > but we opt to collapse to 64K (since 2M=madvise). So now we end up with 32x 64K > folios, 31 of which are all zeros. We have spent the same amount of memory as if > 2M=always. Perhaps that's a detail that could be solved by ignoring fully none > 64K blocks when collapsing to 64K... Yes, that's what I had in mind. No need to collapse where there is nothing at all ... > > Personally, I think your "enforce simplicifation of the tunables for mTHP > collapse" idea is the best we have so far. Right. > > But I'll just push against your pushback of the per-VMA cursor idea briefly. It > strikes me that this could be useful for khugepaged regardless of mTHP support. Not a clear pushback, as you say to me this is a different optimization and I am missing how it could really solve the problem at hand here. Note that we're already fighting with not growing VMAs (see the VMA locking changes under review), but maybe we could still squeeze it in there without requiring a bigger slab. > Today, it starts scanning a VMA, collapses the first PMD it finds that meets the > requirements, then switches to scanning another VMA. When it eventually gets > back to scanning the first VMA, it starts from the beginning again. Wouldn't a > cursor help reduce the amount of scanning it has to do? Yes, that whole scanning approach sound weird. I would have assumed that it might nowdays be smarter to just scan the MM sequentially, and not jump between VMAs. Assume you only have a handfull of large VMAs (like in a VMM), you'd end up scanning the same handful of VMAs over and over again. I think a lot of the khugepaged codebase is just full with historical baggage that must be cleaned up and re-validated if it still required ... -- Cheers, David / dhildenb