From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D513C3DA4A for ; Wed, 14 Aug 2024 23:58:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 968336B0083; Wed, 14 Aug 2024 19:58:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917FD6B0085; Wed, 14 Aug 2024 19:58:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DEF76B0089; Wed, 14 Aug 2024 19:58:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A1CB6B0083 for ; Wed, 14 Aug 2024 19:58:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8A7BEA78E9 for ; Wed, 14 Aug 2024 23:58:50 +0000 (UTC) X-FDA: 82452518820.06.CD4DEE6 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf19.hostedemail.com (Postfix) with ESMTP id A1E331A0007 for ; Wed, 14 Aug 2024 23:58:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="K/ImUcLR"; spf=pass (imf19.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723679893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Wde27BaNuCeYQgeYLVGyEd2OOxjIAQu82nJCOJqARM=; b=6s1+lCKcsPZI64u8pZ+zf9NcfJEHlA47htIAcXOJtLvR8lgbMaselpZJ2ts3/ArAX+VP9i D8HXS+juvbsyNCFC8c3IAN1iVs9l5eahnKsUsfFiJ1ITjEzkcC5ByieuwgiPOStyLMroGa jOCTfe6BTGhDa1/rcMtLNiZLg7S4vVk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="K/ImUcLR"; spf=pass (imf19.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723679893; a=rsa-sha256; cv=none; b=GzMFbqIYE8uXEInBtoRFX3VIBgEwNaMbV2Frp1HdLgxp8JF8wbGFwoW8NQtPqSXLyINB+7 EnMXGYZT9GHk81dBGRvsNSoEcf5VDr/zdbrXf/P7Euex3uV+xpcfvI1R/3cn1jDKH7+hKl mlGq3gFedV79+TygQWCQeK0a9Dfgi4I= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4281e715904so564745e9.0 for ; Wed, 14 Aug 2024 16:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723679927; x=1724284727; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=3Wde27BaNuCeYQgeYLVGyEd2OOxjIAQu82nJCOJqARM=; b=K/ImUcLR6W9sTrF3cgW77041My7WQH+FkgkQJ+v3Z6KVGsN0mmgQ2Qoa8OB7tIwK5g M97qlrp+siVpRDoEFm3f4dVNzh/POoGWr1olRuAvwnsj10Hq4MhsnM4dwY7MQOpYWs2b xZNlwwrviQZQbwRmaFTvnFGpehoxPm8rfLgrgENeuTwFyf9wbDPpBpPkqwCU7QjGKEVo AUSlTLh/F90rb8hKY4njFJ++OU+tGZUMkibZZ/N/mh7UbhiFUiFYLCn4MyM/mHtgtbta JrMpHRCvJXuskYOKycYPcaqjQhgECExOqZKECxizQhK7bQOpIsuvd4VtPd1rdLJyKVmA Skyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723679927; x=1724284727; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Wde27BaNuCeYQgeYLVGyEd2OOxjIAQu82nJCOJqARM=; b=ayed4FxGSTqRpdmMw/WtkCJKpgc8p1+yufjdkNsN9GVANrLTXjCXZggB+ZgFkWzNhB kYalHP6B9AFe4Igyq8SsVYNiOaMHR3sB8Dm3SCu1QB1itZAEXSZhOZZ0nM2rJGLFwLqt 9pNE2wAVObb3zJfTztqI+dgv7oTQf0lM9eLs6xtoLmjJiqyA1RbZ3fUtHoJA7umhPQ+6 mLVslvDkdP/V9D2RBXLAGfGBsiBD0wmbKpMDG6N0+DcguWwWBElXJ90mJ6GqXCIp3ErM HzDs3LXVv8OyWOnifHr/3/N+U+/OsYk+iHMpqEa8CnA2+nkMuZJGa+mGIQBfCbEYN/v/ YsIQ== X-Gm-Message-State: AOJu0Yy0ReWd1HLfi1jtM97WP9eoZhaVeDoacdqdwR9ifZ/kMxz3sn6w lHhJxnjxavHga3U1ilx0lcULE0vtnRcVX/Mi8Hjco6kJRctPdJhA X-Google-Smtp-Source: AGHT+IHf3Ojp5u2lAHJ5M7BHfemYWQyGPpbVu1be3IWiLOE1I8s29P4UtVRqte6OTjLtEt21qHHyEw== X-Received: by 2002:a05:600c:35c5:b0:426:5f08:542b with SMTP id 5b1f17b1804b1-429e63a22aamr3322245e9.0.1723679926800; Wed, 14 Aug 2024 16:58:46 -0700 (PDT) Received: from ?IPV6:2a01:4b00:d20e:7300:ce68:853e:d0e2:925f? ([2a01:4b00:d20e:7300:ce68:853e:d0e2:925f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded7d5a9sm32669415e9.43.2024.08.14.16.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 16:58:46 -0700 (PDT) Message-ID: Date: Thu, 15 Aug 2024 00:58:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: OVERFLOW_KUNIT_TEST fails with BUG: KASAN: stack-out-of-bounds in string_nocheck+0x168/0x1c8 (kernel 6.11-rc2, PowerMac G4 DP) From: Ivan Orlov To: Erhard Furtner , Kees Cook Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Gow , kunit-dev@googlegroups.com References: <20240809231537.7c9ee7ea@yea> <202408121146.1D02EB6E@keescook> <20240814223813.7b301ad4@yea> <81303aa9-40a4-42ec-8e48-4a460398d469@gmail.com> Content-Language: en-US In-Reply-To: <81303aa9-40a4-42ec-8e48-4a460398d469@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A1E331A0007 X-Stat-Signature: sj67n8bhyasx7jdsho4sqd6pyn4n6pwo X-HE-Tag: 1723679928-823119 X-HE-Meta: U2FsdGVkX1+octzRD5pzHjxGAW2M3e4RzLGY31ySo24IwOkafG0vIgeEIk8LTEe9mPU32+TyBwVgeq0AVZvu9oPpJ6qq5K5tjMzq5y4wtCsPioo6Nj+8Fivsit5wgbNJT1uxVD8ZxUiCxb59R4vflaT4f0qLM+Y4dO4EnahnfBFSZQiZ0Y8xpW1letU4pSiGL4SkUmwnZaQIFrczltlH/7m0uMFyA/VYjCKXw968S8qUsuVSh1kXuDdaJ8tGeqDeq1utT0VXH5jJ3ZACSCeWsNmMJJEFHuxI4CZOE9vvWvhLybWTdi8zJLBYj+CrHKbENcaDIzTmnhofTPe8ciy9oIWn50Xe9xoLibDUnv4MUmn36x4oK+F4KabcoXnLojg84Tfaff48ZfQq4AUq8gastJEGWuF/x67vIJNf+NX/krb/dqbRllhepVA9X2K/3JezYN+BTF+QoXp09yDEeLizPFB8vBiNNLvCPagqY+pTts+4lyu5LBtOg/wGMhVUGvlqvSfUVYbgvULm9ap7qLwPc3ET47F4fwo1J2apK4UTzkMv3X7o3VR2fTJre+SpdFWQFbAws0eUnvyj6fDd0saLO2kMkbfKtBeXZEFZ7lIDbS2YDveZRGr8g/FpyVaaXt2Vm9AiwrH716T512Qyq+9usZ+FXXUw1tRVWV7udAteT9qnUrSmN7zzh99d/EKqSUk9ljeJxT0XWgS87rP6hg9yl+fM28PIp/8SjK9iVaKGXgEpVEfOISEQ+uRYcuInay/DSIcj1lTdGPWJ5wgDXUz3EamdtdSlhoPB+Rkqt0aiGKUroAk3BQqO0AKeF/dckHVKb43Fad/QBBGEGGM19U+OzpcW4D1juSp5JroP9nmCG105fT3WybnZq9W4GJeu4N8b6dX1A7lCPkRNotRIlVC70EA2f7HI1yNSvInkIBHHqyYWQm9Jt6GKaz9hKNohwazjUd4ccDJsJB2TS3D1ENF KlsMMs+7 7dIAlTQlyk2GZ68SJtuIw8DuZKaLTgoY+bku7gH6Bs21es4wRjyDEGJlECFad017rxQt9sR2ojWEM8kq8jeH/8TCVCVvLGl70Y23OQjFaDwQ3PuKm340mvdjIJuLXHqeubT7FxpDwUyYJC1qoKmFBaeZsv5Z7D0pPL/F3//by0n3gWQzbUCIVc8Yzn5FiiBIFmZ/NIJTWCa0gHYQDnmC9xBOWf4UWZr6wrCkv5edIl6tfUPzC7yNpQcIEqT42/dTIardtUTsC1pUl/KbjbBX+/n/bYn3bK86b25gDQcg6ZGiMtijytbtvbmXQknKKcIFqMIvRYht5ASIK9wEGObq0PmizEm+hUi9TzII7L4EgU5z7oCGpAtpswCl3AWqRtJ/ccO3ft2pwE3ZG7bKlbLPv7f7WHufg2LQYNTUhpAfzBIOariYHPz6MfPw6eYg+EN0F3QE0PQTm5428uhRDU6tEvj4bpQ35S5I6RygxIHzZ/A0neZa9OG07647Dm9t5b2TW3/n0BMyJtDu1AUc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/15/24 00:26, Ivan Orlov wrote: > > As you can see, the device name is defined as a local variable, which > means that it doesn't exist out of the 'overflow_allocation_test' > function scope. This patch: > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c > index f314a0c15a6d..fa7ca8c94eee 100644 > --- a/lib/overflow_kunit.c > +++ b/lib/overflow_kunit.c > @@ -668,7 +668,7 @@ DEFINE_TEST_ALLOC(devm_kzalloc,  devm_kfree, 1, 1, 0); > >  static void overflow_allocation_test(struct kunit *test) >  { > -    const char device_name[] = "overflow-test"; > +    static const char device_name[] = "overflow-test"; >      struct device *dev; >      int count = 0; > > > Seems to fix the problem and it is not reproducable anymore. > > I will send the proper patch tomorrow. > > Good night! > Forgot to mention that the problem is intermittently reproducible on QEMU x86_64, and this is the only architecture I tested the solution on. However, it looks like the initial report points us to 'module_remove_driver' function, which presumably calls the following kasprintf as a part of 'make_driver_name' function which also operates on driver name. If driver name points to invalid memory range (because it is out of scope), it is going to cause a KASAN bug kernel panic. -- Kind regards, Ivan Orlov