From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A56C83F14 for ; Thu, 31 Aug 2023 01:13:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B85058E0003; Wed, 30 Aug 2023 21:13:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B35128D0001; Wed, 30 Aug 2023 21:13:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FD678E0003; Wed, 30 Aug 2023 21:13:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9143B8D0001 for ; Wed, 30 Aug 2023 21:13:36 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 604311C95B9 for ; Thu, 31 Aug 2023 01:13:36 +0000 (UTC) X-FDA: 81182627232.08.6D8EC0A Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf12.hostedemail.com (Postfix) with ESMTP id D98EC40003 for ; Thu, 31 Aug 2023 01:13:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=none (imf12.hostedemail.com: domain of xiexiuqi@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=xiexiuqi@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693444413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sipPxfAge9OamBdGEcw1ag+EbJgx8pACw18Tc6W3SoA=; b=Q+DvM219PN7yCJGSTo5cDk/pB1Hmz0JBgTYUGR6apz89v82iy288QHWVloDZ8wpKR8E0bN UBc1xf8m/hxh36Ywg7fPUJvmay35z6Xj5J9z2dcvoQliY8pDchtIjwJjt+bMGh0M2pgF7L G6YH0KDlMm86miTTrIny+bUJ+RunJmk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693444413; a=rsa-sha256; cv=none; b=DlMpDdZxufY2vGJjwGAcURjpoXCmfrWAuXhnZJqFj4TkRuKh/bVS4gAWwBosXAtltizdRb YsK/XEAus6HnWR0zGLH3w2Ui/AkdBs4hWR1BF0TKCYmyM//Kmw7reucTvvEzR8AtgVEvWZ THNsmeYGUjZemlm2xFXcTZVxKMZIPqM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=none (imf12.hostedemail.com: domain of xiexiuqi@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=xiexiuqi@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RbjpY6qvfz4f3mWN for ; Thu, 31 Aug 2023 09:13:25 +0800 (CST) Received: from [10.174.177.236] (unknown [10.174.177.236]) by APP4 (Coremail) with SMTP id gCh0CgAXp6k06e9kAX3zBw--.4999S3; Thu, 31 Aug 2023 09:13:26 +0800 (CST) Subject: Re: [PATCH RESEND] tools/mm: fix undefined reference to pthread_once To: Matthew Wilcox Cc: akpm@linux-foundation.org, irogers@google.com, acme@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yingliang References: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com> From: Xie XiuQi Message-ID: Date: Thu, 31 Aug 2023 09:13:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgAXp6k06e9kAX3zBw--.4999S3 X-Coremail-Antispam: 1UD129KBjvdXoW7XF48ur45trW8XF1rtry5Jwb_yoWfZwcE9a yIqr47Ww4UurZ7Jrs0krsxKryvkFnY9rn5AF4rJr1Svry5GrykXF4v9FnavF4YqF4v9asx KFyrZFn8uw1xKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzkYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_JrC_JFWl1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF 7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: x0lh5xhxtlqx5xdzvxpfor3voofrz/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D98EC40003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n4ggzcantkknccmhnhgkndt4t7ggd46t X-HE-Tag: 1693444412-69573 X-HE-Meta: U2FsdGVkX1/vn30AsuZO4jNz4YE9PXnfy4fe3jG1Vkt93kwUnNgv8dXnpJh4sZ/c/d14VUfMrRRupLKoKV9PLPbTENudJF7f+JivzblS0pOYbyjVvEzTvNAEiFOK3eQEzqZdpZKU92vEAsA/lXmESumaFLqyq7C5YGJQZTBtbrGM7Vom8aa+GBgaa0ndTvE6RrPl9bGJ0wYW7QZCKVAyFXYoMeASiKb44blgIb64MXpoSmLvcX7vqrbnnWx+UHV41FqAfqlhc2mlPdUmmHwYskCPplFQs09MZLas5rT1rQrD9W2sfJe5SxF2kxhZPXiexQ2Ax+ETwwoOxFa0J8ztjlhbQUn5s+22ExPJx+YT3zjpyGDIFLyp1/6p3x/BHRCBEzuSANMshbJXuiAQKmXQexJbwhDXwaHyYvvuVGeZy6dPpRFPndRI00Z4yzBdw1mxfh7DtOQlKEUYLL1TlXXnTa4jpVZM4cLrKKytFfJH7KaaQh3pUyYZPZpLYkbJIPqaOpzQl2xCN8TRl9mOPXWxYQ3cdtTA5XwPPF2aak0iD1No0ZbBJsX65ZfgiInkJPzeRDGr6fCbSggLKVu/Upt9v2pG/Ah4+zdG8mbYBdKhRp6UFJZSvzViBD7GZzyRN2Mi5uftemTjna7OZ7nally7yzslyBTrsK3GInHVnkOyZh/xOsv+Xg5uufgP4xD0gQtxCTyGdVUdZ3EHiKrN1knklgidJRARejkfX7+t8E7DIjVyAoVRF5Z16KTvuWYnHaZKFP1QHQ12jvHEIczYj/fekylE96+UrQ/RBL+M4++VoCRi2niP2NEWtUE7oaVewSutFALXnaWUI8BNQIGNqGVs/yMtxO1xNKQlLbBSe4mHV6cV6n4QbXeSBDAzr+wpeav2r8tCiZF751ww6na9Pf98LsqgD0k/CXv5uQbSvCP0bXBMaCKiXCQ2yW5u/3ULcgyusITfn3cHikuYlBDnCrA Me9zbsdn ELW2g1LzJ8KhcN2TYcYdfTUFM1go8/Q9V9FBNATrCMTRmdQ1jzEGSkad8AZxoUF3M3Gaosgbrah2XlVv1pbzau4aT9gvyD6mN27UOgxiZllnfV/ID85spVtjZ78KU5YsoKz4NdwhSgirGe6fenqae+r6vac24xRfp9P/BgaoktcLaB4N2pWXi0NcGlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2023/8/28 20:58, Matthew Wilcox wrote: > On Mon, Aug 28, 2023 at 08:21:57PM +0800, Xie XiuQi wrote: >> diff --git a/tools/mm/Makefile b/tools/mm/Makefile >> index 6c1da51f4177..9997b2e401ae 100644 >> --- a/tools/mm/Makefile >> +++ b/tools/mm/Makefile >> @@ -9,7 +9,7 @@ LIB_DIR = ../lib/api >> LIBS = $(LIB_DIR)/libapi.a >> >> CFLAGS += -Wall -Wextra -I../lib/ >> -LDFLAGS += $(LIBS) >> +LDFLAGS += $(LIBS) -lpthread > > Is this the right fix? I'm pretty sure you're suppose to use -pthread > in CFLAGS in case there are other things the compiler/linker/whatever > need. > Thanks for your comment. I'll fix it and send v2. > '-pthread' > Define additional macros required for using the POSIX threads > library. You should use this option consistently for both > compilation and linking. This option is supported on GNU/Linux > targets, most other Unix derivatives, and also on x86 Cygwin and > MinGW targets. >