From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC313C369D5 for ; Mon, 28 Apr 2025 12:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C90A26B0027; Mon, 28 Apr 2025 08:15:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C40686B002D; Mon, 28 Apr 2025 08:15:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADE796B00A9; Mon, 28 Apr 2025 08:15:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8371B6B0027 for ; Mon, 28 Apr 2025 08:15:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C169160125 for ; Mon, 28 Apr 2025 12:15:25 +0000 (UTC) X-FDA: 83383347810.20.419431D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id E5E6A140002 for ; Mon, 28 Apr 2025 12:15:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745842524; a=rsa-sha256; cv=none; b=z+nC7ueig82CQcpzji5gyfcqGDh3GfWG7R9+KcK7HT9sbMXQ/bySYFfJ5LE6ZzWxnDoZu1 teUaP0QB267RmP98EL5HDOfXRKPEuxcjXyw/AHQd8SpLLocayc8BxcicgXf5NAHNKSB33u qdflq2l9gX+ik/HdcczE8EcSJJiekKo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745842524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=heF9FT7mEdBWuxApOZOolGyZCCM4Q3Po6XF3ZRFZ6+Q=; b=5tKrtzeVtm8Mj9fPNtERbzoHdFHO6FFucWBs8uRBPx6pD7xJIHa0OZcVXItXFX2es8awaC pf2ry1YpSKJZepYLNsfy4Aq79YMND6trEaEJGGWNL6nm7/m0Vp+akeBJt96gOWgOMBDyNY 5sYOu8AI3ieUtxvLSkTNQA43g9aPx8E= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B55371516; Mon, 28 Apr 2025 05:15:16 -0700 (PDT) Received: from [10.163.50.165] (unknown [10.163.50.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67F383F66E; Mon, 28 Apr 2025 05:15:18 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 17:45:13 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/io-mapping: precompute remap protection flags for clarity To: Ye Liu , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-2-ye.liu@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250427100442.958352-2-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E5E6A140002 X-Stat-Signature: g79m57xyita4ny6e4xzqxpsifzpc3ds3 X-Rspam-User: X-HE-Tag: 1745842523-644888 X-HE-Meta: U2FsdGVkX18ruygsSJkwZMy2Xgm2TdglvgUHSeaRav/GDjyFQfhf3YzjWKtZzeSkcNsCsUVpCC2/KVXLXOwmTR3OPeh18//HOE4x5EgVI4F29mrHizFQxFu1ke0cS4ZyOUwAmTG5XKJXzDaLYnwhhtLD9cf+LaG11qY0tUWS6JgFhrvU9Xl6TVwh8mwdSXmqv6mgfNrJXKngmsvJAqnrnal4XLN7OUobRASewa58gMjoitfxhpUoG+SVrHDlH7sAB+rtBaYRFiKob20bLmPTL96gOrfuYwKAQCnoXMWaT8L/CVsuJ52fMdgkcWkcTNnqhu3k3GPFPG4MQIX2weGkycEwzyIXjjbj6yAzhNC0NbC1bwC/SCLR+M8emgraVWxg4aNxYTi084+xwxHwAKF/m5vnBcY+K73NrLoArAN3/cVUkUmDqYqUBhn3OMtxFaK0a8w/xgR4WaSK0H7aFtR0qwShQ7gGk+iggthMPlS9AHSRooWSNA6R+32HDQMKUpCt0UGXd4pEQDNMdcFIji5PWzKuuviKgUEv0YtiQvF1tdj/WD5aKrAfXFHnyxY8fAN2CFScjFTCj6rD2MkZYuIKhkeT2IIHPutN0MQ/8bMdV/ZYfm4fOhy2dhGa6P/EqDrv/2W45TiUabgL1mLDJLSsOsjncE0Z7OIEtVKmji36w7tQFc7EBugg3nwvq+HVY5cZqdEeDt4BkZK9qj7BUZyKnVOSWfDEbDyGI964gCyYQi+8ckGTGGkLkWjzLScPDA6OqHw15YWNe9fC8DhKy1cEemmDMw6hqxGgYVHL5sEuB+nlBgZBna1NuFIlJATwUAEaUe1Nwbex1zCVGzzuykvg2Cn265tE334FgJwnoA375HJUvuHHv9SFkjsoCXniOtejPPugzX1aRDgBwJXJfXBtE0H1NNiuIdHEx3tenPsc9FMOa0WfOgNqbBWvUcn19bKHzlFd+AtQ1SZ36wzGwzp 6AO32IMS 8WaLoHiuJlK2Xd7p12RWCwbJ/PZ1wgVfS/0EjRPjumCCIgXU8dvJqj/JaAnw4rMgQGfq19N9ACPrEXc3Bbq7oMDrHVZqtOZNhnldZkE7SbPnTGWGq8FM8FJhEGYj9+pvD2mZ7QQXkBFExCvfXUz/Wyr8oEyrSvNs6JBp2NWiVzVe/q8JB8HV99ZLp7kcsCrz70hhWoxAkrs2O/1k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/27/25 15:34, Ye Liu wrote: > From: Ye Liu > > In io_mapping_map_user(), precompute the page protection flags in a local > variable before calling remap_pfn_range_notrack(). > > No functional change. > > Signed-off-by: Ye Liu > --- > mm/io-mapping.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/io-mapping.c b/mm/io-mapping.c > index 01b362799930..f44a6a134712 100644 > --- a/mm/io-mapping.c > +++ b/mm/io-mapping.c > @@ -21,9 +21,10 @@ int io_mapping_map_user(struct io_mapping *iomap, struct vm_area_struct *vma, > if (WARN_ON_ONCE((vma->vm_flags & expected_flags) != expected_flags)) > return -EINVAL; > > + pgprot_t remap_prot = __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > + (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK)); > + > /* We rely on prevalidation of the io-mapping to skip track_pfn(). */ > - return remap_pfn_range_notrack(vma, addr, pfn, size, > - __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > - (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK))); > + return remap_pfn_range_notrack(vma, addr, pfn, size, remap_prot); > } > EXPORT_SYMBOL_GPL(io_mapping_map_user); Reviewed-by: Anshuman Khandual