From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258F8C25B4F for ; Wed, 8 May 2024 07:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEEDE6B00AB; Wed, 8 May 2024 03:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A78886B00AD; Wed, 8 May 2024 03:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1A06B00AE; Wed, 8 May 2024 03:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 711436B00AB for ; Wed, 8 May 2024 03:58:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 271C6120367 for ; Wed, 8 May 2024 07:58:24 +0000 (UTC) X-FDA: 82094476128.13.EDE86A9 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf08.hostedemail.com (Postfix) with ESMTP id 52E87160007 for ; Wed, 8 May 2024 07:58:22 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=d+6Wlldu; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715155102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3F5pQrDzR2EEoAMCcYf6Lq6MSkQvmn0ilYiRNvAkkr4=; b=R/eW3h3fkcsDpexQXkaHDhm0KjEHiFFEWqEjEeuYMijNDZfB5GvHW4yYL1MXw0+idULN1Q G990EmR87k63dKX0wIGhGukHVl7pSVFzn7QjLhX1557pSTEs+bydKU0I9rlDwzeEU5HQTz gWFtZvsQ07ztJ3UXGspwljGp0lAfeAU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715155102; a=rsa-sha256; cv=none; b=XSXBiMCucJLuY0IvH3PHREt6WPjEZTc1of/tdooK6FRnxM6gXiHNSt3cywvZIBqPuOM3KL uTqPlO3PHc2gCZ08q8uhxVhyNUBh1nxjwEi2G5SRit4eq3dyyzpReyYd+JzL3dp2Zp/UQQ B21Zs4/oT4Yn4bpm7N6c4fCQR4Nfmyw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=d+6Wlldu; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715155100; bh=W8h0zv7fM5rho2qCrJQe63u3RrkuJY8jHMl1xzQ0llk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=d+6WlldukdN+eWmS3sBsn4libaX2zcJvXa/ngL+dhdc+DchosZSUl43ALM0fKrizz ysZ99uHC/8UpNmyFE4hOPapdp0NUzrlzrQjGLrkMDMqYNps7lgHGiCM7grlVWeqvuL e5HkvXoNYPhMwpb30PKIuWAHw1A/b8v33oat12Wn15tu738O33/VYc94jtdztajScu 4J+5rFyzWIZ90H5CzrX9B4Ib32RGjnbcFX2KDX2Cv9yM6dA7sRVQyStsK2OIpLFTHR MsAgmoQsx7QhT2c2rNTU9MLlxEjijsJQpah0OPot4l0rd5cOVPx4wu8rShkkg7Xmln rRM76zFaWDvsw== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 5163A378107C; Wed, 8 May 2024 07:57:56 +0000 (UTC) Message-ID: Date: Wed, 8 May 2024 12:58:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE To: Edward Liaw , shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-6-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240507214254.2787305-6-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 52E87160007 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bj5xjy7p56j3f91brznx5z5ny5qc5tcz X-HE-Tag: 1715155102-558181 X-HE-Meta: U2FsdGVkX1+9zlU16oK9c2igrvzGCncqupML+lsR9MYAf7RdJVcPePTDKjzBp1Rdcq/J1kyRR1pNoWVltXtinSjJsstjJcrL3XZijVPSXWhTcdlviYYHQji+I4E/ADAlvQROh0Q+J//K1+cG9sOHPHsF3ZUc43jASinXfn5dX5ueOGi3u1UN5jhinNY0+48Nv0nmWfzJtHcH3bSVOTDhu2x/2zOrnbjlz8xmH60SQxSmsY03sRVCNtrVISvMuW7QlD4mJxUWdSGXhwcqwnHuIYTbibiKXbDyuUL/Rh8HweI+cRQi4m8Jfh4zr8EFreRUtG4Q6eUuJPwlg4F5cPRozSdwsKgh296lZKIqdSrJ9S2rvOzCbOFYJCmGuUaODVn66A/mHoRdMmbVexzfD5+9m5wwGlLl+8POtZd2JGyFNJKHDpEqIr0sWhMgCFqep+OBUjuSr+eZCvHP5nEsCXnAhDjhrYeeR1Fucw4FEWylZcf+dggcOhlFh0GQnhEDDM6TrqcpG0FNkJVFAGzmIA5cNLAzzydxBltG07Px98XX4VREJ/8TgQ9IuNRLiRygYimkK/zklW7zjjO2vttJRyUntknHD62zBv3TdeuqzLgQHnL5t4y0UgHaf/JqkFhTcPRazIazCFrOxb1yzyiQ3qB2+ak+227CDGZ52u9M0T8zxXI+TXGhgxattTTktSBbrIuNBHQgjxrr7majI8SuJUlRHXXctd+kLQ9wMTUu7hCbIEimHypScloZyjJ9WBcNUgmysbQSit+qbRMgmPGMq6HwQn/+oINUANr4PapFaM6u4hLQ8SYZm6zcgU7Q+A58a42Z5SOql5hhHKePRL6bqNazQTAtVj6m2GElRbzz7WkQhDJZcsZWtpZfqH3m45vSyPiDCdGr7vaotaGcNlhc85DLTX8dmKtI9styQT8nuKEmmwgvhosccKjgqFcctOwO/CDhBjq+tzy+vIjQkFdEHPu DXkTlSN8 uupkmuahPOmDoy7xDT2H2bXAKRneJKKYswoXhySn2Vrj3+yLJWUP4oaVi5AQ9dLVSoJYkW61Ww82zWKjweQpVzEIaMkY0uQuUgzj2HFW4pxj1PvTWYzQXiglDr4zK/F1DFSGx7BycnFdzTD5nX+vRAX/hCrP745ULbn9LHKHVxaFyGHZeNhsar7x/wRQUIHklOaKhe8aIeERufSn0QCjgq1NuKuvbJhltIldaCLn6aOkr9gO6GCbIPCuabUVSDgKGXfUJ3n4GHUY/rnVmI3T2TPIsmBct5T/zg21hCwAjua6hDBx7zcL6AWjgGHuzPkwPmRQh0W5Sv0PESpHhSfnodjO32YVtZKFx8FwwYp2PHc9ixVadCxt1aWgNOgb79OaqIhrv/siItB2TSvXvyYiLUAivvk61d3xZ3oN15M6svcrLgpQpdyp0Ae8BtA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/8/24 2:38 AM, Edward Liaw wrote: > -D_GNU_SOURCE can be de-duplicated here, as it is added by > KHDR_INCLUDES. > > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/futex/functional/Makefile | 2 +- > tools/testing/selftests/iommu/Makefile | 2 -- > tools/testing/selftests/net/tcp_ao/Makefile | 2 +- > tools/testing/selftests/resctrl/Makefile | 2 +- > 4 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile > index a392d0917b4e..f79f9bac7918 100644 > --- a/tools/testing/selftests/futex/functional/Makefile > +++ b/tools/testing/selftests/futex/functional/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > INCLUDES := -I../include -I../../ $(KHDR_INCLUDES) > -CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE -pthread $(INCLUDES) $(KHDR_INCLUDES) > +CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES) > LDLIBS := -lpthread -lrt > > LOCAL_HDRS := \ > diff --git a/tools/testing/selftests/iommu/Makefile b/tools/testing/selftests/iommu/Makefile > index 32c5fdfd0eef..fd6477911f24 100644 > --- a/tools/testing/selftests/iommu/Makefile > +++ b/tools/testing/selftests/iommu/Makefile > @@ -2,8 +2,6 @@ > CFLAGS += -Wall -O2 -Wno-unused-function > CFLAGS += $(KHDR_INCLUDES) > > -CFLAGS += -D_GNU_SOURCE > - > TEST_GEN_PROGS := > TEST_GEN_PROGS += iommufd > TEST_GEN_PROGS += iommufd_fail_nth > diff --git a/tools/testing/selftests/net/tcp_ao/Makefile b/tools/testing/selftests/net/tcp_ao/Makefile > index 522d991e310e..c608b1ec02e6 100644 > --- a/tools/testing/selftests/net/tcp_ao/Makefile > +++ b/tools/testing/selftests/net/tcp_ao/Makefile > @@ -26,7 +26,7 @@ LIB := $(LIBDIR)/libaotst.a > LDLIBS += $(LIB) -pthread > LIBDEPS := lib/aolib.h Makefile > > -CFLAGS := -Wall -O2 -g -D_GNU_SOURCE -fno-strict-aliasing > +CFLAGS := -Wall -O2 -g -fno-strict-aliasing > CFLAGS += $(KHDR_INCLUDES) > CFLAGS += -iquote ./lib/ -I ../../../../include/ > > diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile > index 2deac2031de9..5073dbc96125 100644 > --- a/tools/testing/selftests/resctrl/Makefile > +++ b/tools/testing/selftests/resctrl/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE > +CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 > CFLAGS += $(KHDR_INCLUDES) > > TEST_GEN_PROGS := resctrl_tests -- BR, Muhammad Usama Anjum