From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A633C77B75 for ; Mon, 22 May 2023 06:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1653900003; Mon, 22 May 2023 02:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC690900002; Mon, 22 May 2023 02:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B528900003; Mon, 22 May 2023 02:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8B4E3900002 for ; Mon, 22 May 2023 02:34:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 53A0540B4B for ; Mon, 22 May 2023 06:34:54 +0000 (UTC) X-FDA: 80816928108.10.C587A50 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf18.hostedemail.com (Postfix) with ESMTP id 1C1281C0007 for ; Mon, 22 May 2023 06:34:50 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf18.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684737292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z4YuZNubHNlnohnEEBSJKqpdH0ox7VK/ABpU53LHyPo=; b=iGl9gi55q5RR014VVkpKgHLSgbNc7pjSNcWqoBnzWDSOQCo1gRCqSkrSWK7OogelejvKsA vZBJpu+d2XxnBgb/hev7f9iCoxrBm9ox58FJZIMRmjI2H+67YFShSwuEJ9NyaNntFtQlOE tipM/W1v64rPEgqi+kb3HRSxBwliwNY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf18.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684737292; a=rsa-sha256; cv=none; b=tJXGXknuYEkWv0JUF7WRaNlXEcmMYTVAkTbH8jGJRawA7elIBZZCIc1f/wQoBTuKRe7avF lCqkxaSgIdXSOYIwC6wqYQVG4derv01uJG2Uzve67SGjbgnLsKI72vSz3KBlhxDzI8BIwo 10uWbLWTYbhZ0rxqwN8PW7NY3zncrOQ= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0Vj9B4yc_1684737284; Received: from 30.221.132.35(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0Vj9B4yc_1684737284) by smtp.aliyun-inc.com; Mon, 22 May 2023 14:34:46 +0800 Message-ID: Date: Mon, 22 May 2023 14:34:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v21 22/30] ocfs2: Provide a splice-read stub Content-Language: en-US To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com References: <376ab23b-52d0-d7fd-2dd9-414cbb474e01@linux.alibaba.com> <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-23-dhowells@redhat.com> <2362051.1684736916@warthog.procyon.org.uk> From: Joseph Qi In-Reply-To: <2362051.1684736916@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1C1281C0007 X-Stat-Signature: or53t6pjaqd5q674ray4zf76mmbx8zpg X-Rspam-User: X-HE-Tag: 1684737290-941830 X-HE-Meta: U2FsdGVkX1+T2fbYUKdLfUVyfT/bhI3lMZDIeM/lReS1ItKVMW0Nkzcn11gD0zRYykRiK/b5fc7nW/gXXxDYJr8QYlriIEj6/76FiNJZDVLQfenVDrNhDYI49QyEpz1GvYfG0oH1DgvCJUE6OA9qlCuDAnlL5kugBCaHWf9VSZO3yTfaPiTPZDRsTDgye6h2Rw4ln6naOlZiwpS/mhm5OgTXRdGlmzIgd7iT9Tf/ApoAUUnsH9L6Ac1fnIysWd3ClYIDyaBthPa3OsK6G/FiodQXoTqC3WeXfv7lVdsPDYYKYoDY2KrW23HYZeyU8ItHXKvmDo68T4DsTrSFimvzgSHg8bK9EtD/TEMLny/QqaZxhsNrpupaxskjVzB45dCTBQW9A3oiGYQ2fx6c+inQhHpvomL5GQxPMByCrD54T572TJ9NfJSpeX4nWTHpG+LNbBZTqsiL7zA5wqbhQgYO2BtQ8N0sUOQp1aNTiIUO9o0zqAwsfGWbYKfTCw5wPgPmrFekwzZcTzDDVPxl1rbTTFp8cu1iAI78rcztMU+qVmDyl5RiZP0wut0qPNdHs6eq1oidW+aRjxyEYBdvRkL72kEA3Fl8vbE26Vw74I7Rwmevco5BzGL873AiCKfGG05S+YXk4hnNP3uE3K2XRJoAozmnVkQfXgFXtUHRl2Z5/zcsgEhPBXI4qQ2uuGfJIVNcjmcOLX2XZa0USbP3YNBLylJMcI77dzNc6mQ3bPumvHKCo341OAyQqnQyTEXfJpk35dfDuRxAOV38/Tgzl+p4UIiTqeFqaaqGKes7EloUIY+yyKF5yWx2fPhXt17T80bzLOqd6491vTlClK9wndsWhAJOvc8r+i7z1612TjBIEOP5RFwpGNEQckSGSBdHLGTn88d//q0HZ3leIBIBtCiVVDTlcyiDUqhEyp8/SSM8CnlvpQKRK8XglmyXtq0kgjGB+qc5Q58fdvkpIIBCb37 8e9Fd7Dl BHHv2Oevm14c4iw2l/I7qtkDeIU5532Wqay3A+7u9FyeMs19OKqwxkWyy6Mu2YBzaolGVnyMqZTQn9vLXKWkEZWrH2mBy6B00hVzt4/Nf/RSjy4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/22/23 2:28 PM, David Howells wrote: > Joseph Qi wrote: > >> Don't see direct IO logic now. Am I missing something? > > See that patch description ;-) > > Provide a splice_read stub for ocfs2. This emits trace lines and does an > atime lock/update before calling filemap_splice_read(). Splicing from > direct I/O is handled by the caller. > Oops, missed the patch 7 of the series since I've only received this one:( Have checked it on maillist, it's fine for me now. Thanks, Joseph