From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE54C36005 for ; Mon, 28 Apr 2025 07:07:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72BE76B0007; Mon, 28 Apr 2025 03:07:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DB166B000A; Mon, 28 Apr 2025 03:07:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552946B000C; Mon, 28 Apr 2025 03:07:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31BCD6B0007 for ; Mon, 28 Apr 2025 03:07:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7B61B1CCB6E for ; Mon, 28 Apr 2025 07:07:08 +0000 (UTC) X-FDA: 83382570936.15.66C1EC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 151364000E for ; Mon, 28 Apr 2025 07:07:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ExWBBHAC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745824026; a=rsa-sha256; cv=none; b=F+zq2en9acUe4qP64SJr/ClhBAclDkmi955t+hVk9ktHqm38ZnPazam3+8gjUW7olSBhd/ hs6yyq9abA7mjvUhidS+ufF1CKYsOQ0KUrcRMSsfHVK6kQRSYfYTRtLBHNbTGtFXkC39s6 hMKdLX1bZ69eXZs6gvc2/b3gAxLmYvw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ExWBBHAC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745824026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3UHlymsuGJ3Sl8WG5Aq3yhutdRMJDhj2uirfH8/AuPM=; b=kmit569FBarBk/tEcQxQSf3bBT+MJLX+c6D/PIiIqHgrSsCjJWj7XfGyNtWOvGvBi9o+bt YsMIXQylPVRTxaaGzmq2P+dVrwo7jJVnHh3qA0ngnWRGjl2yGRhisjm67uVUM2oDq2sAvQ hIbp0w/lGes8qRkHYCvboxM7v/xO9Cw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745824025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3UHlymsuGJ3Sl8WG5Aq3yhutdRMJDhj2uirfH8/AuPM=; b=ExWBBHACq/Vnd3bGuTgWZPHw656SQSE/E9w0CLXGy9LZpSqcI1Ijgoi/is/R+sxKzClpLD yy5ipUimXQOjsIaCnPvS88yYO03o/p5/eyj7IRdo6bJ864fVm9l+suPtLN+2a2s0nGcBZK dUjcLSAKl1CfuFrTNGuHQ9+cEjhuJ28= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-7IDh9VHFM2Ot2CBbhkhQ7g-1; Mon, 28 Apr 2025 03:07:03 -0400 X-MC-Unique: 7IDh9VHFM2Ot2CBbhkhQ7g-1 X-Mimecast-MFC-AGG-ID: 7IDh9VHFM2Ot2CBbhkhQ7g_1745824021 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43efa869b0aso25927925e9.3 for ; Mon, 28 Apr 2025 00:07:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745824021; x=1746428821; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3UHlymsuGJ3Sl8WG5Aq3yhutdRMJDhj2uirfH8/AuPM=; b=e5ZDXYBP/x7R44WW4QzmNLRqHBESnbAZJHs0YTZUmsK/QnoV4FJwuxNSWkvfVBwpGz 5d7ObqfPVPAnWwM6s9jsZTi1D3JvgEeHvFnUCRnO5XEGQEPz33hSRmtbtEGnRlK36FbY YwZ1Dop8O9j7HGvOd5TrsdxUTLVqr84Nx2jJ4d3Q67AT0IHzd/DQihEIjHOmoOKGnaMD z6kq+J29v9wlV3OILdjCijYlPW6YFPk1XhbBFDlE83OKtoGrhbxN4LrQAml580m4gcDx rrCs9RXn8HTlxWs9oSU2WRUymBN0O8lpj2lTR+2C/ZjnXSX+yN9jWI+tTedXFdWAeyK9 GAlw== X-Forwarded-Encrypted: i=1; AJvYcCX6dUtdFnbA2eHhtYA99SAV7n3grZOxlqAmAPBjF2sZB7RjsieJkkPwRK8DSvD33WUuZqQ2RqLqIw==@kvack.org X-Gm-Message-State: AOJu0Yy+9poGw0O1V4p/Qb1Vyjhl4Fr3Nq2v0pgDJp+Bed7n4FzpdWRb Ex9Cpsem3m5eoruYpgg610VHGCKc0PwGtum6hKV5e94xpz3QbnxaOQMwpai6snTG+l0NYEO7et7 bgmMK2iZyM24BDp2P7mUQwBzgaH3F8PA7KHUbSGKqurkh+yLn X-Gm-Gg: ASbGncsavGjXpx8GmXea7EpSlA5aRjUewyaJXU+n5T9NApn1LV/pVKsptDBqWhXGPVG 9AGi149fBNzWkMTUS3/SddCCEMwjvybmL6ZhXHgUSXBlriax+vdHboqUgNhCN8YI4hw8Ig4O8lv Szi24/o9wgx1BiuJ0yugaPhaDLgULM1coFtiFTdj3RrKAEn/c1l1xY5Aewcw66PnSJX1qb1VydR ZunHEmLvnlqlcaHUoOhWMIBQPMyvfWxbqdtVtdrmrClIOVQixce/uNkq6uOaenMoLNfAV1Cs/u+ 62Akt4AuSvAK/PNEdmwJkiwQK90Fo1qbVpIKa3rHjFZsT41As8Htcz0hQ6VSg0h2mitZ99SlPUi 76Dkn1nGqzMst35YX7R4eRmeJFheArvO1zjd5agI= X-Received: by 2002:a05:600c:34ca:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-440a66aaf1bmr84021975e9.24.1745824020828; Mon, 28 Apr 2025 00:07:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5vI+QUcSRxc3VofS2FREQCSTlw1QzEVbQsEVMMtzbDu9hLqKcCFkP0GlDjwtwlzDGi/rqKg== X-Received: by 2002:a05:600c:34ca:b0:43e:a7c9:8d2b with SMTP id 5b1f17b1804b1-440a66aaf1bmr84021655e9.24.1745824020445; Mon, 28 Apr 2025 00:07:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a536a1ddsm115057995e9.30.2025.04.28.00.06.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 00:06:59 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 09:06:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem_region() To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-2-dwmw2@infradead.org> <0eae5cc8-5714-44dc-97b4-e1b991c0e918@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BYazQ-i0EMR2nWhR7WkzkGA_hQkmq1H379Ctk1Z-h-k_1745824021 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 151364000E X-Stat-Signature: 48n1cuefajon5ii8mk5wqozmjugachnx X-Rspam-User: X-HE-Tag: 1745824025-944283 X-HE-Meta: U2FsdGVkX19o/Hd8O8mpP35iRosGYJqSMLq71rAfimr1OnxJwkgvGDQfJm4Bu/vOnxiT3liIQcfWM8wlF+fPsoZMZ/hq0Qxxe+Om9g9i7kqj7L7UX7mT3Dt9f33KTnCvCJcqdcXxHXcV+N2m2PMoSMti019Kbvu841iBxL7BeitSpDhPaGg7zCKU3WrsiWbgToOzvI9Hi147/kbOp1ymuf0sBd0aPoUjrnbSn+YqiqCKcQL0wDIXWob6WaSL9RSz3jt9efXO3QIfuufDFc9+6y94/7e2Ep9Fxi4pMM4lO3UxjdMrv9kdGx+x+prAUuXQAOsm0mmrqOBYlPpI1b9ggh0jgtxW/uItjcB1GPpCxTH9mmCd6jnGnOTbjlr4pr1DojaVchUSesjm4pjVgIeXGcV0nVDk2pcK+1vvd52LcJsiZ3u3M3ssD95QmR8khT/pLtn1HnSt32I0sYITJtUAqY7qzu8LwKhb0RmFUfVQQVIQIN5B+Rc6+BUTkBaVfGIFucxM6BZDTrM4weFotQTVjPnndc5rNdvvpAtVVe76wYdDhs4RuI1XiSBj1DqJfgmrjbsHZVlf5W8kUJAhrXOpJn+xXu9G29sEBTiQiu8QlC9REhR3I1rdG+QdynND61Y2g5UjkxGayHOsu6GzfpyI/UTYae4uE1ukq/9aB9qFYM1CSXg4uEQHCMfRRx23QezAQ1cJDeiPrPgFnIa+5dxsemNRyg4TOjG7CNxJ/EVJwpiVC4Bu2qpUCetfZkDpPK7QkbxIeYn7pdgJSXDilN8Cj3td5tKXUcP3gTjPg6Rv6JrJc6EKBKbKLL3pUl6ftQ326wHL9KFAORBfSwlobSd493/mrRn1+uZqkLsZ39RQldj8HJg1nFZonwaIJY59mAIQbObJI2/FPwl1lEjmQsDutM6SIeIdJelJzQOGRgn2rKFMwni7bsqMP2pQimu7Rqmi6j3tCdTjaXx0NXa3U1q atHMrw2H QF04s4ua9TOPFURr0YzdyxOJz3D2PNmNhSCPJ0V0tU9RH206OTQIAUSnPW2Y+iPTMQtEoXyAYnhTC2IEYlhujAABhBVI9oKTBxMmSx3sI1uZL/gVC94Vcpf2eVoJMCYw0eeITEgg9KcZcuyXLpZOhVGuSSzGC81CwtN8dJc4Kvp1zSeXRC1sBzHRyiNkAw9u4EPW3aYf8ld+0oMHYdibTw8bIgSdyKL1RD6I38MpfHpvDIE3u1EfOscVGfv7MuVwtS0oRxQzT8mobNF8Gr+H1uuQlZxSTB88mSbtgNCc/Jqle1Y6R2x0wIPiaMf5T8AcV+adpP8pctBt4xbOXZhU1AaOA3Iz5yzfoeRk+9Ia8vIVyiv+hZSAbyzOUFGx+XfX8Zzi2h5uvjMWUJ1L9XNigM9NtvcG+q2yOn552IIIUI6/2PkzN2lNTYSoqUijMp+/c9+AhDViQ44/ihIgdZ6S9gQ1vtyN+hPrUEhG9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.04.25 00:01, David Woodhouse wrote: > On Thu, 2025-04-24 at 23:11 +0200, David Hildenbrand wrote: >> >>> + unsigned long pfn; >>> >>> - for (; start_pfn < end_pfn; start_pfn++) { >>> - if (pfn_valid(start_pfn)) { >>> - struct page *page = pfn_to_page(start_pfn); >>> + for_each_valid_pfn (pfn, PFN_DOWN(start), PFN_UP(end)) { >> >>                            ^ space should be removed > > > I was treating for_each_foobar() like for(), which always *does* have > the space before the parentheses. But a quick grep shows that that's > the minority, by at least two orders of magnitude. Fixing it locally; > thanks. Yeah, it's frowned upon. Note that checkpatch will properly complain: WARNING: space prohibited between function name and open parenthesis '(' #70: FILE: mm/mm_init.c:782: + for_each_valid_pfn (pfn, PFN_DOWN(start), PFN_UP(end)) { -- Cheers, David / dhildenb