From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 2/6] mm: memory: use a folio in validate_page_before_insert()
Date: Tue, 7 Nov 2023 10:17:53 -0800 [thread overview]
Message-ID: <e3dc3bf8-28e2-4215-738a-7150f8165737@oracle.com> (raw)
In-Reply-To: <20231107135216.415926-3-wangkefeng.wang@huawei.com>
On 11/7/23 5:52 AM, Kefeng Wang wrote:
> Use a folio in validate_page_before_insert() to save two
> compound_head() calls.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/memory.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 1f18ed4a5497..b1bff4d245da 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1836,9 +1836,12 @@ pte_t *__get_locked_pte(struct mm_struct *mm, unsigned long addr,
>
> static int validate_page_before_insert(struct page *page)
> {
> - if (PageAnon(page) || PageSlab(page) || page_has_type(page))
> + struct folio *folio = page_folio(page);
> +
> + if (folio_test_anon(folio) || folio_test_slab(folio) ||
> + page_has_type(page))
> return -EINVAL;
> - flush_dcache_page(page);
> + flush_dcache_folio(folio);
> return 0;
> }
>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
next prev parent reply other threads:[~2023-11-07 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:52 [PATCH 0/6] mm: cleanup and use more folio in page fault Kefeng Wang
2023-11-07 13:52 ` [PATCH 1/6] mm: ksm: use more folio api in ksm_might_need_to_copy() Kefeng Wang
2023-11-07 14:24 ` Matthew Wilcox
2023-11-08 1:40 ` Kefeng Wang
2023-11-08 13:59 ` Matthew Wilcox
2023-11-09 7:09 ` Kefeng Wang
2023-11-13 8:32 ` David Hildenbrand
2023-11-13 9:51 ` Kefeng Wang
2023-11-07 13:52 ` [PATCH 2/6] mm: memory: use a folio in validate_page_before_insert() Kefeng Wang
2023-11-07 18:17 ` Sidhartha Kumar [this message]
2023-11-07 13:52 ` [PATCH 3/6] mm: memory: rename page_copy_prealloc() to folio_prealloc() Kefeng Wang
2023-11-07 18:21 ` Sidhartha Kumar
2023-11-07 13:52 ` [PATCH 4/6] mm: memory: use a folio in do_cow_page() Kefeng Wang
2023-11-07 18:27 ` Sidhartha Kumar
2023-11-08 1:41 ` Kefeng Wang
2023-11-07 13:52 ` [PATCH 5/6] mm: memory: use folio_prealloc() in wp_page_copy() Kefeng Wang
2023-11-07 13:52 ` [PATCH 6/6] mm: memory: use folio_prealloc() in do_anonymous_page() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3dc3bf8-28e2-4215-738a-7150f8165737@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox