From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70DB3C5AE59 for ; Tue, 3 Jun 2025 14:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129336B0498; Tue, 3 Jun 2025 10:58:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 101B96B049A; Tue, 3 Jun 2025 10:58:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03E186B049B; Tue, 3 Jun 2025 10:58:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6BA96B0498 for ; Tue, 3 Jun 2025 10:58:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 87D0AC0D5A for ; Tue, 3 Jun 2025 14:58:27 +0000 (UTC) X-FDA: 83514395454.01.412BE96 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id D672280006 for ; Tue, 3 Jun 2025 14:58:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WTUlMTKO; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748962706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7TJRGdJRqbOKjq0hmSdeWJoTZufohhu0lrU5fP7/Gmo=; b=NcDODYDCdn6td6K3rmT8/kJgP1jq0r1wQCyxZ2bBABE/uQfbiv/cdO5susj3C9HwDz5PTJ gAh9VIfRPePMCRY/DMtLb2Nfvx6CZ+r6ihwGctaCdT8j9TI2YsdtcqOyt1SiJqwhiKJiBA ChoYfgVS0ctqSxZnAVVW+Dh7NLZqbSs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WTUlMTKO; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748962706; a=rsa-sha256; cv=none; b=20HncY7QcCa03+13Zr1XHI23qPnNl3ZQPrzVor766S3s7B6Vmc2PVV3kswOhbBKXnCFc3p mmYIkKzrpsKEqezERjsjsTW0dqSycq5RXiVbGOPaIKlShPzphUL+WoesS0JoUggESzPrfo mrfp1BEManGW4RZz2sT25IyKWYc3228= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E56EC5C56C3; Tue, 3 Jun 2025 14:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E38B8C4CEED; Tue, 3 Jun 2025 14:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748962704; bh=TGSwb3f9VkAuQUVJZVwaW42OFUVNk/Z/EbK4iD38jJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WTUlMTKOt9Zsui0FCCint1TzbeUO9e5ZIt2YhaNLiokT2Peyf5UXPVkgI/XaQaF1t tEFzrl6VXa5Ptw96/qfnOJI4BmysR0ngSC7d/nF9KSJek3Kg2DIw1Dr3OkDDSabRn9 g6RVpEEnY0o6Ho2DNsxF9eju7jl8I14Kww55ggkHsGpe0vy5Y/j/BKTnK3oGaydMug FkYW+ftf9olb8mrjbMyiL1FI+wLuukbWyhM8O0G3CxkGz+4KFEJB3mvag+lU/JkXGU 5A9Zz0Ds0+nMIMqLjrqSyd81ATyFcoahJGWNh+djvS/UcxSgdNgvH6paUeoRwpE1n1 jmt5qkt0ZnUeQ== Date: Tue, 3 Jun 2025 15:58:19 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test Message-ID: References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wGBcazC2iMDwWARG" Content-Disposition: inline In-Reply-To: <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> X-Cookie: Avec! X-Rspam-User: X-Stat-Signature: m3o5k83n3sbet5nwzogf53myc4sn388d X-Rspamd-Queue-Id: D672280006 X-Rspamd-Server: rspam11 X-HE-Tag: 1748962705-256813 X-HE-Meta: U2FsdGVkX1+qQvSUJvRgF+HtgXIuGO1GvaT/UPVgNrJcwkHbNLzZNN+EVkBBppBRkbCFC1/I4PhAdK6x456rOMDF79GAvUUcj0HFegN2OuobRqdNHCO6ZGSfZZuRdCqRQu/P+RyIL8u3bB2+WThHrLW5fZ+gM2baVXuKElTuwfXxQkBJ3WtDDHUkbGfAnXRdEIWOKtNwncGuh4YAY/uTFpyFsoKRHLIp/2uamg5cJL8OaGsGJiZGZAy3YrAbqidAO/yurV+2LLmaYo+wgL1m2qElhTCeUyKTz8xRaMlYlYn2svUeJI+mq/oFVAJrLLZ3doQix4MA6SXjyzKizfWob2hnh5WtjxA5+D2jFI/1YWyuKMYQNKB2xKv9T+wai+bYJPffLZT9Jv3YVrGWamBXZBOb0PN51QAsKpeEthg25Y1R9RL4NIjpyyYaiFPG7tl++4bBApQTPfbTvR2xMEM3O9IooTjyqfganf9i4wpmZuPMdG+//PtTHbPFws2+R3oEaTZIQf8Jbf5UGJgcHXf4aCuESw7pFMRjPic/ZZCxmsaqdmKkYh/+HJKQKpssLrW1QID9ElzCtJ5EVJbIPBHVJOarUDXVkOo7u1I0Cz2t1aHrxmaNGDBZSuhOChqRfU9uuIN63vJuMSGBaCoVl3McOJxyyX7KLa7RnpyF3JbAdCrj2CRLoJbBg6myksY4KOoBw8QQbx7KrIENZ/a5XcHbkavK/Atce1f0RnuOb3KiSklT6vQDYbY4h1buycEOdd3oSXa7hKE0wMC6dJkiU17t5Cwr2xkuBcvWYFhV7S5OsEtniGA9DVINcmDy2v8ZU3mxcOS5dgTYIgkwH4qCHhgQapKmGjc4CbMFy79tvNrWT8Y9sPki1wl9syR70moWOPEQcLUaz4u5oLeElL/3KnW6ECabPn29CU17dlYwpzhTQmSgXURh46A7QF7aA7QGV8Q5e1RveEwpyWj/PjFW/4o AR64CH/m oN3oSAk19WNAfHd2kDX/P7g0KOWFYs8z6PJYUELqpw0KmEn57Xqi3qspNRFrDj/Gtc1YyGGbmK4gqZSYitiTQrMZH8BEfrMDGpkR484G6UInHtzohASk8R2yFp2yyBlV/kL8eGruTxXnikNe7qzU1bdHI3lxNX3oLUsLModku/c40Pv7bIxVfJ/i4UO235izLQBQdGM/i8tjywN4HcNujAid2R7COxiMnQTxPmrbGjvAB3SnhZTvBoWfkItVp6NiSOnPm/CngzKPUPBGfAEXfYp7hBXINNqLj4aKUBvaZ3Bv6Joej2rC/uhK6gQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --wGBcazC2iMDwWARG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 03, 2025 at 04:15:42PM +0200, David Hildenbrand wrote: > On 03.06.25 15:21, Mark Brown wrote: > > > > } else { > > > > - ksft_test_result_fail("Leak from parent into child\n"); > > > Same here and in other cases below (I probably didn't catch all). > > > We should log that somehow to indicate what exactly is going wrong, likely > > > using ksft_print_msg(). > > Can you send a patch with the logging that you think would be clear > > please? > > I dropped these because they just seemed to be reporting the> overall > point of the test, unlike the cases where we ran into some error > > during the setup and didn't actually manage to perform the test we were > > trying to do. Perhaps the tests should be renamed. > ksft_print_msg("Leak from parent into child"); Can you send a patch showing when/where you want this printing please? Like I said I suspect the test name is just unclear here... --wGBcazC2iMDwWARG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmg/DYsACgkQJNaLcl1U h9BpSQgAgFpxD0Mdq+PItFzumotzCmYbtGYR/xoJWOSeJ8XI0ORcZjN7ykn0FC63 ZWCqxTN5cLYFmVJQScqkFqPs3FrCpf+g7wHLcFomkFBF7Ev1GHTyf6fTPKcUiLZb kg6NfIW9SiH7jS2Vzf4q5EtURt+U+hWy5775NkBOLp+nIghWFLxoOVqEClVykTLV w3DPBxt8WZGAeXY7buhlDMAqBwZd5K+LkP9oJnxJwATmtUpyWEJyfnFwriCDcGY9 CyheODCZxRsbd5kqkFmgqRTDDM1H/+SG18BxHGULOpMdbfIxIYhmu4NFyy2wg9ov M14YSDvZv95CZVPSq81cUWoCuiseRg== =DEII -----END PGP SIGNATURE----- --wGBcazC2iMDwWARG--