From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E10AC369AB for ; Mon, 21 Apr 2025 07:40:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32E16B0006; Mon, 21 Apr 2025 03:40:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2536B0007; Mon, 21 Apr 2025 03:40:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A581A6B0008; Mon, 21 Apr 2025 03:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 883946B0006 for ; Mon, 21 Apr 2025 03:40:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9672AB9FE3 for ; Mon, 21 Apr 2025 07:40:28 +0000 (UTC) X-FDA: 83357253336.24.59FCB27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 37B1B20004 for ; Mon, 21 Apr 2025 07:40:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mc9DYfxb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745221226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LtHpodqllCmUNYoOHWLEm9hWJzsaKYZRW7itwMBbXPo=; b=bQrjLJ1hlzBCAclKz7nh7in9F+GiJfIKnQ59zgM0I0MTAvNTxhltyMkuC2vJnH4tNX7Y0G fhBIj5l2gRnlz0CuHwJGVjCZDM9W4gIZjcsZXMEE/4UDR5BmVeAlO+E6xhuxUWf/5zuQOj PYh/dyi6tL66oWdW11hmpfeksxqB4P4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mc9DYfxb; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745221226; a=rsa-sha256; cv=none; b=A/LPR9TBLieY9HYWoZe2P8JpJUMFiAN5d9RBEzPLU9YGh8OuKIUxmV1yVKZf3cDFpq+nln yyvowHoBDwG5CtwEaBZGrQI6CccWt1UALd+7YNgeny06MfCqvlWejOSG+GfwxBmO7IipW1 2kPimbchwbBwohv2zw28Hj75mYdSgK4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745221225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LtHpodqllCmUNYoOHWLEm9hWJzsaKYZRW7itwMBbXPo=; b=Mc9DYfxb3LkLMHZvCkG6CZq8hR9OXMevzPaIH9s8FY/tWvYxDoU7T9tXJFkksKaGLU82mW I5A2GDHirgiQDeP7AoCorTmSwf9v4GdeJHSG3ELGww2qc+7IKlyKrPMmdcWKRTXgGCu2kK yst0+i/+8BI4Q9zb2mbAVR20wNA/CXI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-ggxbsdPOM72Ubai8s5QRmQ-1; Mon, 21 Apr 2025 03:40:24 -0400 X-MC-Unique: ggxbsdPOM72Ubai8s5QRmQ-1 X-Mimecast-MFC-AGG-ID: ggxbsdPOM72Ubai8s5QRmQ_1745221223 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d209dc2d3so19397615e9.3 for ; Mon, 21 Apr 2025 00:40:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745221223; x=1745826023; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LtHpodqllCmUNYoOHWLEm9hWJzsaKYZRW7itwMBbXPo=; b=rUCwm4O62iG2STvjGyx4O+BQswbIk/xTTdliZRV1CUxSxz+oOqkppYymD/zEqQ62c3 DGSZwk1hT9klIFjaD8GAKgcG/TmvCMoJiH1nzcSLgIn9y6yhIL3GZstALZJPLSTujsBS Hcc+slh20y7Va+/oRRGE2iWFnRdjS0pbrmNSbtMOWBrauZTunv8Szc0cbEZQy6zPL1L7 V24k6DGdl0AW7T1ZUCJMGZyRyq0NIMhiCiAgQmIYpcj5rAvmreiyuj60O9i+3bnTPxzw ssPtfrYtx86v+G5MFE8a0vwsargOqp69xpxmdNL/I39lHktvsf28haSlb+M/nM7GRzCv CxKw== X-Forwarded-Encrypted: i=1; AJvYcCXhzGHsTKwknsmomBYdtD0UPHKeJWxDNe1g2xOIvSMTZaC7pMiW9/lG7HLh78WyRUxF9uEqPO2tew==@kvack.org X-Gm-Message-State: AOJu0YwvBn+bz61t9Qy/5Krx2zqdiQelPEimvKX8zjU8nlRJ8/qZydi0 o5MEuzIHhi1ILar4cUyZ+blNghJDvG7HrYMCSbacDKuPtRB48HzgWF5oWHUQJwPeP2TZUc55FRU 0w22kLkIIOVasUlfnSYLzOMlu4Z+zcAlLelnuONT+OewAgYiH X-Gm-Gg: ASbGncugCysfpkW4tm8NgS4Gn7YfdiEZagJxGmzdLmcKNhEgpPr4tK7HNfQ4NRvoK0l UvgyEkQOom3faKR5g9A1VM2Qra+EUBQm3tJ3T3E9ez1VZdKez8qPTCwdFPVWttGb6dOASY3H2Hg INNkYHJYPewX/jOfh0uxRLZKylTQpOzhxf7acAB3ZGend31QIvWrcV4Jn8Bcx3yD/ZvWRWtPy0F zd9vHlqAqJY/IYOwEdNFb8HZzUL0FswyQqIo1BjE/rs2nGiuB0WbfFiUCnfynhHN6knq34GfPWY S4lUF67ss1ACzytzxs87jXgGnrUQXLgkxH8ThcG8Lw4OiTjndubCSUre1cbRRiUfesUei1Q39Ak CjUIzqxOIqVmRegOCs8htx6+XtdPZfYqNEIznx6k= X-Received: by 2002:a05:600c:3ac8:b0:440:67f8:7589 with SMTP id 5b1f17b1804b1-44072c8905emr67251545e9.16.1745221222819; Mon, 21 Apr 2025 00:40:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaS9eb0GoGuJNkWivLFNSVkQuDFfAfr7ZGHpUHAUiVxHyeSnMneOX1eNd387oWuiqwQAcNbA== X-Received: by 2002:a05:600c:3ac8:b0:440:67f8:7589 with SMTP id 5b1f17b1804b1-44072c8905emr67251325e9.16.1745221222470; Mon, 21 Apr 2025 00:40:22 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d6e0364sm121710665e9.38.2025.04.21.00.40.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 00:40:22 -0700 (PDT) Message-ID: Date: Mon, 21 Apr 2025 09:40:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/rmap: optimize MM-ID mapcount handling with union To: Lance Yang , Lance Yang , akpm@linux-foundation.org Cc: mingzhe.yang@ly.com, willy@infradead.org, ziy@nvidia.com, mhocko@suse.com, vbabka@suse.cz, surenb@google.com, linux-mm@kvack.org, jackmanb@google.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org References: <20250420055159.55851-1-lance.yang@linux.dev> <2e501e48-8604-4813-b76a-d467cad67f53@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wWdD48M3kB-CovVuhxhkukPO3whbtFp6Qb5_-3EsxRE_1745221223 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 7eofewpuk3sym9x3a5yoxydmcxig76tx X-Rspamd-Queue-Id: 37B1B20004 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745221226-886270 X-HE-Meta: U2FsdGVkX1+2XkVDPlEf1jBoHYPLXg88zRx38XtsayM1Tw4/mIT0dQdkQqosbCp4DB1xCxFnTk/fdPDI8VYoIbNRRZgtir1dJCId4NZOT5U3AMQ9XBVZcu4cXp1KeCxnFjfpiZh/jwHcISlXTnYmmXMmJ2YvItTFNHEWu+l03LsWsBn+/PY4IhMr5v4VKwTm7zKaOLiX+mJDV6Bn0on7c8oArSJCZwsTMegP5Nd1ykcxsUq2tl542eP5wukFks4ygwCH2QUqfxV4ep63sU42u3ergdrdWTG07n/XB4uFKLwUK5arltKaSohi7eXLffJ62P40GFqZ4v1t6FDrkPBjft/4+11lpgn2lt2yleX6VN2H7owzrYWfWRE1pFjE4nVSZpKC5hpxZp2/ioEJCxq+kEVCBBPrdAIgnK5iyzeujZrLd4Ce1kFprqzLbG/dVPzS1Wj3CIn4fMbUBXIdj1z7Anvzb2D5Lex9I0vIbPuDlmv57afxEShvPhS/h1BMald9OjL+Bc0YHBTMeblxTFNmplyr1QfYtROhzQYKOdCHTRgd197TKC4BoDFPw69VF3yudHbzKNIEwPiAzwSEnC8Pu14qr17SsLLDx2WeCMlEURT+QLvpHqC+xWWJGwPjUhCZyJGWLE8g4y54cp9Lv1LWqo/kGJiAawQie4vLFYWh3xG4GCgiJGgorazujky0X5Y8mmWfCpXScPLw50JJi1+gvV6Oc1EX4tFJAn5KGF55fjx5zFJClP047Z9+8mGGMv/23wT+ZobN+qgxeL8aZKGJnkOR3/LFx8TNH+aWhnnKF068QjNgU/1cLk9ZwTrET1D2CESkGJiW9ys4iAJa5zjyRtxRAnpDRPnYncJRaRegLDjBslgEJeww+bpALWc0/+g4qemGqrTnCq0iP/GWUSI2MKfhPJhrGpgfoWaMG0C2T4QDOehPlw2SQlRHW5phfL1/6rHDmc5WZxMLiAVcuOK j795Zwd6 tGNxFioVz94qv0G9Jc/Pcx7uy5fe1rz3IKJ2gMKX1gs2RYt+zH+E9ieugdNRuyslBsASPZVCTgiKdJfSweLbdnYvAr8qbBg2SZ3H9q4B9LfOGRGWZaFDxHu92BZZtsFp39R7POUQiNwKv5ciRvjz8v5CC3WYqOyXsKm3pwkii39vpnbS9RLiHApJO/JlC2G0+8XqmQW31scLYlU5wD2qh6QJw7XEERSy+pOXYN14keQDpmOpnQDBpP+j84oRzuTFUVw9Kng8owLLAUtOMgspOv0R5lsV9tBaF7XCW2NRg5RJcHefRj6hw9p3ox3R1TBe7+vIK576Dr2Pfu51n4595rgKyvolZUPp0iRkU818eQ6yZKfvOHCqSjpGxB7fZFd/FrepGtgm2qsKD0QhA0zc28n5FUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> Are we sure the compiler cannot optimize that itself? >> >> On x86-64 I get with gcc 14.2.1: >> >> ; folio->_mm_id_mapcount[0] = -1; >> >> 3f2f: 48 c7 42 60 ff ff ff ff movq $-0x1, 0x60(%rdx) >> >> Which should be a quadword (64bit) setting, so exactly what you want to achieve. > > > Yeah, the compiler should be as smart as we expect it to be. > However, it seems that gcc 4.8.5 doesn't behave as expected > with the -O2 optimization level on the x86-64 test machine. > > struct folio_array { > int _mm_id_mapcount[2]; > }; > > void init_array(struct folio_array *f) { > f->_mm_id_mapcount[0] = -1; > f->_mm_id_mapcount[1] = -1; > } > > 0000000000000000 : > 0: c7 07 ff ff ff ff movl $0xffffffff,(%rdi) > 6: c7 47 04 ff ff ff ff movl $0xffffffff,0x4(%rdi) > d: c3 retq > > --- > > struct folio_union { > union { > int _mm_id_mapcount[2]; > unsigned long _mm_id_mapcounts; > }; > }; > > void init_union(struct folio_union *f) { > f->_mm_id_mapcounts = -1UL; > } > > 0000000000000010 : > 10: 48 c7 07 ff ff ff ff movq $0xffffffffffffffff,(%rdi) > 17: c3 retq > > Hmm... I'm not sure if it's valuable for those compilers that > are not very new. Yeah, we shouldn't care about performance with rusty old compilers, especially if the gain would likely not even be measurable. Note that even Linux requires 5.1 ever since 2021. GCC seems to implement this optimization starting with 7.1 (at least when playing with the compiler explorer). -- Cheers, David / dhildenb