From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FFEC4332F for ; Mon, 6 Nov 2023 02:31:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47EA26B0248; Sun, 5 Nov 2023 21:31:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42E3F6B0249; Sun, 5 Nov 2023 21:31:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31D2D6B024A; Sun, 5 Nov 2023 21:31:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 246436B0248 for ; Sun, 5 Nov 2023 21:31:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4F2A612037B for ; Mon, 6 Nov 2023 02:31:11 +0000 (UTC) X-FDA: 81425952342.26.4CDF1A7 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id 0C6E418001A for ; Mon, 6 Nov 2023 02:31:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699237869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uyfn30DISt6nhjR8mnE2FTq4hVBNgfjXk4cA6O0YfxI=; b=R1KsIQ0qqVsi8WU537adNcNbmkDc8qjBqNEyJKdIUzM0NTf+eXdUApZLjfYe1PlbJYC+li 1PwpZ420lhCVQyKNw9zegQ52KthbsUz7HjmVzAzBNMkh1LeUBeI6BrG0Io/JVzZuaWHe71 pgqhRuMsh2RPxU1m8LMEFcrYukXVt2o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699237869; a=rsa-sha256; cv=none; b=dpxpcVwrVPDIH09sx/tAEHtiKavlOtlC12L5AqvW3YycaY5+kknFP0rdHE6n1kw+seni4n bdDeZc2roo37Asn+K+l82LJqoM+kjvEiFUJ59ZQX+TBefq5ob0CHwppP7AJL1L+cFqPbpt yT8tf6rbj90oHf5niwvIT+qlwfuk4z0= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SNwM158NmzvQK0; Mon, 6 Nov 2023 10:30:53 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 6 Nov 2023 10:30:59 +0800 Message-ID: Date: Mon, 6 Nov 2023 10:30:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/10] mm: memory: use a folio in zap_pte_range() To: Matthew Wilcox CC: Andrew Morton , , , David Hildenbrand , References: <20231104035522.2418660-1-wangkefeng.wang@huawei.com> <20231104035522.2418660-7-wangkefeng.wang@huawei.com> Content-Language: en-US From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 0C6E418001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jde8me54hufwnuab6cbuxqktr6qwzxoz X-HE-Tag: 1699237867-822370 X-HE-Meta: U2FsdGVkX18PAbHHyilpDKrOGxQLnp4tYMZ12aw/EmMk8momFRNSvceScfrBpm+cMoTGJHk/kpA86MB136IRg0D6Z/VAEXpPvMC6694TWuskDSxo3CqrfStrmp9GxyMKGLpYncYJDG73lW8TOgnzbbJwhzhjj0ssbX4xdSTtyBloL7zWLH9qVf5B6ZzrUkATOWcDQkain+tbFmq5IvVSD0v7/n2eoSfCjGI2c3DG2zlukaafHFAJO+lgmHWl1Z6FDaag9tNzJVP1Q2hgo/pZq4RIeVdg0ZWuZNYYVmD93tlAA6gmP9AGwrL0NWQcfdXQymUmu869JnSRqrZ1455yAipSVPP5f4l74ULgPclL7jN2ZzAbDhtWaJnhow2AU/ake3wrpInwsACzuhv0/b3/vAkjHHC3m3jjeLj1JqHr1S8mRU3OjxEGf20/9/1oiRoDBxFZvsf2RSGjDJ6h8VPwiE5H0OIimmsWHb+PsDUagdejzAKYHyiF/vXxVW2IfhtCjrSQXne1d4ABa1HWBxFkmk0c9PfioI+gCFxugt9q6i0IljZ+PrHNOtssRihaCDfcvlyzmRqfHyOZ2ERMY5p4KzGwWJzPPRig+nBpqXCfovF8vSHBeWDy/a/RaJoMac5zsXi2V4VA6Wo2/1thXULq52ORb3oC3pRqSc6+4rLR131jSibFadNSoKzgMzk0Vo4eyuS74Q6kzu3dC2ffkoVW98g7nqIE8GR8HXiy4kxcX6kwS2M0nShDXSX6p9rwTdMumv3NLdgryq/JbCIsGaTgZ8AhPVRNe/o6AZ0T25RKaPkhBKzPfVPAhi8K9FK+95HzNRIh1Ac3p0f7067k7Q2jY7f0hezgTjvGLZVeYSE97sfFSWEbUUFAI2YVIrmSjilRYa3/2b3SoO6p8MYaMp9NJUC2D25TAjVs3eTEXoTMShWU2wZbt/dhwN+xUGIINdUs6m+lyRxVkZpM8C9WYxF LgP6MnL6 h1aKJ+eSbi2z2N2dNHWnVcraf9jD0qC9YB1YWs4PfcWLsg00dAbURsoTYMyN4AUNdPQGhBneYEb2zE3cuEnYOn0J1JgEIeL+gk6EHJXcBWNW5yxiU3xcQMGrm/jvxsJpYKMK/YzmRuxMzQN5ziDq8WWITkfjxIcjYkQaWbFl6afJ/tBmxc68mcK3P87z1V6sE4GUEP+2UI7+CE/9fmFQqK0QwUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/5 1:20, Matthew Wilcox wrote: > On Sat, Nov 04, 2023 at 11:55:18AM +0800, Kefeng Wang wrote: >> -/* Decides whether we should zap this page with the page pointer specified */ >> -static inline bool should_zap_page(struct zap_details *details, struct page *page) >> +/* Decides whether we should zap this folio with the folio pointer specified */ >> +static inline bool should_zap_page(struct zap_details *details, struct folio *folio) > > Surely we should rename this to should_zap_folio()? Will update. > >> @@ -1487,10 +1492,10 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, >> * see zap_install_uffd_wp_if_needed(). >> */ >> WARN_ON_ONCE(!vma_is_anonymous(vma)); >> - rss[mm_counter(page)]--; >> + rss[mm_counter(&folio->page)]--; >> if (is_device_private_entry(entry)) >> - page_remove_rmap(page, vma, false); >> - put_page(page); >> + page_remove_rmap(&folio->page, vma, false); >> + folio_put(folio); > > This is wrong. If we have a PTE-mapped THP, you'll remove the head page > N times instead of removing each of N pages. This is device private entry, I suppose that it won't be a THP and large folio when check migrate_vma_check_page() and migrate_vma_insert_page(), right? > > I suspect you're going to collide with Ryan's work by doing this ... > Maybe not if the above is true, at least for now. Thanks.