From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B801EC52D7C for ; Fri, 9 Aug 2024 17:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 301786B0098; Fri, 9 Aug 2024 13:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2891F6B009A; Fri, 9 Aug 2024 13:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1038D6B009E; Fri, 9 Aug 2024 13:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E65276B0098 for ; Fri, 9 Aug 2024 13:13:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8B0A381240 for ; Fri, 9 Aug 2024 17:13:07 +0000 (UTC) X-FDA: 82433352414.19.ED34A1F Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf21.hostedemail.com (Postfix) with ESMTP id 735571C000D for ; Fri, 9 Aug 2024 17:13:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=TzG+m+kx; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.44 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723223552; a=rsa-sha256; cv=none; b=LjmRdYn2PUsa76p1z4lmCmeIpw94LQODFswM1O4o2T25MiJjFkzoFQcUpRXbwiWsR8cJ9q X5UlrHnpujnxALaPjN9qLEqoFJ3bpz+vrdl+YatfgZjh+O75TEfyXC5PJ4iA9wWAKCCIMX 58rorjOal9XB/6rRcSaLF0+/4oYVB4k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=TzG+m+kx; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.44 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723223552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Axmz1138R8c0Rv8tx79G9j2E5WenurXLDxEEM4p5OU=; b=59ZUg++4X2TQSOqEq0YKYNLOPmSgjhg4bDRL4kMxDPZQ66HlNKxclatzjAcXwabNHiQO/g X6C68Dq/TvvIXyAkd17oodOgQKSnfSoqe+HZRviOdiXdV+FQmhvkMdTyUvk+MdLJ0MiEmq 4hB9ffDbmAkFJ3W2rQzfKDYT1vtNB5E= Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-81fdcd41e4cso7353739f.0 for ; Fri, 09 Aug 2024 10:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1723223584; x=1723828384; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Axmz1138R8c0Rv8tx79G9j2E5WenurXLDxEEM4p5OU=; b=TzG+m+kxF+6sPj2imGvlOJ+dOnzht0mEUaveGtpiWgNR5oDmKViO6CaSkapbBVnFuJ Wigvbrskq+vYYaKEBatbRKgsME87TnVvLkn1nQNtKaQykLzf/5xg/t0N52WMAwMRcnYB c8smcCDw4Y56kX1H4tstPDrMbdZMNlN7rrgoI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723223584; x=1723828384; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Axmz1138R8c0Rv8tx79G9j2E5WenurXLDxEEM4p5OU=; b=LprvL22Eb4w1dBYjLGd+j7knNOKESVwkab4fReuMPkQ6rNpNjlV9whVfCYRkReL3Fb k9n7fQteVWup0epq1/DZ/J/LXshhbeJUEiTZGLoRFAw6O+KOV/XIxAFgcQpKh83mmimF joCnF7r4ew46zPi3dKbvu1mAYDlnaPU9/nHHGEqEZYtSfcKEc3Z2hFND8V2tLghotXwX TpB/+yL86GgvxdX71lBwsGbrLNwIM6o6Kv8cA3pLLtYZFEumTIROLcNh3envxl8NXPTp FYW2yzNulLtZmA2PfyeArCv4eZSgvAAVk2WJt7c0jF7eur5ndskxiDn5CvYiXTLhZXOq l5eQ== X-Forwarded-Encrypted: i=1; AJvYcCWi5Ug0U00Sj7ivD7p7JAF9rDIkp00jyVD6M6agIl77ydK2DlgVeO5hTlH5Sb5QsnXm092jBfiqkQ==@kvack.org X-Gm-Message-State: AOJu0Ywv7BWfFczAJDe/PhRsLeyiUl5MLpKSicatlxykOgr4B397N2z1 QDsR4xrWMmqZ2B/xfrJ9Wcp8TWPpL5EOvyrPBkamVZ6V+oE7lV146vPo6E86+XE= X-Google-Smtp-Source: AGHT+IF+fCct+358RjirWTjwBGkiFJaSbrNLE4ozb3RU2AEnZIooYLpIPxpsAMP9++rs2g3JkG8KUQ== X-Received: by 2002:a05:6602:2193:b0:81f:8295:fec5 with SMTP id ca18e2360f4ac-8225ece0b3dmr147119639f.1.1723223584073; Fri, 09 Aug 2024 10:13:04 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ca76a5d227sm10391173.162.2024.08.09.10.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 10:13:03 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 11:13:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] selftests/mm: Do not fail test for a single migration failure To: Dev Jain , akpm@linux-foundation.org, shuah@kernel.org, david@redhat.com, willy@infradead.org Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, osalvador@suse.de, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, ioworker0@gmail.com, gshan@redhat.com, mark.rutland@arm.com, kirill.shutemov@linux.intel.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, broonie@kernel.org, mgorman@techsingularity.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20240809103129.365029-1-dev.jain@arm.com> <20240809103129.365029-3-dev.jain@arm.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240809103129.365029-3-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xqf9w98ryjwi6j98bk1a5gokh85z3ed5 X-Rspamd-Queue-Id: 735571C000D X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723223585-639885 X-HE-Meta: U2FsdGVkX1+DOmxF3Sv1xOVTOTK6xv0wOY4+086SP3saftOOY/ZNDqCUa6vTZJ7gbpovIjNV/3YBXjcKEzqUr7h+Y67cwUBx576u6Lvg945U8srfArDzP62kPqjrOX9Utfz542lxTP/U/rzuJNcSjGulHtk1TZHPrUalBvEGuE4ecEz81DkDbL/B65LbSSTtdhNdH3Sj4C2U1bwYK4AltG/ZSKLUOvFQCGFqXEdEymUjQgnbb+dUwYuif5tq5NqsDY7uSAidsZJVRyboSRSyiLFHqtBUfOZWq3aMpQwb5mzY0cqbWVrVpqEigUT9xkv86lv6zhtX/91rHoT/NAzssU6wsjYAywenNZBJw8Ono6vh/8NLbDXi4i4LoVId7gCre+4vu2iIsCUciok5cnK5Db4101AQKbGqAEbcRVzVyFjgq3My4fgVZXbi20Ko0RJvhOhedmGoek0scX0L5gHX5mxlPYmrqllqNWVKhSB63AWYnXuvXiSGpV/eJhOmB+uZ4v9bXWjD85JOrzmDaTNO8dHrzIuiATebF7k5mozaIFNqvYZ6zai48wjeXiiiRDnp/IjracmqDCcE3J/JpMG3s3NWuZDWCnxDm2t5nHu7MvDqAopt0ap1nTWfPy7Jf+xx5zHQr9uumk8e5l/GRLfU8ttyfmweeGXq9LXEWlDnhHyc/IHd/WlgQNUOVBvsIMeDMIAauADAWFtIwun5LaZX7e7dgq1u/LANpMpH9+fNKuKLdpSYlgc2uM9mWiC0ti7SMQZvaXukSU4QFoHRboccSxlOOVMu2bqU80iK6P/E1NcYyeF5TIWx6SiloJlJAtQaaWBrALPVg9M1U0H6so2AfYNJFtRIOjOMSVmAgcvLaVKVXddrAEN3yEDstshNntkYnP/O/nBCzoq4JlmoOFVFPZ0Vf9WyDsuTSqQaHkChpfjnuUj46NAKaL50jQy7aI1EcsiDCU22uRzh1mCLqya jCrwAgMa Ho5i8JXYc89gH2rtln37ec//8NnZAphc5ojaURFnyHHjZhNNlK/zMZn0FEgAbOhDcGSmFhwOrfl80vz9D1f5JzrA1jLxYfzSjBRviuj114ur9eFQNFAP/grekrGOIKdyRdbPzIVhx3tu9hoNFBe2geXbxa/iL0jk8ng3BXCoQdmWjbz4BzuN+pRmU5ybmooRLlxl82K8m3ZBWLDCaGjCuQyAJ+kqu1katiM07AvH+oFZgP5zI4YQbMOhcMpd+SbY/Jutjw54HLn+ssHtTl8vorC1NheywbcBwpJGrNDBxwPLfGxqpFFC6lz+jgFN88NuTGzl6SFH1QXAcW37KP4QbtTDgosyeb+vb4dAd/jc2GH5MRbdOfkDHnKLhuRETFgxd7s9zqFBq+EsMiVlBmmaqjjTiEVE+TVBCByQJ/C7qCpenPOBPO5RN8zzuVc7j21iQYb2l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/9/24 04:31, Dev Jain wrote: > Do not fail the test for just a single instance of migration failure, > since migration is a best-effort service. The cover letter says: "Given that migration is a best-effort service, it is wrong to fail the test for just a single failure; hence, fail the test after 100 consecutive failures (where 100 is still a subjective choice)." You do want to mention the above here. The reason being, I would like to know what this does to the run-time of this test if migration fails and retried 100 times. > > Signed-off-by: Dev Jain > Suggested-by: David Hildenbrand > Reviewed-by: Ryan Roberts > Tested-by: Ryan Roberts > --- > tools/testing/selftests/mm/migration.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mm/migration.c b/tools/testing/selftests/mm/migration.c > index 6908569ef406..64bcbb7151cf 100644 > --- a/tools/testing/selftests/mm/migration.c > +++ b/tools/testing/selftests/mm/migration.c > @@ -15,10 +15,10 @@ > #include > #include > > -#define TWOMEG (2<<20) > -#define RUNTIME (20) > - > -#define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) > +#define TWOMEG (2<<20) > +#define RUNTIME (20) > +#define MAX_RETRIES 100 > +#define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) > > FIXTURE(migration) > { > @@ -65,6 +65,7 @@ int migrate(uint64_t *ptr, int n1, int n2) > int ret, tmp; > int status = 0; > struct timespec ts1, ts2; > + int failures = 0; > > if (clock_gettime(CLOCK_MONOTONIC, &ts1)) > return -1; > @@ -79,13 +80,17 @@ int migrate(uint64_t *ptr, int n1, int n2) > ret = move_pages(0, 1, (void **) &ptr, &n2, &status, > MPOL_MF_MOVE_ALL); > if (ret) { > - if (ret > 0) > + if (ret > 0) { > + /* Migration is best effort; try again */ > + if (++failures < MAX_RETRIES) > + continue; > printf("Didn't migrate %d pages\n", ret); > + } > else > perror("Couldn't migrate pages"); > return -2; > } > - > + failures = 0; > tmp = n2; > n2 = n1; > n1 = tmp; thanks, -- Shuah