From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48410C636CC for ; Wed, 8 Feb 2023 09:15:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99BF06B0071; Wed, 8 Feb 2023 04:15:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 923A36B0072; Wed, 8 Feb 2023 04:15:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79D856B0073; Wed, 8 Feb 2023 04:15:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 608CF6B0071 for ; Wed, 8 Feb 2023 04:15:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B315A00FB for ; Wed, 8 Feb 2023 09:15:51 +0000 (UTC) X-FDA: 80443567302.25.C67CBA0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id 0DDC640007 for ; Wed, 8 Feb 2023 09:15:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=krBSNn42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t8eM9FTT; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675847748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6i3DQ9ADagvo6tUvd/7VoA0Rk5hn/gfeYkFT3pxlEFQ=; b=f2oPGuhev5NWQFaSEu0BceDy6IrXd4/RnPOgMrP66HWr+PWCYe5+ZlPEiFQHnlqDPq8K4e FT9h2Qw1cF1KRO+c70zWFLPEfBLR7GAoy7sp2Go3bYMo0VEnXdKICqobaV82jZmEQ3/d2u RiRoISFnerc9DCNNlaAPhHRMKC3wsiA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=krBSNn42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=t8eM9FTT; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675847748; a=rsa-sha256; cv=none; b=8Y1KcZIGvNw1AjYaojfTUcNlzGsaxXwhKeVkt99wyInhDQtl9fK7hGclsof4QrfA9/KuUB 9bRjmTUoP6BB74NVydP6o64cR3y2WIl8kTiV/IEvruKgrS8fP5w+1YswkfhCfgKtdQvGst 0UG0Zy4WFDSiEIcBc7W5oR7jY0UIV4A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5DD3C33D56; Wed, 8 Feb 2023 09:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675847746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6i3DQ9ADagvo6tUvd/7VoA0Rk5hn/gfeYkFT3pxlEFQ=; b=krBSNn42FpsDhDwCLLag/72t40la7FaIaRdUbLsR2hn0hI6Uri/GYRZ7Nd9d+iWJO2GhcU Xh2AKLT10AW7WEM+wF2I0nYmoO2R6JDw0pJd7v8AYKaqMn5Vu+CgnN3kG4FQI3zYk+mXhs haaSEpkgZL6go8RI9x4AJLZZ34xrc74= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675847746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6i3DQ9ADagvo6tUvd/7VoA0Rk5hn/gfeYkFT3pxlEFQ=; b=t8eM9FTTqx3vUd8b1lG0eXuBOGGgUS+jr91RhQE+QuiZ4SEGoF72wI6Zuxl0IMLy2j/CxQ FCexphRlc1t3BsAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0C81713A1F; Wed, 8 Feb 2023 09:15:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PvhFAkJo42NWEwAAMHmgww (envelope-from ); Wed, 08 Feb 2023 09:15:46 +0000 Message-ID: Date: Wed, 8 Feb 2023 10:15:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: mm, slab/slub: Ensure kmem_cache_alloc_bulk() is available early Content-Language: en-US To: Thomas Gleixner , kernel test robot , Shanker Donthineni Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Marc Zyngier , Michael Walle , Sebastian Andrzej Siewior , Hans de Goede , Wolfram Sang , linux-mm@kvack.org, "Liam R. Howlett" , Matthew Wilcox , David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin References: <202302011308.f53123d2-oliver.sang@intel.com> <87o7qdzfay.ffs@tglx> <9a682773-df56-f36c-f582-e8eeef55d7f8@suse.cz> <875ycdwyx6.ffs@tglx> <871qn1wofe.ffs@tglx> <6c0b681e-97bc-d975-a8b9-500abdaaf0bc@suse.cz> <8b7762c3-02be-a5c9-1c4d-507cfb51a15c@suse.cz> <87edr1uykw.ffs@tglx> From: Vlastimil Babka In-Reply-To: <87edr1uykw.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iyf6qmcaipsa5x3ksqncje9abqwbuskd X-Rspamd-Queue-Id: 0DDC640007 X-HE-Tag: 1675847747-467935 X-HE-Meta: U2FsdGVkX1/IuLbozbblTI/1Nkc7SB/g6tfhfjcFOZCSbpnxgeFy4iTLyw7ZjrTlFj0IWuOYCOBy1Q25QhzCuoWVuuXhS2S3+MrD14rVTc5G8LWwFzeCLLqX2C4b+egkCTAJOrf5y5BZHwgnpXZl4aQWy2mHIY+tOiyUXPgJDz+FKA8COoF565muQMdSCguIYoYUKmNOctxMrt+707tW81Y7i/pvvZjK00OrvUUZLXyns3gHy+KqntBR7yljKs9+nVlgWTlAZXLvr5aU+L3Jap07ITcfcIcGf1zkzoyhg7YTFgZvHRj6Eb4i3k9HrUeDnvLEQ+gOmLAZnbj1GybnPF2WNtZEp1snNIEmOGvi3Ma3nha1sz9/YJHcS9qIAxKuUAcaU4Reuk/UoQAn2oJxw+UhftETcjL+KE0RfkgBD3/DaP0xGO1MmGXy9zauB7U90SqGziO7k1Rcy28Ls3OX8EV+tuCQW90K/+hMSzKoCBpghszLvtG4+TIT6tI9I4WBfVlRJz9aJXEjajplu2CJX2el6Zzs7gcQRtaapLMjj8vBjkhVABNIHBO7yMALce8E/+IGk0TASRDU6FEO4k7SoWtw++8e2yR0X0h7o5Dr6bKFTaWpl7VCMngX+BRi5xBvHVLsnRGctRMoP9MSFYNRCAYSah0f4h9M6KSjk7rHeJ5pQfhi6+nmxytFfhj0fEldNtUf8Zf1ey+WiJLiyICwtcKV6eiAuhRrfjr/CKv/6iIQiOlaOIVfJ/8UPRoQVAVh2vrcX+HkN5NHa4mL/Z0IYstu1+02GtIrF3BZR8MbUpklGy3H+AterRSS1rlvpeWi5GavMaUPTwnDMAuPU+2bGZuFLiUmdoAij4WtwktjvVvLOeTeOdPNo3WnC5I06ZD34yoFPQXMe/sKS0COh7Ys+/r7+6lGtYIVh2GePLXaWdak5IW1vpfLMfpb6Brqqf6xE04Gf+tdaWzGvQ8DZf5 8H2skGgd sA18nsO2kyBIW8k+T7ib/8FNy16cCywpl0bDUhxsD63+WtjZChumD9N55qbHdZ2/gQxdwwRLaaftK7k58jnjSnjRJyJjWJnDcbIfB2fQMoPAk+hdZjCFXw0E7mgsUrPXmrLMiIc3jk9TJsqXhJonzGkVD9yRJbCKCSMmtABOqasdDImm86kdBhmTp4sA4JYsfJyP2/YDvjs/l7wHHSHtjqxMlBe0fFymFFgTWeDvfz7QUvznMFM/9PsXyuXOEzNrgsxvzN1gKhG79YSz/HiXEJ4EQoZzaSVkVYf+KadtF4hnU/MvNRKGAf3Pd/S8Js7OnsIqdLenfdVQpbVViCvRSfy5qFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/7/23 19:20, Thomas Gleixner wrote: > On Tue, Feb 07 2023 at 15:47, Vlastimil Babka wrote: >> From 340d7c7b99f3e67780f6dec480ed1d27e6f325eb Mon Sep 17 00:00:00 2001 >> From: Vlastimil Babka >> Date: Tue, 7 Feb 2023 15:34:53 +0100 >> Subject: [PATCH] mm, slab/slub: remove notes that bulk alloc/free needs >> interrupts enabled >> >> The slab functions kmem_cache_[alloc|free]_bulk() have been documented >> as requiring interrupts to be enabled, since their addition in 2015. >> It's unclear whether that was a fundamental restriction, or an attempt >> to save some cpu cycles by not having to save and restore the irq >> flags. > > I don't think so. The restriction is rather meant to avoid huge > allocations in atomic context which causes latencies and also might > deplete the atomic reserves. Fair enough. > So I rather avoid that and enforce !ATOMIC mode despite the > local_irq_save/restore() change which is really only to accomodate with > early boot. We could add some warning then? People might use the bulk alloc unknowingly again e.g. via maple tree. GFP_KERNEL would warn through the existing warning, but e.g. GFP_ATOMIC currently not. Some maple tree users could use its preallocation instead outside of the atomic context, when possible. > Thanks, > > tglx